Clear Browsing Data to use the new Collection UI. We might need to keep 2 versions, since it could be weird that settings has one off-screen using the new UI.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd3ebf42cf91d49e39c9c5eae4952279cea80c47 commit bd3ebf42cf91d49e39c9c5eae4952279cea80c47 Author: sczs <sczs@chromium.org> Date: Thu Apr 12 17:48:26 2018 [ios] Presents ClearBrowsingData from HistoryTableContainer Initial CL for hooking up the Bottom Toolbar button to present ClearBrowsingData modally. In the future the presentation of the ClearBrowsingData VC will be done inside the NavigationController, this CL is just the first step for that. Bug: 805201 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie950199bd14c7b256db62880983ba7166390e28f Reviewed-on: https://chromium-review.googlesource.com/1000405 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550260} [modify] https://crrev.com/bd3ebf42cf91d49e39c9c5eae4952279cea80c47/ios/chrome/browser/ui/history/BUILD.gn [modify] https://crrev.com/bd3ebf42cf91d49e39c9c5eae4952279cea80c47/ios/chrome/browser/ui/history/history_coordinator.mm [modify] https://crrev.com/bd3ebf42cf91d49e39c9c5eae4952279cea80c47/ios/chrome/browser/ui/history/history_table_container_view_controller.h [modify] https://crrev.com/bd3ebf42cf91d49e39c9c5eae4952279cea80c47/ios/chrome/browser/ui/history/history_table_container_view_controller.mm [modify] https://crrev.com/bd3ebf42cf91d49e39c9c5eae4952279cea80c47/ios/chrome/browser/ui/table_view/table_container_view_controller.h [modify] https://crrev.com/bd3ebf42cf91d49e39c9c5eae4952279cea80c47/ios/chrome/browser/ui/table_view/table_container_view_controller.mm
We need to actually create a new VC that uses the new design, and push that onto the navController.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/977cd5be66e4e9a50d0d4e69480c6984ddd855f7 commit 977cd5be66e4e9a50d0d4e69480c6984ddd855f7 Author: Rohit Rao <rohitrao@chromium.org> Date: Wed Apr 18 16:22:01 2018 [ios] Converts TableContainerViewController into a UINavigationController. The custom bottom toolbar is removed in favor of the toolbar already built into UINavigationController. Showcase support is removed because this container is no longer materially different from a stock UINavigationController. BUG= 805013 , 805201 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib8e78793ea73c411ad8c72cabe18568c4cb71840 Reviewed-on: https://chromium-review.googlesource.com/1015541 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551709} [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/history/history_coordinator.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/history/history_table_container_view_controller.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/history/history_table_view_controller.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/table_view/BUILD.gn [delete] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/ios/chrome/browser/ui/table_view/table_container_bottom_toolbar.h [delete] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/ios/chrome/browser/ui/table_view/table_container_bottom_toolbar.mm [delete] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/ios/chrome/browser/ui/table_view/table_container_bottom_toolbar_unittest.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/table_view/table_container_view_controller.h [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/table_view/table_container_view_controller.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/showcase/BUILD.gn [delete] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/ios/showcase/table_view/BUILD.gn [delete] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/ios/showcase/table_view/sc_table_container_coordinator.h [delete] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/ios/showcase/table_view/sc_table_container_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db88c7cd11b60a52d4025deea7a7b8ea3bc8b7a7 commit db88c7cd11b60a52d4025deea7a7b8ea3bc8b7a7 Author: Chris Lu <thegreenfrog@chromium.org> Date: Tue May 01 15:55:39 2018 [ios] Create ClearBrowsingDataTableViewController Presents an empty ClearBrowsingDataTVC managed by a ClearBrowsingDataCoordinator from the Bijou History Page. Video: https://drive.google.com/open?id=1bD6WAaS3SbqMuR2YyrgsWYpKciUXSvLP Bug: 805201 Change-Id: Ic1bc9dc43920fd5f48ba3df861d1cc51bf640987 Reviewed-on: https://chromium-review.googlesource.com/1029120 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#555052} [modify] https://crrev.com/db88c7cd11b60a52d4025deea7a7b8ea3bc8b7a7/ios/chrome/browser/ui/history/history_coordinator.mm [modify] https://crrev.com/db88c7cd11b60a52d4025deea7a7b8ea3bc8b7a7/ios/chrome/browser/ui/settings/BUILD.gn [add] https://crrev.com/db88c7cd11b60a52d4025deea7a7b8ea3bc8b7a7/ios/chrome/browser/ui/settings/clear_browsing_data_coordinator.h [add] https://crrev.com/db88c7cd11b60a52d4025deea7a7b8ea3bc8b7a7/ios/chrome/browser/ui/settings/clear_browsing_data_coordinator.mm [add] https://crrev.com/db88c7cd11b60a52d4025deea7a7b8ea3bc8b7a7/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.h [add] https://crrev.com/db88c7cd11b60a52d4025deea7a7b8ea3bc8b7a7/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/497980aecb18dbe5c39aba7ec31535113c33fa07 commit 497980aecb18dbe5c39aba7ec31535113c33fa07 Author: Chris Lu <thegreenfrog@chromium.org> Date: Tue Jun 19 22:42:25 2018 [ios] Implement ClearDataOptions in ClearBrowsingDataTableViewController Adds the clear data type cells to the table view. Video: https://drive.google.com/open?id=11wNSwTOGKwI9r_6-ojWkLmMHYc-lqvAH Bug: 805201 Change-Id: I6729233d8a3c4d42bc4b649d56ae0f786ec59b5b Reviewed-on: https://chromium-review.googlesource.com/1101907 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#568624} [modify] https://crrev.com/497980aecb18dbe5c39aba7ec31535113c33fa07/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/497980aecb18dbe5c39aba7ec31535113c33fa07/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/497980aecb18dbe5c39aba7ec31535113c33fa07/ios/chrome/browser/ui/settings/cells/BUILD.gn [add] https://crrev.com/497980aecb18dbe5c39aba7ec31535113c33fa07/ios/chrome/browser/ui/settings/cells/table_view_clear_browsing_data_item.h [add] https://crrev.com/497980aecb18dbe5c39aba7ec31535113c33fa07/ios/chrome/browser/ui/settings/cells/table_view_clear_browsing_data_item.mm [modify] https://crrev.com/497980aecb18dbe5c39aba7ec31535113c33fa07/ios/chrome/browser/ui/settings/clear_browsing_data_coordinator.mm [modify] https://crrev.com/497980aecb18dbe5c39aba7ec31535113c33fa07/ios/chrome/browser/ui/settings/clear_browsing_data_manager.mm [modify] https://crrev.com/497980aecb18dbe5c39aba7ec31535113c33fa07/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.h [modify] https://crrev.com/497980aecb18dbe5c39aba7ec31535113c33fa07/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.mm [modify] https://crrev.com/497980aecb18dbe5c39aba7ec31535113c33fa07/ios/chrome/browser/ui/table_view/cells/table_view_text_item.h [modify] https://crrev.com/497980aecb18dbe5c39aba7ec31535113c33fa07/ios/chrome/browser/ui/table_view/cells/table_view_text_item.mm
https://chromium-review.googlesource.com/c/chromium/src/+/1103584/14
Comment 1 by sczs@chromium.org
, Jan 24 2018