New issue
Advanced search Search tips

Issue 805200 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-13
OS: iOS
Pri: 2
Type: Task
Q2

Blocked on:
issue 805192



Sign in to add a comment

Collections: Add support for LabelLinkController

Project Member Reported by sczs@chromium.org, Jan 24 2018

Issue description

User can tap on history.google.com or the Learn More links and the corresponding page should open.
 

Comment 1 by cma...@chromium.org, Jan 25 2018

Labels: Q2

Comment 2 by cmasso@google.com, Jan 27 2018

Labels: -Q1

Comment 3 by sczs@chromium.org, Apr 11 2018

Labels: -medium small

Comment 4 by sczs@chromium.org, Jun 10 2018

NextAction: 2018-06-13
Status: Started (was: Assigned)
The NextAction date has arrived: 2018-06-13
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bca1b08bfa7819b7f468292d81c5b4f0de329ef

commit 6bca1b08bfa7819b7f468292d81c5b4f0de329ef
Author: sczs@chromium.org <sczs@chromium.org>
Date: Thu Jun 14 23:02:25 2018

[ios] Creates TableViewTextLinkItem and uses it on HistoryTableVC.

- Creates TableViewTextLinkItem, which is a text item with link support.
- Uses this item on HistoryTableVC and re-writes updateEntriesStatusMessage to reflect this.

Screenshot:
https://drive.google.com/open?id=1r6hQfWx_Yu8QC32F3hH7_TDq6ZkumHUh

Bug:  805200 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8ac8ad0329f9e0a6e38f9ef7b8f72d5bf0a1c899
Reviewed-on: https://chromium-review.googlesource.com/1094557
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567460}
[modify] https://crrev.com/6bca1b08bfa7819b7f468292d81c5b4f0de329ef/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/6bca1b08bfa7819b7f468292d81c5b4f0de329ef/ios/chrome/browser/ui/history/history_table_view_controller.mm
[modify] https://crrev.com/6bca1b08bfa7819b7f468292d81c5b4f0de329ef/ios/chrome/browser/ui/table_view/cells/BUILD.gn
[add] https://crrev.com/6bca1b08bfa7819b7f468292d81c5b4f0de329ef/ios/chrome/browser/ui/table_view/cells/table_view_text_link_item.h
[add] https://crrev.com/6bca1b08bfa7819b7f468292d81c5b4f0de329ef/ios/chrome/browser/ui/table_view/cells/table_view_text_link_item.mm

Comment 7 by sczs@chromium.org, Jun 20 2018

Status: Fixed (was: Started)

Sign in to add a comment