New issue
Advanced search Search tips

Issue 805195 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2

Blocked on:
issue 805192



Sign in to add a comment

Collections: Add the SearchBar into the TableView.

Project Member Reported by sczs@chromium.org, Jan 24 2018

Issue description

Add the SearchBar into the TableView.
This should also use the created SearchController to filter the TableView
 

Comment 1 by cma...@chromium.org, Jan 25 2018

Labels: Q2

Comment 2 by cmasso@google.com, Jan 27 2018

Labels: -Q1

Comment 3 by cmasso@google.com, Apr 5 2018

Labels: -Pri-2 Pri-1

Comment 4 by sczs@chromium.org, Apr 5 2018

Status: Started (was: Assigned)

Comment 5 by sczs@chromium.org, Apr 5 2018

Labels: -medium small
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f4b20961d9a2ae610917cbd60b43ceb5bc62832

commit 9f4b20961d9a2ae610917cbd60b43ceb5bc62832
Author: sczs <sczs@chromium.org>
Date: Thu Apr 12 04:56:43 2018

[ios] Prepares HistoryVC’s for Search implementation.

- Creates a UISearchController and adds it to the VC.
- Create a HistoryTableUpdater protocol that will be used to communicate
updates from the Container to the TableView.

Screenshots:
https://drive.google.com/open?id=1L6kaO6xZ7WGEoQXjcVGf_RJALtXrG4cM
https://drive.google.com/open?id=1uSec0DEg7ug_5vAu5uRGL6ljsWabuvZt

Bug:  805195 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icdfa7c6133bb088352bacbf02f59c65df8b4b0d7
Reviewed-on: https://chromium-review.googlesource.com/998813
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550011}
[modify] https://crrev.com/9f4b20961d9a2ae610917cbd60b43ceb5bc62832/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/9f4b20961d9a2ae610917cbd60b43ceb5bc62832/ios/chrome/browser/ui/history/history_table_container_view_controller.h
[modify] https://crrev.com/9f4b20961d9a2ae610917cbd60b43ceb5bc62832/ios/chrome/browser/ui/history/history_table_container_view_controller.mm
[add] https://crrev.com/9f4b20961d9a2ae610917cbd60b43ceb5bc62832/ios/chrome/browser/ui/history/history_table_updater_delegate.h
[modify] https://crrev.com/9f4b20961d9a2ae610917cbd60b43ceb5bc62832/ios/chrome/browser/ui/history/history_table_view_controller.h
[modify] https://crrev.com/9f4b20961d9a2ae610917cbd60b43ceb5bc62832/ios/chrome/browser/ui/history/history_table_view_controller.mm

Comment 7 by sczs@chromium.org, Apr 18 2018

NextAction: 2018-04-25
Status: Fixed (was: Started)
The NextAction date has arrived: 2018-04-25

Comment 9 by cma...@chromium.org, Apr 25 2018

NextAction: ----

Sign in to add a comment