New issue
Advanced search Search tips

Issue 805192 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-09
OS: iOS
Pri: 0
Type: Task
Q2

Blocked on:
issue 805158

Blocking:
issue 805195
issue 805198
issue 805200



Sign in to add a comment

Collections: Remove MDC classes and use new Collection classes.

Project Member Reported by sczs@chromium.org, Jan 24 2018

Issue description

Remove MDC classes and use new Collection classes.
 

Comment 1 by sczs@chromium.org, Jan 24 2018

Blocking: 805195

Comment 2 by sczs@chromium.org, Jan 24 2018

Blocking: 805198

Comment 3 by sczs@chromium.org, Jan 24 2018

Blocking: 805200

Comment 4 by cma...@chromium.org, Jan 25 2018

Labels: Q2

Comment 5 by cmasso@google.com, Jan 27 2018

Labels: -Q1

Comment 6 by sczs@chromium.org, Mar 28 2018

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/332e45d5b95e50ca6297c9bc56ffa5c243ab5002

commit 332e45d5b95e50ca6297c9bc56ffa5c243ab5002
Author: sczs <sczs@chromium.org>
Date: Wed Mar 28 04:21:16 2018

[ios] Adds Legacy prefix to History CollectionModel related classes.

Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4ec24f2f30a7b82ec2d3777796e7c796d9fb3f2c
Reviewed-on: https://chromium-review.googlesource.com/982429
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546399}
[modify] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/history_collection_view_controller_unittest.mm
[modify] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/history_entry_inserter.h
[modify] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/history_entry_inserter.mm
[modify] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm
[modify] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/history_panel_view_controller.mm
[modify] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/history_ui_egtest.mm
[rename] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/legacy_history_collection_view_controller.h
[rename] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/legacy_history_collection_view_controller.mm
[rename] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/legacy_history_entries_status_item.h
[rename] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/legacy_history_entries_status_item.mm
[rename] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/legacy_history_entries_status_item_unittest.mm
[rename] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/legacy_history_entry_item.h
[rename] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/legacy_history_entry_item.mm
[rename] https://crrev.com/332e45d5b95e50ca6297c9bc56ffa5c243ab5002/ios/chrome/browser/ui/history/legacy_history_entry_item_unittest.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ec208541e2842b09b6c7c83d58f0e4b16b47e66

commit 6ec208541e2842b09b6c7c83d58f0e4b16b47e66
Author: sczs <sczs@chromium.org>
Date: Wed Mar 28 16:33:04 2018

[ios] Moves History protocols to its own files.

These new protocols will be shared with the future TableView based files.

Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If01142817df4102cd8d2b2033a7e3b6905df23a2
Reviewed-on: https://chromium-review.googlesource.com/983058
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546517}
[modify] https://crrev.com/6ec208541e2842b09b6c7c83d58f0e4b16b47e66/ios/chrome/browser/ui/history/BUILD.gn
[add] https://crrev.com/6ec208541e2842b09b6c7c83d58f0e4b16b47e66/ios/chrome/browser/ui/history/history_entries_status_item_delegate.h
[add] https://crrev.com/6ec208541e2842b09b6c7c83d58f0e4b16b47e66/ios/chrome/browser/ui/history/history_entry_item_delegate.h
[add] https://crrev.com/6ec208541e2842b09b6c7c83d58f0e4b16b47e66/ios/chrome/browser/ui/history/history_entry_item_interface.h
[modify] https://crrev.com/6ec208541e2842b09b6c7c83d58f0e4b16b47e66/ios/chrome/browser/ui/history/legacy_history_collection_view_controller.mm
[modify] https://crrev.com/6ec208541e2842b09b6c7c83d58f0e4b16b47e66/ios/chrome/browser/ui/history/legacy_history_entries_status_item.h
[modify] https://crrev.com/6ec208541e2842b09b6c7c83d58f0e4b16b47e66/ios/chrome/browser/ui/history/legacy_history_entries_status_item.mm
[modify] https://crrev.com/6ec208541e2842b09b6c7c83d58f0e4b16b47e66/ios/chrome/browser/ui/history/legacy_history_entries_status_item_unittest.mm
[modify] https://crrev.com/6ec208541e2842b09b6c7c83d58f0e4b16b47e66/ios/chrome/browser/ui/history/legacy_history_entry_item.h
[modify] https://crrev.com/6ec208541e2842b09b6c7c83d58f0e4b16b47e66/ios/chrome/browser/ui/history/legacy_history_entry_item.mm

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c20c5ec60f7e0209f7336f3820449bef09974ae

commit 7c20c5ec60f7e0209f7336f3820449bef09974ae
Author: sczs <sczs@chromium.org>
Date: Thu Mar 29 21:30:18 2018

[ios] Changes HistoryInserter so it works with a ListModel.

HistoryInserter now used the collectionViewModel super class (ListModel) so it can work with both
CollectionItems and TableViewItems.

Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I02f170b00ca4957b834d26498084558e0f13de85
Reviewed-on: https://chromium-review.googlesource.com/985476
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546958}
[modify] https://crrev.com/7c20c5ec60f7e0209f7336f3820449bef09974ae/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/7c20c5ec60f7e0209f7336f3820449bef09974ae/ios/chrome/browser/ui/history/history_entry_inserter.h
[modify] https://crrev.com/7c20c5ec60f7e0209f7336f3820449bef09974ae/ios/chrome/browser/ui/history/history_entry_inserter.mm
[modify] https://crrev.com/7c20c5ec60f7e0209f7336f3820449bef09974ae/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e542189cc67846a700b3a52fafe92cf62a643e5

commit 0e542189cc67846a700b3a52fafe92cf62a643e5
Author: sczs <sczs@chromium.org>
Date: Fri Mar 30 01:29:50 2018

[ios] Creates History Coordinator and TableViewController

- Creates History Coordinator and TableViewController files.
- The Coordinator presents a TableViewContainer with the newly created HistoryTableVC.
- HistoryTableVC is no-op, only inherits from ChromeTableVC.

Screenshot:
https://drive.google.com/open?id=1FuHK2MaTRNCJ9HhkBZO3zGPjEiRY7Ih1

Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia090ed755e5a67097cf21b88fad0d198b405e8bf
Reviewed-on: https://chromium-review.googlesource.com/985235
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547059}
[modify] https://crrev.com/0e542189cc67846a700b3a52fafe92cf62a643e5/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/0e542189cc67846a700b3a52fafe92cf62a643e5/ios/chrome/browser/ui/history/BUILD.gn
[add] https://crrev.com/0e542189cc67846a700b3a52fafe92cf62a643e5/ios/chrome/browser/ui/history/history_coordinator.h
[add] https://crrev.com/0e542189cc67846a700b3a52fafe92cf62a643e5/ios/chrome/browser/ui/history/history_coordinator.mm
[add] https://crrev.com/0e542189cc67846a700b3a52fafe92cf62a643e5/ios/chrome/browser/ui/history/history_table_view_controller.h
[add] https://crrev.com/0e542189cc67846a700b3a52fafe92cf62a643e5/ios/chrome/browser/ui/history/history_table_view_controller.mm

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9431dd78cdccecea92415c25babad70c217d57a4

commit 9431dd78cdccecea92415c25babad70c217d57a4
Author: sczs <sczs@chromium.org>
Date: Fri Mar 30 21:03:23 2018

[ios] Creates TableView HistoryItem files.

- Creates placeholder history_entries_status_item and history_entry_item
- Creates a HistoryEntryItemComparable protocol to remove dependencies to LegacyItems.

Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id3107b1323c79dc4a0ee6f50fb02a9d2e08f7b54
Reviewed-on: https://chromium-review.googlesource.com/987322
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547271}
[modify] https://crrev.com/9431dd78cdccecea92415c25babad70c217d57a4/ios/chrome/browser/ui/history/BUILD.gn
[add] https://crrev.com/9431dd78cdccecea92415c25babad70c217d57a4/ios/chrome/browser/ui/history/history_entries_status_item.h
[add] https://crrev.com/9431dd78cdccecea92415c25babad70c217d57a4/ios/chrome/browser/ui/history/history_entries_status_item.mm
[modify] https://crrev.com/9431dd78cdccecea92415c25babad70c217d57a4/ios/chrome/browser/ui/history/history_entry_inserter.mm
[add] https://crrev.com/9431dd78cdccecea92415c25babad70c217d57a4/ios/chrome/browser/ui/history/history_entry_item.h
[add] https://crrev.com/9431dd78cdccecea92415c25babad70c217d57a4/ios/chrome/browser/ui/history/history_entry_item.mm
[modify] https://crrev.com/9431dd78cdccecea92415c25babad70c217d57a4/ios/chrome/browser/ui/history/history_entry_item_interface.h
[modify] https://crrev.com/9431dd78cdccecea92415c25babad70c217d57a4/ios/chrome/browser/ui/history/legacy_history_entry_item.mm
[modify] https://crrev.com/9431dd78cdccecea92415c25babad70c217d57a4/ios/chrome/browser/ui/history/legacy_history_entry_item_unittest.mm

Comment 13 by cmasso@google.com, Apr 5 2018

Labels: -Pri-2 Pri-0
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05ddc86fb4db1a2b8dc9c4faa02d61b99218db2f

commit 05ddc86fb4db1a2b8dc9c4faa02d61b99218db2f
Author: sczs <sczs@chromium.org>
Date: Sat Apr 14 00:58:40 2018

[ios] Adds Context Menu functionality to History TableView.

Migrates the context menu code from the legacy implementation.
All context menu actions are now usable.

Screenshot:
https://drive.google.com/open?id=1kPj23P4oIu8laXOnKt2I3dMz5HPHjJaA

Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I15d1839fc7f4b69b8df7e541d7685c5ae0352dc6
Reviewed-on: https://chromium-review.googlesource.com/1011363
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550842}
[modify] https://crrev.com/05ddc86fb4db1a2b8dc9c4faa02d61b99218db2f/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/05ddc86fb4db1a2b8dc9c4faa02d61b99218db2f/ios/chrome/browser/ui/history/history_table_view_controller.mm

Comment 15 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05ddc86fb4db1a2b8dc9c4faa02d61b99218db2f

commit 05ddc86fb4db1a2b8dc9c4faa02d61b99218db2f
Author: sczs <sczs@chromium.org>
Date: Sat Apr 14 00:58:40 2018

[ios] Adds Context Menu functionality to History TableView.

Migrates the context menu code from the legacy implementation.
All context menu actions are now usable.

Screenshot:
https://drive.google.com/open?id=1kPj23P4oIu8laXOnKt2I3dMz5HPHjJaA

Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I15d1839fc7f4b69b8df7e541d7685c5ae0352dc6
Reviewed-on: https://chromium-review.googlesource.com/1011363
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550842}
[modify] https://crrev.com/05ddc86fb4db1a2b8dc9c4faa02d61b99218db2f/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/05ddc86fb4db1a2b8dc9c4faa02d61b99218db2f/ios/chrome/browser/ui/history/history_table_view_controller.mm

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34e0bcbf00a62a92524a18f3dab494ed55ecdecf

commit 34e0bcbf00a62a92524a18f3dab494ed55ecdecf
Author: sczs <sczs@chromium.org>
Date: Thu Apr 19 23:22:14 2018

[ios] Removes TableContainerVC, Creates TableViewNavigationController

- Removes TableContainerVC, Creates TableViewNavigationController.
- Renames TableContainerConstants to TableViewNavigationControllerConstants.
- Creates HistoryLocalCommands Protocol.
- Deletes HistoryTableContainer VC.
- Deletes HistoryUpdaterDelegate and HistoryTableVCDelegate.
- Updates Eg tests with new constant name,


Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I43e27dbc58d2ad788ab6f7f16c44685dcd6a6f05
Reviewed-on: https://chromium-review.googlesource.com/1020404
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552198}
[modify] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/history/history_coordinator.mm
[add] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/history/history_local_commands.h
[delete] https://crrev.com/8f8e8f12f20093a16135f29b25621baa778947a4/ios/chrome/browser/ui/history/history_table_container_view_controller.h
[delete] https://crrev.com/8f8e8f12f20093a16135f29b25621baa778947a4/ios/chrome/browser/ui/history/history_table_container_view_controller.mm
[delete] https://crrev.com/8f8e8f12f20093a16135f29b25621baa778947a4/ios/chrome/browser/ui/history/history_table_updater_delegate.h
[modify] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/history/history_table_view_controller.h
[modify] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/history/history_table_view_controller.mm
[delete] https://crrev.com/8f8e8f12f20093a16135f29b25621baa778947a4/ios/chrome/browser/ui/history/history_table_view_controller_delegate.h
[modify] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/keyboard_commands_egtest.mm
[modify] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_egtest.mm
[modify] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
[modify] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/table_view/BUILD.gn
[delete] https://crrev.com/8f8e8f12f20093a16135f29b25621baa778947a4/ios/chrome/browser/ui/table_view/table_container_constants.h
[delete] https://crrev.com/8f8e8f12f20093a16135f29b25621baa778947a4/ios/chrome/browser/ui/table_view/table_container_constants.mm
[rename] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/table_view/table_view_navigation_controller.h
[rename] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/table_view/table_view_navigation_controller.mm
[add] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/table_view/table_view_navigation_controller_constants.h
[add] https://crrev.com/34e0bcbf00a62a92524a18f3dab494ed55ecdecf/ios/chrome/browser/ui/table_view/table_view_navigation_controller_constants.mm

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2df255a45b17ae6554812b79380f34dfb387297c

commit 2df255a45b17ae6554812b79380f34dfb387297c
Author: sczs <sczs@chromium.org>
Date: Mon Apr 23 23:58:14 2018

[ios] Adds History NavController Toolbar Buttons.

- Adds functionality for Edit, Cancel.
- This CL doesn't add Delete or show CBD functionality.

Screenshots:
https://drive.google.com/open?id=1Vemnn74-tx8vyyiVQ9JgwiqwkIMYF4Mo
https://drive.google.com/open?id=1KClaorF_W3QDOhBgjn8Ij9ozme01VUnJ

Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idfbb8baf15887de377a66c5be70d484f21b41324
Reviewed-on: https://chromium-review.googlesource.com/1018494
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552910}
[modify] https://crrev.com/2df255a45b17ae6554812b79380f34dfb387297c/ios/chrome/browser/ui/history/history_table_view_controller.mm

Project Member

Comment 19 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f734b57d097c03681bccdad122786d32bd5e214d

commit f734b57d097c03681bccdad122786d32bd5e214d
Author: sczs <sczs@chromium.org>
Date: Tue Apr 24 02:51:56 2018

[ios] Adds search functionality to History.

- Makes the VC conform to UISearchResultsUpdating and UISearchBarDelegate.
- Migrates the filter and delete logic from the LegacyHistory implementation.
- Removes isSearching property since we can directly ask the SearchController.

Screenshots:
https://drive.google.com/open?id=1fYgO7PiJ0tKZgAKXAnt2vzW7Exlcz0En
https://drive.google.com/open?id=160AsFrm8Z71JUc5ADpvIsaT4YKYVigNd

Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I74f0465ee3aff13a4cbe3d72277e10c6d1f87b19
Reviewed-on: https://chromium-review.googlesource.com/1022529
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552980}
[modify] https://crrev.com/f734b57d097c03681bccdad122786d32bd5e214d/ios/chrome/browser/ui/history/history_table_view_controller.mm

Project Member

Comment 20 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96593dc8d3b0bffbe4c5b33c96ef92c025b498aa

commit 96593dc8d3b0bffbe4c5b33c96ef92c025b498aa
Author: sczs <sczs@chromium.org>
Date: Wed Apr 25 16:00:55 2018

[ios] Adds delete functionality to HistoryTableVC.

- Migrates deleteSelectedItemsFromHistory from the legacyImplementation.
- Deletes some related unused methods.

Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I513672f7abf9b8474fa600571ad275a70ac1f770
Reviewed-on: https://chromium-review.googlesource.com/1026565
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553583}
[modify] https://crrev.com/96593dc8d3b0bffbe4c5b33c96ef92c025b498aa/ios/chrome/browser/ui/history/history_table_view_controller.mm

Project Member

Comment 21 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5af3e2a429dee1560f8f37c5c47b5b2be8794d71

commit 5af3e2a429dee1560f8f37c5c47b5b2be8794d71
Author: sczs <sczs@chromium.org>
Date: Wed Apr 25 17:12:39 2018

[ios] Presents CBD modally from HistoryCoordinator.

-This CL re-introduces the ClearBrowsingData modal presentation from HistoryCoordinator
via HistoryTableVC.

-Creates a new displayPrivacySettings localDispatcher command.

Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia62f7f491b39e49c7d90bffb8bf42504ff343a13
Reviewed-on: https://chromium-review.googlesource.com/1026873
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553611}
[modify] https://crrev.com/5af3e2a429dee1560f8f37c5c47b5b2be8794d71/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/5af3e2a429dee1560f8f37c5c47b5b2be8794d71/ios/chrome/browser/ui/history/history_coordinator.mm
[modify] https://crrev.com/5af3e2a429dee1560f8f37c5c47b5b2be8794d71/ios/chrome/browser/ui/history/history_local_commands.h
[modify] https://crrev.com/5af3e2a429dee1560f8f37c5c47b5b2be8794d71/ios/chrome/browser/ui/history/history_table_view_controller.mm

Comment 22 by sczs@chromium.org, Apr 26 2018

NextAction: 2018-05-09
Project Member

Comment 23 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18a6b6bc985d5e5a28fe120454f4790597909eaf

commit 18a6b6bc985d5e5a28fe120454f4790597909eaf
Author: sczs <sczs@chromium.org>
Date: Thu Apr 26 21:47:50 2018

[ios] Moves HistoryTableView behind main UIRefresh flag

- Updates HistoryEgTests to support the new UI.
- Moves new History implementation behind main UIRefresh flag.

Bug:  805192 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I788fb54902c1e48cae2008133a4e057768300067
Reviewed-on: https://chromium-review.googlesource.com/1029454
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554153}
[modify] https://crrev.com/18a6b6bc985d5e5a28fe120454f4790597909eaf/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/18a6b6bc985d5e5a28fe120454f4790597909eaf/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/18a6b6bc985d5e5a28fe120454f4790597909eaf/ios/chrome/browser/ui/history/history_entry_inserter.mm
[modify] https://crrev.com/18a6b6bc985d5e5a28fe120454f4790597909eaf/ios/chrome/browser/ui/history/history_table_view_controller.mm
[modify] https://crrev.com/18a6b6bc985d5e5a28fe120454f4790597909eaf/ios/chrome/browser/ui/history/history_ui_egtest.mm
[modify] https://crrev.com/18a6b6bc985d5e5a28fe120454f4790597909eaf/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_egtest.mm

Comment 24 by sczs@chromium.org, May 1 2018

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-05-09

Sign in to add a comment