Migrate the history model so it works with a TableView instead of a CollectionView.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dc9839b21b05f81ad80d5771691f935ac85fc07 commit 4dc9839b21b05f81ad80d5771691f935ac85fc07 Author: sczs <sczs@chromium.org> Date: Wed Apr 04 01:02:25 2018 [ios] Creates and uses HistoryConsumer protocol. - Moves out the HistoryService and Driver creation from HistoryCollectionVC to HistoryPanelVC. Because of this HistoryCollectionVC will have less model responsibilities. On the new implementation this responsibilities will be owned by a Coordinator instead of a parent VC like HistoryPanel. Bug: 805190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I749be91308ed35eb8d08a2a9f6c4bf984eb8bb79 Reviewed-on: https://chromium-review.googlesource.com/991253 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547908} [modify] https://crrev.com/4dc9839b21b05f81ad80d5771691f935ac85fc07/ios/chrome/browser/ui/history/BUILD.gn [modify] https://crrev.com/4dc9839b21b05f81ad80d5771691f935ac85fc07/ios/chrome/browser/ui/history/history_collection_view_controller_unittest.mm [add] https://crrev.com/4dc9839b21b05f81ad80d5771691f935ac85fc07/ios/chrome/browser/ui/history/history_consumer.h [modify] https://crrev.com/4dc9839b21b05f81ad80d5771691f935ac85fc07/ios/chrome/browser/ui/history/history_panel_view_controller.mm [modify] https://crrev.com/4dc9839b21b05f81ad80d5771691f935ac85fc07/ios/chrome/browser/ui/history/ios_browsing_history_driver.h [modify] https://crrev.com/4dc9839b21b05f81ad80d5771691f935ac85fc07/ios/chrome/browser/ui/history/ios_browsing_history_driver.mm [modify] https://crrev.com/4dc9839b21b05f81ad80d5771691f935ac85fc07/ios/chrome/browser/ui/history/legacy_history_collection_view_controller.h [modify] https://crrev.com/4dc9839b21b05f81ad80d5771691f935ac85fc07/ios/chrome/browser/ui/history/legacy_history_collection_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94bad661801996f841c6f38e771ac9d8f850ff20 commit 94bad661801996f841c6f38e771ac9d8f850ff20 Author: sczs <sczs@chromium.org> Date: Wed Apr 04 03:21:19 2018 [ios] Creates history services on HistoryCoordinator. - Implements the changes from crrev/c/991253 to the new HistoryCoordinator. Bug: 805190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5b7f47e1f5a706fb15e6833a4c0c01efe8f1ff96 Reviewed-on: https://chromium-review.googlesource.com/994131 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#547965} [modify] https://crrev.com/94bad661801996f841c6f38e771ac9d8f850ff20/ios/chrome/browser/ui/history/history_coordinator.mm [modify] https://crrev.com/94bad661801996f841c6f38e771ac9d8f850ff20/ios/chrome/browser/ui/history/history_table_view_controller.h [modify] https://crrev.com/94bad661801996f841c6f38e771ac9d8f850ff20/ios/chrome/browser/ui/history/history_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39c48373757661fc18fa8bf8f61d684a1e9db6d8 commit 39c48373757661fc18fa8bf8f61d684a1e9db6d8 Author: sczs <sczs@chromium.org> Date: Wed Apr 11 17:45:40 2018 [ios] Displays History on HistoryTableViewController. - Migrates the basic business logic from LegacyHistoryViewController. All the logic has been copied and modified slightly in order to work with a TableView. - Displays History entires, and supports fetching entries while scrolling (fetches 100 entries per query). - Moves TitleFormat from LegacyHistoryItem to history_util. - It currently doesn't show anything on the first StatusSection, but the code was still left there since removing it and adding later could introduce errors. - Moves HistoryInserter and HistoryUtils to the history_ui target. Screenshot: https://drive.google.com/open?id=1IvYBq59ykSj46aGn-YGBUTmYNGZcWEmm Bug: 805190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5eb5d8160182b49e254c4e91704ed4c5db98aa43 Reviewed-on: https://chromium-review.googlesource.com/997108 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#549922} [modify] https://crrev.com/39c48373757661fc18fa8bf8f61d684a1e9db6d8/ios/chrome/browser/ui/history/BUILD.gn [modify] https://crrev.com/39c48373757661fc18fa8bf8f61d684a1e9db6d8/ios/chrome/browser/ui/history/history_entry_item.mm [modify] https://crrev.com/39c48373757661fc18fa8bf8f61d684a1e9db6d8/ios/chrome/browser/ui/history/history_table_view_controller.h [modify] https://crrev.com/39c48373757661fc18fa8bf8f61d684a1e9db6d8/ios/chrome/browser/ui/history/history_table_view_controller.mm [modify] https://crrev.com/39c48373757661fc18fa8bf8f61d684a1e9db6d8/ios/chrome/browser/ui/history/history_util.h [modify] https://crrev.com/39c48373757661fc18fa8bf8f61d684a1e9db6d8/ios/chrome/browser/ui/history/history_util.mm [modify] https://crrev.com/39c48373757661fc18fa8bf8f61d684a1e9db6d8/ios/chrome/browser/ui/history/legacy_history_entry_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67bb0ae15de1630d611e49e0489639b8d47c5291 commit 67bb0ae15de1630d611e49e0489639b8d47c5291 Author: sczs <sczs@chromium.org> Date: Thu Apr 12 20:34:53 2018 [ios] Adds navigation to a HistoryTableView entry. - Navigates to a History entry when tapped by migrating the Legacy logic into the TableVC. - Cleans up the old implementation of HistoryTableViewControllerDelegate and moves it to its own file. - Some small cleanup and adds ContextMenu methods comments. Bug: 805190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icf059e1ec9ec557ed8ea4e22eb46a813c1abe53a Reviewed-on: https://chromium-review.googlesource.com/999262 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550338} [modify] https://crrev.com/67bb0ae15de1630d611e49e0489639b8d47c5291/ios/chrome/browser/ui/history/BUILD.gn [modify] https://crrev.com/67bb0ae15de1630d611e49e0489639b8d47c5291/ios/chrome/browser/ui/history/history_coordinator.mm [modify] https://crrev.com/67bb0ae15de1630d611e49e0489639b8d47c5291/ios/chrome/browser/ui/history/history_table_container_view_controller.h [modify] https://crrev.com/67bb0ae15de1630d611e49e0489639b8d47c5291/ios/chrome/browser/ui/history/history_table_container_view_controller.mm [modify] https://crrev.com/67bb0ae15de1630d611e49e0489639b8d47c5291/ios/chrome/browser/ui/history/history_table_view_controller.h [modify] https://crrev.com/67bb0ae15de1630d611e49e0489639b8d47c5291/ios/chrome/browser/ui/history/history_table_view_controller.mm [add] https://crrev.com/67bb0ae15de1630d611e49e0489639b8d47c5291/ios/chrome/browser/ui/history/history_table_view_controller_delegate.h
Pretty much done, we only need to migrate the status messages which is now WIP
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea440a235abfb1a15b45730c42d0bbe45d93ba5e commit ea440a235abfb1a15b45730c42d0bbe45d93ba5e Author: sczs <sczs@chromium.org> Date: Mon Apr 23 18:19:39 2018 [ios] Adds support for HistoryStatusMessage Inserts the top History message using a TableViewTextItem. The UI will be updated on a followup CL. Bug: 805190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I56ef6eece234eb1be50df0949f1400532a961ac6 Reviewed-on: https://chromium-review.googlesource.com/1018014 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#552754} [modify] https://crrev.com/ea440a235abfb1a15b45730c42d0bbe45d93ba5e/ios/chrome/browser/ui/history/history_table_view_controller.mm
The NextAction date has arrived: 2018-04-25
Comment 1 by sczs@chromium.org
, Jan 24 2018