Some logic might be needed on the VC.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/add11c4c0f952690a953202c709a06f3cc11784c commit add11c4c0f952690a953202c709a06f3cc11784c Author: sczs <sczs@chromium.org> Date: Wed Jun 27 19:41:47 2018 [ios] Creates SigninPromoView UIRefresh styling. - Updates SigninPromoView to support a new UI Layout based on UIRefresh Phase 1 flag and a new flag received on init. - Some minor refactoring to stop calling self on init in SigninPromoView. Screenshots: https://drive.google.com/open?id=1FnR436FEX9_3GwFbIIrJsQ8qHZOdqJpl https://drive.google.com/open?id=1__aPHb1ye3WkiHKHJp9kIyJ6hhABq1Y6 https://drive.google.com/open?id=1ibjz3nnXHBrO_akJm4e9tgghpD85f3u0 https://drive.google.com/open?id=1dCVkiMW1IMQjWkxcegVxi8r1PLh5ZCqM Bug: 805188 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1268388da06c57eb9c1610c3547314929bb8c107 Reviewed-on: https://chromium-review.googlesource.com/1107216 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570864} [modify] https://crrev.com/add11c4c0f952690a953202c709a06f3cc11784c/ios/chrome/browser/ui/authentication/BUILD.gn [modify] https://crrev.com/add11c4c0f952690a953202c709a06f3cc11784c/ios/chrome/browser/ui/authentication/signin_promo_item.mm [modify] https://crrev.com/add11c4c0f952690a953202c709a06f3cc11784c/ios/chrome/browser/ui/authentication/signin_promo_view.h [modify] https://crrev.com/add11c4c0f952690a953202c709a06f3cc11784c/ios/chrome/browser/ui/authentication/signin_promo_view.mm [modify] https://crrev.com/add11c4c0f952690a953202c709a06f3cc11784c/ios/chrome/browser/ui/authentication/signin_promo_view_unittest.mm [modify] https://crrev.com/add11c4c0f952690a953202c709a06f3cc11784c/ios/chrome/browser/ui/bookmarks/cells/bookmark_home_promo_item.mm [modify] https://crrev.com/add11c4c0f952690a953202c709a06f3cc11784c/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_signin_promo_cell.mm [modify] https://crrev.com/add11c4c0f952690a953202c709a06f3cc11784c/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller.mm [modify] https://crrev.com/add11c4c0f952690a953202c709a06f3cc11784c/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm [modify] https://crrev.com/add11c4c0f952690a953202c709a06f3cc11784c/ios/chrome/browser/ui/table_view/cells/table_view_signin_promo_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a61b90cb0b8fd3ac69a97bc642fa1e2179bac44 commit 8a61b90cb0b8fd3ac69a97bc642fa1e2179bac44 Author: Rohit Rao <rohitrao@chromium.org> Date: Thu Jun 28 09:46:17 2018 Revert "[ios] Creates SigninPromoView UIRefresh styling." This reverts commit add11c4c0f952690a953202c709a06f3cc11784c. Reason for revert: Breaks egtests when UIRefresh is disabled. Test Case '-[RecentTabsTableTestCase testRecentTabSigninPromoReloaded]' started. ../../ios/chrome/browser/ui/authentication/signin_earlgrey_utils.mm:39: error: -[RecentTabsTableTestCase testRecentTabSigninPromoReloaded] : Exception: NoMatchingElementException Exception Name: NoMatchingElementException Exception Reason: Cannot find UI Element. Exception with Assertion: { "Assertion Criteria": "assertWithMatcher:isNotNil", "Element Matcher": "((respondsToSelector(accessibilityIdentifier) && accessibilityID('kSigninPromoPrimaryButtonId')) && matcherForSufficientlyVisible(>=0.750000))", "Recovery Suggestion": "Check if the element exists in the UI hierarchy printed below. If it exists, adjust the matcher so that it accurately matches element." } Exception Details: Error Trace: [ { "Description": "Interaction cannot continue because the desired element was not found.", "Error Domain": "com.google.earlgrey.ElementInteractionErrorDomain", "Error Code": "0", "File Name": "GREYElementInteraction.m", "Function Name": "-[GREYElementInteraction matchedElementsWithTimeout:error:]", "Line": "124", "TestCase Class": "RecentTabsTableTestCase", "TestCase Method": "testRecentTabSigninPromoReloaded" } ] Original change's description: > [ios] Creates SigninPromoView UIRefresh styling. > > - Updates SigninPromoView to support a new UI Layout based on UIRefresh Phase 1 flag and a new > flag received on init. > - Some minor refactoring to stop calling self on init in SigninPromoView. > > Screenshots: > https://drive.google.com/open?id=1FnR436FEX9_3GwFbIIrJsQ8qHZOdqJpl > https://drive.google.com/open?id=1__aPHb1ye3WkiHKHJp9kIyJ6hhABq1Y6 > https://drive.google.com/open?id=1ibjz3nnXHBrO_akJm4e9tgghpD85f3u0 > https://drive.google.com/open?id=1dCVkiMW1IMQjWkxcegVxi8r1PLh5ZCqM > > Bug: 805188 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I1268388da06c57eb9c1610c3547314929bb8c107 > Reviewed-on: https://chromium-review.googlesource.com/1107216 > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570864} TBR=rohitrao@chromium.org,jlebel@chromium.org,edchin@chromium.org,sczs@chromium.org Change-Id: I2bf65f4e8848786eb3d60c2db4adb768eed3692b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805188 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1118178 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#571058} [modify] https://crrev.com/8a61b90cb0b8fd3ac69a97bc642fa1e2179bac44/ios/chrome/browser/ui/authentication/BUILD.gn [modify] https://crrev.com/8a61b90cb0b8fd3ac69a97bc642fa1e2179bac44/ios/chrome/browser/ui/authentication/signin_promo_item.mm [modify] https://crrev.com/8a61b90cb0b8fd3ac69a97bc642fa1e2179bac44/ios/chrome/browser/ui/authentication/signin_promo_view.h [modify] https://crrev.com/8a61b90cb0b8fd3ac69a97bc642fa1e2179bac44/ios/chrome/browser/ui/authentication/signin_promo_view.mm [modify] https://crrev.com/8a61b90cb0b8fd3ac69a97bc642fa1e2179bac44/ios/chrome/browser/ui/authentication/signin_promo_view_unittest.mm [modify] https://crrev.com/8a61b90cb0b8fd3ac69a97bc642fa1e2179bac44/ios/chrome/browser/ui/bookmarks/cells/bookmark_home_promo_item.mm [modify] https://crrev.com/8a61b90cb0b8fd3ac69a97bc642fa1e2179bac44/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_signin_promo_cell.mm [modify] https://crrev.com/8a61b90cb0b8fd3ac69a97bc642fa1e2179bac44/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller.mm [modify] https://crrev.com/8a61b90cb0b8fd3ac69a97bc642fa1e2179bac44/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm [modify] https://crrev.com/8a61b90cb0b8fd3ac69a97bc642fa1e2179bac44/ios/chrome/browser/ui/table_view/cells/table_view_signin_promo_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a40acd3982c39f366e97909f8956bf67d8a845b9 commit a40acd3982c39f366e97909f8956bf67d8a845b9 Author: sczs <sczs@chromium.org> Date: Mon Jul 02 16:42:51 2018 [ios] RELAND Creates SigninPromoView UIRefresh styling. ==== Original CL: crrev.com/c/1107216 - Updates SigninPromoView to support a new UI Layout based on UIRefresh Phase 1 flag and a new flag received on init. Screenshots: https://drive.google.com/open?id=1FnR436FEX9_3GwFbIIrJsQ8qHZOdqJpl https://drive.google.com/open?id=1__aPHb1ye3WkiHKHJp9kIyJ6hhABq1Y6 https://drive.google.com/open?id=1ibjz3nnXHBrO_akJm4e9tgghpD85f3u0 https://drive.google.com/open?id=1dCVkiMW1IMQjWkxcegVxi8r1PLh5ZCqM ==== Updates: There were some issues when moving the UI setup from self, which I had tried to fix on the original CL. I've now moved the UI setup to self, this means that some call to self will remain. Bug: 805188 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4eab7b1b4388e1e4f41b0b9861ef44057d99aab7 Reviewed-on: https://chromium-review.googlesource.com/1118912 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#571922} [modify] https://crrev.com/a40acd3982c39f366e97909f8956bf67d8a845b9/ios/chrome/browser/ui/authentication/BUILD.gn [modify] https://crrev.com/a40acd3982c39f366e97909f8956bf67d8a845b9/ios/chrome/browser/ui/authentication/signin_promo_item.mm [modify] https://crrev.com/a40acd3982c39f366e97909f8956bf67d8a845b9/ios/chrome/browser/ui/authentication/signin_promo_view.h [modify] https://crrev.com/a40acd3982c39f366e97909f8956bf67d8a845b9/ios/chrome/browser/ui/authentication/signin_promo_view.mm [modify] https://crrev.com/a40acd3982c39f366e97909f8956bf67d8a845b9/ios/chrome/browser/ui/authentication/signin_promo_view_unittest.mm [modify] https://crrev.com/a40acd3982c39f366e97909f8956bf67d8a845b9/ios/chrome/browser/ui/bookmarks/cells/bookmark_home_promo_item.mm [modify] https://crrev.com/a40acd3982c39f366e97909f8956bf67d8a845b9/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_signin_promo_cell.mm [modify] https://crrev.com/a40acd3982c39f366e97909f8956bf67d8a845b9/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller.mm [modify] https://crrev.com/a40acd3982c39f366e97909f8956bf67d8a845b9/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm [modify] https://crrev.com/a40acd3982c39f366e97909f8956bf67d8a845b9/ios/chrome/browser/ui/table_view/cells/table_view_signin_promo_item.mm
New Sign in promo is looking good as per the screenshots given. Verified on M69.0.3480.0 canary iOS: 11.4, 12, 10.3.3 Device: iPad Pro, iPhoneX, iPhone5S
The NextAction date has arrived: 2018-07-04
Comment 1 by sczs@chromium.org
, Jan 24 2018