Bookmarks: Use Bubble presentation for the editor screens |
||||||||||
Issue descriptionChange modal presentation of details to Navigation segue
,
Jan 25 2018
,
Jan 26 2018
,
Apr 9 2018
,
May 9 2018
This bug is for pushing the Edit VCs onto the existing navigation stack, rather than presenting them as new top-level VCs.
,
May 9 2018
,
Jun 1 2018
Per UX, we are now going to use a separate presentation for the "Edit" screens, rather than pushing them onto the existing stack. We'd like to use the same bubble presentation, but have the view animate in from the bottom of the screen rather than from the trailing edge.
,
Jun 6 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/230c7c096a6f1fe6daa2aa4ef68a739522a55deb commit 230c7c096a6f1fe6daa2aa4ef68a739522a55deb Author: Rohit Rao <rohitrao@chromium.org> Date: Wed Jun 06 15:36:53 2018 [ios] Uses BookmarkInteractionController to present bookmark editor VCs. The interaction controller is functionally acting as a coordinator, so BookmarkHomeViewController now uses it to present editor view controllers. BookmarkInteractionController supplies APIs to present an editor for a given BookmarkNode and abstracts away the actual presentation and specific view controller subclasses used. BUG= 805182 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie7c7200766439d0acd161a1c94d20249a17d861e Reviewed-on: https://chromium-review.googlesource.com/1081013 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#564901} [modify] https://crrev.com/230c7c096a6f1fe6daa2aa4ef68a739522a55deb/ios/chrome/browser/ui/bookmarks/BUILD.gn [modify] https://crrev.com/230c7c096a6f1fe6daa2aa4ef68a739522a55deb/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm [modify] https://crrev.com/230c7c096a6f1fe6daa2aa4ef68a739522a55deb/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.h [modify] https://crrev.com/230c7c096a6f1fe6daa2aa4ef68a739522a55deb/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm [add] https://crrev.com/230c7c096a6f1fe6daa2aa4ef68a739522a55deb/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller_delegate.h [modify] https://crrev.com/230c7c096a6f1fe6daa2aa4ef68a739522a55deb/ios/chrome/browser/ui/browser_view_controller.mm
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3746a476b3459beee3468461bbf3c1922b75a975 commit 3746a476b3459beee3468461bbf3c1922b75a975 Author: Rohit Rao <rohitrao@chromium.org> Date: Wed Jun 13 21:56:01 2018 [ios] Uses a bubble presentation for the bookmarks editors. BUG= 805182 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I56014e0e6db3a8b1439d6306dee0041a3916eb31 Reviewed-on: https://chromium-review.googlesource.com/1086275 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567007} [modify] https://crrev.com/3746a476b3459beee3468461bbf3c1922b75a975/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm [modify] https://crrev.com/3746a476b3459beee3468461bbf3c1922b75a975/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm [modify] https://crrev.com/3746a476b3459beee3468461bbf3c1922b75a975/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm [modify] https://crrev.com/3746a476b3459beee3468461bbf3c1922b75a975/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm [modify] https://crrev.com/3746a476b3459beee3468461bbf3c1922b75a975/ios/chrome/browser/ui/bookmarks/bookmark_transitioning_delegate.h [modify] https://crrev.com/3746a476b3459beee3468461bbf3c1922b75a975/ios/chrome/browser/ui/bookmarks/bookmark_transitioning_delegate.mm [modify] https://crrev.com/3746a476b3459beee3468461bbf3c1922b75a975/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
,
Jun 15 2018
,
Jun 20 2018
The NextAction date has arrived: 2018-06-20
,
Jun 20 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by sczs@chromium.org
, Jan 24 2018