New issue
Advanced search Search tips

Issue 805178 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 0
Type: Task
Q2

Blocked on:
issue 805013

Blocking:
issue 805700



Sign in to add a comment

Collections: Create generic ToolbarBar

Project Member Reported by sczs@chromium.org, Jan 23 2018

Issue description

We might need to implement this bug/story alongside the Recent Tabs ones so we can make sure the toolbar can be properly hidden on Recent Tabs.
 

Comment 1 by sczs@chromium.org, Jan 24 2018

Blocking: 805700

Comment 2 by cmasso@google.com, Jan 26 2018

Labels: -Q1 Q2

Comment 3 by sczs@chromium.org, Mar 29 2018

Labels: -MS-Bookmarks -S-Bookmarks-Toolbar MS-History S-History-Toolbar
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6703dfbbb12929dc03ce2b2865501f08b1a11ff2

commit 6703dfbbb12929dc03ce2b2865501f08b1a11ff2
Author: sczs <sczs@chromium.org>
Date: Fri Mar 30 16:23:15 2018

[ios] Creates TableContainerBottomToolbar UIView.

Creates a simple 2 button Toolbar to be used at the bottom of the TableViewContainer

Screenshot:
https://drive.google.com/open?id=18l37bkXk5-k2_0l6Cnlymb_OCBmjD0OI

Bug:  805178 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0927804eaa217203b859eb0a547833dc01b76394
Reviewed-on: https://chromium-review.googlesource.com/986285
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547177}
[modify] https://crrev.com/6703dfbbb12929dc03ce2b2865501f08b1a11ff2/ios/chrome/browser/ui/table_view/BUILD.gn
[add] https://crrev.com/6703dfbbb12929dc03ce2b2865501f08b1a11ff2/ios/chrome/browser/ui/table_view/table_container_bottom_toolbar.h
[add] https://crrev.com/6703dfbbb12929dc03ce2b2865501f08b1a11ff2/ios/chrome/browser/ui/table_view/table_container_bottom_toolbar.mm
[add] https://crrev.com/6703dfbbb12929dc03ce2b2865501f08b1a11ff2/ios/chrome/browser/ui/table_view/table_container_bottom_toolbar_unittest.mm
[modify] https://crrev.com/6703dfbbb12929dc03ce2b2865501f08b1a11ff2/ios/chrome/browser/ui/table_view/table_container_view_controller.mm
[modify] https://crrev.com/6703dfbbb12929dc03ce2b2865501f08b1a11ff2/ios/showcase/table_view/sc_table_container_coordinator.mm

Comment 5 by cmasso@google.com, Apr 5 2018

Labels: -Pri-2 Pri-0

Comment 6 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags

Comment 7 by sczs@chromium.org, Apr 18 2018

NextAction: 2018-04-25
Status: Fixed (was: Started)
We will go with a UIToolbar now
The NextAction date has arrived: 2018-04-25

Comment 9 by cma...@chromium.org, Apr 25 2018

NextAction: ----

Sign in to add a comment