New issue
Advanced search Search tips

Issue 805166 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 0
Type: Task
Q2


Sign in to add a comment

Collections: User can see their list of Bookmarks

Project Member Reported by sczs@chromium.org, Jan 23 2018

Issue description

Remove Old classes and use new Collection classes. We should use the base classes created on recent Tabs.

Edit: Bookmarks is not actually using MDC, but we needs to use the newly created base class.
 

Comment 1 by sczs@chromium.org, Jan 23 2018

Blocking: 805182

Comment 2 by sczs@chromium.org, Jan 23 2018

Blocking: 805185

Comment 3 by sczs@chromium.org, Jan 24 2018

Description: Show this description

Comment 4 by cmasso@google.com, Jan 26 2018

Labels: -Q1 Q2

Comment 5 by cmasso@google.com, Apr 5 2018

Labels: Pri-0
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by cmasso@google.com, Apr 9 2018

Owner: rohitrao@chromium.org

Comment 8 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
Labels: -large
Summary: Collections: User can see their list of Bookmarks (was: Collections: Remove MDC classes and use new Collection classes.)
Converting this into an umbrella bug for updating the main bookmarks screen.
Blockedon: 839423
Blockedon: 839427
Blockedon: 839428
Blockedon: 839432
Blockedon: 839435
Blockedon: 839439
Blockedon: 839442
Blocking: -805185
Blockedon: 840381
Blockedon: 843108
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/172c872da9750180700e65f9a5e439ab1435e38e

commit 172c872da9750180700e65f9a5e439ab1435e38e
Author: Rohit Rao <rohitrao@chromium.org>
Date: Fri Jun 01 03:07:11 2018

[ios] Adds support for modal table view presentations.

Adds a new TableViewModalPresenting protocol that is implemented by the
TableViewPresentationController and contains methods to set the modal
presentation mode.  The TableViewNavigationControllerDelegate calls
methods on this protocol whenever a new view controller is pushed onto
the navigation stack.

Also adds a TableViewPresentationControllerDelegate protocol, which
allows the presentation controller to pull the same bits of information.

BUG= 805166 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9cc36c1b1bf6782ca97ff84fbd4a34a961e2ca69
Reviewed-on: https://chromium-review.googlesource.com/1072319
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563509}
[modify] https://crrev.com/172c872da9750180700e65f9a5e439ab1435e38e/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
[modify] https://crrev.com/172c872da9750180700e65f9a5e439ab1435e38e/ios/chrome/browser/ui/table_view/BUILD.gn
[modify] https://crrev.com/172c872da9750180700e65f9a5e439ab1435e38e/ios/chrome/browser/ui/table_view/chrome_table_view_controller.h
[modify] https://crrev.com/172c872da9750180700e65f9a5e439ab1435e38e/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm
[add] https://crrev.com/172c872da9750180700e65f9a5e439ab1435e38e/ios/chrome/browser/ui/table_view/table_view_modal_presenting.h
[modify] https://crrev.com/172c872da9750180700e65f9a5e439ab1435e38e/ios/chrome/browser/ui/table_view/table_view_navigation_controller.mm
[add] https://crrev.com/172c872da9750180700e65f9a5e439ab1435e38e/ios/chrome/browser/ui/table_view/table_view_navigation_controller_delegate.h
[add] https://crrev.com/172c872da9750180700e65f9a5e439ab1435e38e/ios/chrome/browser/ui/table_view/table_view_navigation_controller_delegate.mm
[modify] https://crrev.com/172c872da9750180700e65f9a5e439ab1435e38e/ios/chrome/browser/ui/table_view/table_view_presentation_controller.h
[modify] https://crrev.com/172c872da9750180700e65f9a5e439ab1435e38e/ios/chrome/browser/ui/table_view/table_view_presentation_controller.mm
[add] https://crrev.com/172c872da9750180700e65f9a5e439ab1435e38e/ios/chrome/browser/ui/table_view/table_view_presentation_controller_delegate.h

Comment 21 by sczs@chromium.org, Jun 13 2018

Status: Fixed (was: Assigned)
All blocked on bugs have been completed. Marking as fixed
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8d90d85252e98e60d780ba8a2d4016b2bdcbc70

commit d8d90d85252e98e60d780ba8a2d4016b2bdcbc70
Author: Rohit Rao <rohitrao@chromium.org>
Date: Fri Jun 15 02:34:18 2018

[ios] Converts BookmarkEmptyBackground to use a UIStackView.

Adds a new image and view spacing when the UIRefresh experiment is
enabled. Adds Dynamic Type support as well.

Legacy: https://drive.google.com/file/d/1UIIDcwMcpcG-N7-AKox94UtQErhiy1ip/view
Refresh: https://drive.google.com/file/d/1hrP-Cgrm1jdaK0K6BM-P-ytMMxBplwlX/view

BUG= 805166 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9b4ba4aac10b0b91ff38b127bf978db4ee93639d
Reviewed-on: https://chromium-review.googlesource.com/1099415
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567521}
[modify] https://crrev.com/d8d90d85252e98e60d780ba8a2d4016b2bdcbc70/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/d8d90d85252e98e60d780ba8a2d4016b2bdcbc70/ios/chrome/browser/ui/bookmarks/bookmark_empty_background.mm
[modify] https://crrev.com/d8d90d85252e98e60d780ba8a2d4016b2bdcbc70/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.h
[modify] https://crrev.com/d8d90d85252e98e60d780ba8a2d4016b2bdcbc70/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.mm
[modify] https://crrev.com/d8d90d85252e98e60d780ba8a2d4016b2bdcbc70/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
[modify] https://crrev.com/d8d90d85252e98e60d780ba8a2d4016b2bdcbc70/ios/chrome/browser/ui/bookmarks/resources/BUILD.gn
[add] https://crrev.com/d8d90d85252e98e60d780ba8a2d4016b2bdcbc70/ios/chrome/browser/ui/bookmarks/resources/bookmark_empty_star.imageset/Contents.json
[add] https://crrev.com/d8d90d85252e98e60d780ba8a2d4016b2bdcbc70/ios/chrome/browser/ui/bookmarks/resources/bookmark_empty_star.imageset/bookmark_empty_star.png
[add] https://crrev.com/d8d90d85252e98e60d780ba8a2d4016b2bdcbc70/ios/chrome/browser/ui/bookmarks/resources/bookmark_empty_star.imageset/bookmark_empty_star@2x.png
[add] https://crrev.com/d8d90d85252e98e60d780ba8a2d4016b2bdcbc70/ios/chrome/browser/ui/bookmarks/resources/bookmark_empty_star.imageset/bookmark_empty_star@3x.png

Sign in to add a comment