Collections: Create Contextual Promo Cell with new design |
||||||
Issue descriptionSome logic on the VC may be needed for this.
,
Jan 29 2018
,
Mar 6 2018
,
Mar 6 2018
,
Mar 13 2018
As mentioned on our sync. I'll take a look at the VC logic needed to make this happen, we can later take a look at the cell styling
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b07ee78064fbc7bef5f4ba81e9068ef12f6eedfe commit b07ee78064fbc7bef5f4ba81e9068ef12f6eedfe Author: sczs <sczs@chromium.org> Date: Tue Mar 20 18:41:32 2018 [ios] Creates TableViewSigninPromoItem - Creates TableViewSigninPromoItem - Creates TableViewSigninPromoCell, which contains a SigninPromoView. - Adds a TableViewSigninPromoItem to RecentTabsTableVC. Screenshot: https://drive.google.com/open?id=1AEvY83bXQybiwPPHdO38fCbqOdrfXHha Bug: 805164 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I483d94d3a59fbc9e773b6f2f3ef9f69fe6f23303 Reviewed-on: https://chromium-review.googlesource.com/963664 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#544443} [modify] https://crrev.com/b07ee78064fbc7bef5f4ba81e9068ef12f6eedfe/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/b07ee78064fbc7bef5f4ba81e9068ef12f6eedfe/ios/chrome/browser/ui/table_view/cells/BUILD.gn [add] https://crrev.com/b07ee78064fbc7bef5f4ba81e9068ef12f6eedfe/ios/chrome/browser/ui/table_view/cells/table_view_signin_promo_item.h [add] https://crrev.com/b07ee78064fbc7bef5f4ba81e9068ef12f6eedfe/ios/chrome/browser/ui/table_view/cells/table_view_signin_promo_item.mm
,
Mar 21 2018
Polish is still needed.
,
Mar 21 2018
I thought there were a number of different promos. Are those tracked separately, or are they all implemented using the same view?
,
Mar 21 2018
They are implemented on the same view. By promos I mean the cell for when you're completely signed out and asks you to login, and the other one that says continue as XYZ@gmail.com. The view on that CL takes care of both. All other "other devices" cases are just a block of text telling you to turn on sync or to let you know that remote sessions will appear there when there's none, and the Syncing animation. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sczs@chromium.org
, Jan 24 2018