Create a transition animator for use when presenting in regular width.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f83154959716c12eb8bd592f459240bc8d6eb96 commit 2f83154959716c12eb8bd592f459240bc8d6eb96 Author: Rohit Rao <rohitrao@chromium.org> Date: Wed Mar 28 18:02:00 2018 [ios] Adds a UIPresentationController subclass to manage Recent Tabs. BUG= 805154 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3d4bd7a065f355ab81f5d14da7400dcc736385f2 Reviewed-on: https://chromium-review.googlesource.com/983712 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#546542} [modify] https://crrev.com/2f83154959716c12eb8bd592f459240bc8d6eb96/ios/chrome/browser/ui/recent_tabs/BUILD.gn [modify] https://crrev.com/2f83154959716c12eb8bd592f459240bc8d6eb96/ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm [add] https://crrev.com/2f83154959716c12eb8bd592f459240bc8d6eb96/ios/chrome/browser/ui/recent_tabs/recent_tabs_transitioning_delegate.h [add] https://crrev.com/2f83154959716c12eb8bd592f459240bc8d6eb96/ios/chrome/browser/ui/recent_tabs/recent_tabs_transitioning_delegate.mm [modify] https://crrev.com/2f83154959716c12eb8bd592f459240bc8d6eb96/ios/chrome/browser/ui/table_view/BUILD.gn [add] https://crrev.com/2f83154959716c12eb8bd592f459240bc8d6eb96/ios/chrome/browser/ui/table_view/table_view_presentation_controller.h [add] https://crrev.com/2f83154959716c12eb8bd592f459240bc8d6eb96/ios/chrome/browser/ui/table_view/table_view_presentation_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/408434fcfdc529db51aedba06f531044fc55521d commit 408434fcfdc529db51aedba06f531044fc55521d Author: Rohit Rao <rohitrao@chromium.org> Date: Tue Apr 10 16:22:20 2018 [ios] Adds animations for Recent Tabs presentation and dismissal. Also adds a shadow to the presentation controller to visually separate the recent tabs content from the background views. BUG= 805154 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifde4a44c0eac0157ca02fc93c7814a78b51cca12 Reviewed-on: https://chromium-review.googlesource.com/998416 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#549554} [modify] https://crrev.com/408434fcfdc529db51aedba06f531044fc55521d/ios/chrome/browser/ui/recent_tabs/recent_tabs_transitioning_delegate.mm [modify] https://crrev.com/408434fcfdc529db51aedba06f531044fc55521d/ios/chrome/browser/ui/table_view/BUILD.gn [add] https://crrev.com/408434fcfdc529db51aedba06f531044fc55521d/ios/chrome/browser/ui/table_view/table_view_animator.h [add] https://crrev.com/408434fcfdc529db51aedba06f531044fc55521d/ios/chrome/browser/ui/table_view/table_view_animator.mm [modify] https://crrev.com/408434fcfdc529db51aedba06f531044fc55521d/ios/chrome/browser/ui/table_view/table_view_presentation_controller.mm
I've now closed https://bugs.chromium.org/p/chromium/issues/detail?id=805699 since CL 998416 landed using this bug. We can use this one tracking bug for everything "regular width" presentation related.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bde49f3177282dd4d17a936817ae7e941043212 commit 0bde49f3177282dd4d17a936817ae7e941043212 Author: Rohit Rao <rohitrao@chromium.org> Date: Wed Apr 11 22:32:00 2018 [ios] Adds a dimmingShield to TableViewPresentationController. This shield will dismiss the presented view controller when tapped. BUG= 805154 TEST=With UIRefreshPhase1 enabled on tablet, tapping outside of the Recent Tabs view should dismiss Recent Tabs. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5f723382e5e048078461622b23247d5bbfa24644 Reviewed-on: https://chromium-review.googlesource.com/1007766 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#549951} [modify] https://crrev.com/0bde49f3177282dd4d17a936817ae7e941043212/ios/chrome/browser/ui/table_view/table_view_presentation_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17471a72481450aea238e1db90918254a3a5a453 commit 17471a72481450aea238e1db90918254a3a5a453 Author: Rohit Rao <rohitrao@chromium.org> Date: Fri Apr 13 19:03:54 2018 [ios] Use the TableViewPresentationController for History. BUG= 805154 TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaa70b4edc0e0cf69ad8d2fa00be867d56ccc7625 Reviewed-on: https://chromium-review.googlesource.com/1012164 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#550708} [modify] https://crrev.com/17471a72481450aea238e1db90918254a3a5a453/ios/chrome/browser/ui/history/BUILD.gn [modify] https://crrev.com/17471a72481450aea238e1db90918254a3a5a453/ios/chrome/browser/ui/history/history_coordinator.mm [add] https://crrev.com/17471a72481450aea238e1db90918254a3a5a453/ios/chrome/browser/ui/history/history_transitioning_delegate.h [add] https://crrev.com/17471a72481450aea238e1db90918254a3a5a453/ios/chrome/browser/ui/history/history_transitioning_delegate.mm [modify] https://crrev.com/17471a72481450aea238e1db90918254a3a5a453/ios/chrome/browser/ui/table_view/table_view_presentation_controller.mm
Comment 1 by sczs@chromium.org
, Jan 23 2018