New issue
Advanced search Search tips

Issue 805149 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1


Sign in to add a comment

Collections: Create Base Cells

Project Member Reported by sczs@chromium.org, Jan 23 2018

Issue description


Create Base Cell
 

Comment 1 by sczs@chromium.org, Jan 24 2018

Labels: -medium large

Comment 2 by sczs@chromium.org, Jan 24 2018

Description: Show this description

Comment 3 by sczs@chromium.org, Jan 24 2018

Blocking: 805695

Comment 4 by sczs@chromium.org, Jan 24 2018

Blocking: 805696

Comment 5 by sczs@chromium.org, Jan 24 2018

Blocking: 805698

Comment 6 by sczs@chromium.org, Feb 14 2018

Cc: sczs@chromium.org
NextAction: 2018-02-28
Owner: rohitrao@chromium.org
Basic URL cells landed in https://chromium-review.googlesource.com/922602.  Styling is still preliminary.
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5d31d97a2213ad3dff80d7149e286b545e70d3c

commit b5d31d97a2213ad3dff80d7149e286b545e70d3c
Author: sczs <sczs@chromium.org>
Date: Tue Feb 27 18:25:12 2018

[ios] Creates TableViewTextItem

- Creates TableViewTextItem
- Creates TableViewTextCell
- Adds it to the Cell Catalog.

Screenshot:
https://drive.google.com/open?id=1TVy-uclmwfIo32KfQmRrq_aff5_qPvfg

Bug:  805149 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2708d458c06d245beab2cb35f78d1b13101548ff
Reviewed-on: https://chromium-review.googlesource.com/938500
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539502}
[modify] https://crrev.com/b5d31d97a2213ad3dff80d7149e286b545e70d3c/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm
[modify] https://crrev.com/b5d31d97a2213ad3dff80d7149e286b545e70d3c/ios/chrome/browser/ui/table_view/cells/BUILD.gn
[add] https://crrev.com/b5d31d97a2213ad3dff80d7149e286b545e70d3c/ios/chrome/browser/ui/table_view/cells/table_view_text_item.h
[add] https://crrev.com/b5d31d97a2213ad3dff80d7149e286b545e70d3c/ios/chrome/browser/ui/table_view/cells/table_view_text_item.mm
[add] https://crrev.com/b5d31d97a2213ad3dff80d7149e286b545e70d3c/ios/chrome/browser/ui/table_view/cells/table_view_text_item_unittest.mm

The NextAction date has arrived: 2018-02-28

Comment 10 by sczs@chromium.org, Feb 28 2018

Status: Started (was: Assigned)

Comment 11 by cmasso@google.com, Feb 28 2018

NextAction: 2018-03-14
Blockedon: 819209
Blockedon: 819212
Labels: -large
Status: Assigned (was: Started)
Removing the size tag, because this is now an umbrella bug and all real work will be tracked in the child bugs.
Blockedon: 805164

Comment 16 by sczs@chromium.org, Mar 7 2018

Status: Started (was: Assigned)

Comment 17 by cmasso@google.com, Mar 7 2018

Please add the size of this task

Comment 18 by sczs@chromium.org, Mar 13 2018

Labels: medium
Status: Fixed (was: Started)
Will close this since we have child bugs for the remaining tasks
The NextAction date has arrived: 2018-03-14

Comment 20 by cmasso@google.com, Mar 14 2018

NextAction: ----

Sign in to add a comment