Create base TableView that will be used for all the collections.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6e2201b68e2ad1aa004b7807465778644bff7e5 commit f6e2201b68e2ad1aa004b7807465778644bff7e5 Author: Rohit Rao <rohitrao@chromium.org> Date: Wed Feb 14 14:21:36 2018 [ios] Introduces ListModel and ListItem. These serve as common model classes that can back either UICollectionView or UITableView. CollectionViewModel is updated to be a subclass of ListModel with added restrictions on permitted item types but no functional changes. CollectionViewController and its subclasses are largely unchanged. BUG= 805136 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibcfbab5bae62c5c8a37f764508294421d3d1c307 Reviewed-on: https://chromium-review.googlesource.com/916365 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#536708} [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/collection_view/BUILD.gn [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/collection_view/cells/BUILD.gn [delete] https://crrev.com/d0345bb1425f6010ec17823fb63756aafc92f0cb/ios/chrome/browser/ui/collection_view/cells/collection_view_item+collection_view_controller.h [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/collection_view/cells/collection_view_item.h [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/collection_view/cells/collection_view_item.mm [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/collection_view/cells/collection_view_item_unittest.mm [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/collection_view/collection_view_model.h [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/collection_view/collection_view_model.mm [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [add] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/list_model/BUILD.gn [add] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/list_model/list_item+Controller.h [add] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/list_model/list_item.h [add] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/list_model/list_item.mm [add] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/list_model/list_item_unittest.mm [add] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/list_model/list_model.h [add] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/list_model/list_model.mm [rename] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/list_model/list_model_unittest.mm [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/payments/BUILD.gn [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/payments/payment_items_display_view_controller.mm [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/payments/payment_request_selector_view_controller.mm [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/payments/payment_request_view_controller.mm [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/reading_list/BUILD.gn [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm [modify] https://crrev.com/f6e2201b68e2ad1aa004b7807465778644bff7e5/ios/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01568b52e4dcfc03aaae884279d4ac760232b7fe commit 01568b52e4dcfc03aaae884279d4ac760232b7fe Author: sczs <sczs@chromium.org> Date: Wed Feb 14 21:51:44 2018 [iOS] Creates TableViewModel and TableViewItem. Creates TableViewModel and TableViewItem classes that inherit from ListModel and ListItem respectively. Bug: 805136 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I54bee325d856afcc6332910675004634693b210f Reviewed-on: https://chromium-review.googlesource.com/917656 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536832} [add] https://crrev.com/01568b52e4dcfc03aaae884279d4ac760232b7fe/ios/chrome/browser/ui/table_view/BUILD.gn [add] https://crrev.com/01568b52e4dcfc03aaae884279d4ac760232b7fe/ios/chrome/browser/ui/table_view/cells/BUILD.gn [add] https://crrev.com/01568b52e4dcfc03aaae884279d4ac760232b7fe/ios/chrome/browser/ui/table_view/cells/table_view_item.h [add] https://crrev.com/01568b52e4dcfc03aaae884279d4ac760232b7fe/ios/chrome/browser/ui/table_view/cells/table_view_item.mm [add] https://crrev.com/01568b52e4dcfc03aaae884279d4ac760232b7fe/ios/chrome/browser/ui/table_view/cells/table_view_item_unittest.mm [add] https://crrev.com/01568b52e4dcfc03aaae884279d4ac760232b7fe/ios/chrome/browser/ui/table_view/table_view_model.h [add] https://crrev.com/01568b52e4dcfc03aaae884279d4ac760232b7fe/ios/chrome/browser/ui/table_view/table_view_model.mm [modify] https://crrev.com/01568b52e4dcfc03aaae884279d4ac760232b7fe/ios/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf877fb48d08854c75fdf10776ac9a38ecce6a7b commit cf877fb48d08854c75fdf10776ac9a38ecce6a7b Author: sczs <sczs@chromium.org> Date: Thu Feb 15 04:07:27 2018 [ios] Creates ChromeTableViewController -Creates ChromeTableViewController with basic unittests. -Implements basic UITableViewDataSource methods. Bug: 805136 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idbc59f0c0b71c01b9c8513e8bd7907b0f9713971 Reviewed-on: https://chromium-review.googlesource.com/915261 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536942} [modify] https://crrev.com/cf877fb48d08854c75fdf10776ac9a38ecce6a7b/ios/chrome/browser/ui/table_view/BUILD.gn [add] https://crrev.com/cf877fb48d08854c75fdf10776ac9a38ecce6a7b/ios/chrome/browser/ui/table_view/chrome_table_view_controller.h [add] https://crrev.com/cf877fb48d08854c75fdf10776ac9a38ecce6a7b/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm [add] https://crrev.com/cf877fb48d08854c75fdf10776ac9a38ecce6a7b/ios/chrome/browser/ui/table_view/chrome_table_view_controller_unittest.mm [modify] https://crrev.com/cf877fb48d08854c75fdf10776ac9a38ecce6a7b/ios/chrome/test/BUILD.gn
The NextAction date has arrived: 2018-02-28
We may iterate on top adding extra features, but the base Class has been created.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995 commit 5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995 Author: sczs <sczs@chromium.org> Date: Tue Mar 06 00:00:26 2018 [ios] Creates TableViewHeaderFooterItem and TableViewTextHeaderFooterItem. - Creates TableViewHeaderFooterItem and TableViewTextHeaderFooterItem. - Adds viewForHeaderInSection and viewForFooterInSection in ChromeTableVC. Table Catalog Screenshot: https://drive.google.com/open?id=1xKjc3vGVxtkfcz39OdSZY_ENFDO1OnHv Bug: 805136 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5f3923db7909e6fbf732b0bc8d069d2cfbc6603a Reviewed-on: https://chromium-review.googlesource.com/942605 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#540993} [modify] https://crrev.com/5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995/ios/chrome/browser/ui/table_view/cells/BUILD.gn [add] https://crrev.com/5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995/ios/chrome/browser/ui/table_view/cells/table_view_header_footer_item.h [add] https://crrev.com/5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995/ios/chrome/browser/ui/table_view/cells/table_view_header_footer_item.mm [add] https://crrev.com/5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995/ios/chrome/browser/ui/table_view/cells/table_view_header_footer_item_unittest.mm [add] https://crrev.com/5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995/ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item.h [add] https://crrev.com/5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995/ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item.mm [add] https://crrev.com/5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995/ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item_unittest.mm [modify] https://crrev.com/5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm [modify] https://crrev.com/5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995/ios/chrome/browser/ui/table_view/chrome_table_view_controller_unittest.mm [modify] https://crrev.com/5c22cf8bb7bf18392f1b002df9e5dbf6bf0e5995/ios/chrome/browser/ui/table_view/table_view_model.h
Comment 1 by sczs@chromium.org
, Jan 23 2018