New issue
Advanced search Search tips

Issue 805135 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 805131

Blocking:
issue 805136



Sign in to add a comment

Collections: Migrate Recent Tabs to the new ContainerVC

Project Member Reported by sczs@chromium.org, Jan 23 2018

Issue description

Move the existing Recent Tabs TableView to the new ContainerVC
 

Comment 1 by sczs@chromium.org, Jan 23 2018

Blocking: 805136

Comment 2 by sczs@chromium.org, Jan 24 2018

Labels: -medium large

Comment 3 by sczs@chromium.org, Jan 29 2018

Labels: -large medium
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6314dec35908c323bea0b460b3cf4a624e2ced2

commit d6314dec35908c323bea0b460b3cf4a624e2ced2
Author: sczs <sczs@chromium.org>
Date: Fri Feb 23 20:38:16 2018

[ios] Creates RecentTabsTableViewController.

- Creates RecentTabsTableViewController, and adds the plumbing required from BVC to Coordinator
to VC.

Bug:  805135 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I40a2c02f2bd7e93e93bdf75cd365c7853c27ea6f
Reviewed-on: https://chromium-review.googlesource.com/933261
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538883}
[modify] https://crrev.com/d6314dec35908c323bea0b460b3cf4a624e2ced2/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/d6314dec35908c323bea0b460b3cf4a624e2ced2/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/d6314dec35908c323bea0b460b3cf4a624e2ced2/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn
[modify] https://crrev.com/d6314dec35908c323bea0b460b3cf4a624e2ced2/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller.h
[modify] https://crrev.com/d6314dec35908c323bea0b460b3cf4a624e2ced2/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.h
[modify] https://crrev.com/d6314dec35908c323bea0b460b3cf4a624e2ced2/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.mm
[add] https://crrev.com/d6314dec35908c323bea0b460b3cf4a624e2ced2/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.h
[add] https://crrev.com/d6314dec35908c323bea0b460b3cf4a624e2ced2/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/d6314dec35908c323bea0b460b3cf4a624e2ced2/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller_interface.h

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71d5773f46b14a8edf89991fb2f63c1bb1e759c3

commit 71d5773f46b14a8edf89991fb2f63c1bb1e759c3
Author: sczs <sczs@chromium.org>
Date: Tue Feb 27 02:16:25 2018

[ios] Creates Recent Tabs Mediator.

- Creates a Recent Tabs Mediator.
- Moves the Sync implementation from the Coordinator into the Mediator.
- Renames recent_tabs_table_view_controller_interface to recent_tabs_table_consumer
- Cleans up legacy_recent_tabs_table_view_controller_delegate since the parameter wasn't being used.

Bug:  805135 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2bb86b331a05b69a3a05bfe1b89e5043172fc08c
Reviewed-on: https://chromium-review.googlesource.com/935196
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539374}
[modify] https://crrev.com/71d5773f46b14a8edf89991fb2f63c1bb1e759c3/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn
[modify] https://crrev.com/71d5773f46b14a8edf89991fb2f63c1bb1e759c3/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_coordinator.h
[modify] https://crrev.com/71d5773f46b14a8edf89991fb2f63c1bb1e759c3/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_coordinator.mm
[modify] https://crrev.com/71d5773f46b14a8edf89991fb2f63c1bb1e759c3/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller.h
[modify] https://crrev.com/71d5773f46b14a8edf89991fb2f63c1bb1e759c3/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller.mm
[modify] https://crrev.com/71d5773f46b14a8edf89991fb2f63c1bb1e759c3/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller_delegate.h
[add] https://crrev.com/71d5773f46b14a8edf89991fb2f63c1bb1e759c3/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_mediator.h
[add] https://crrev.com/71d5773f46b14a8edf89991fb2f63c1bb1e759c3/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_mediator.mm
[rename] https://crrev.com/71d5773f46b14a8edf89991fb2f63c1bb1e759c3/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_consumer.h
[modify] https://crrev.com/71d5773f46b14a8edf89991fb2f63c1bb1e759c3/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.h
[modify] https://crrev.com/71d5773f46b14a8edf89991fb2f63c1bb1e759c3/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm

Comment 6 by sczs@chromium.org, Feb 28 2018

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edeb1c96e88375f6e60b463097ffea5b116dfc76

commit edeb1c96e88375f6e60b463097ffea5b116dfc76
Author: sczs <sczs@chromium.org>
Date: Tue Mar 06 17:22:21 2018

[ios] Moves implementation from Legacy to New RecentTabsVC.

- Moves implementation from Legacy to New RecentTabsVC.
- Adds some delegate methods to recent_table_coordinator so it supports dismissal.
- Creates a mediator and hooks it up to the RecentTabsTableVC.

Screenshot:
https://drive.google.com/open?id=1xahYQ4Tw-ipPeE--LZkNTUZezx98aR4n

Bug:  805135 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2d14751ca78d19abe84211ea42e291ff1ce3cf7d
Reviewed-on: https://chromium-review.googlesource.com/942185
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541131}
[modify] https://crrev.com/edeb1c96e88375f6e60b463097ffea5b116dfc76/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.mm
[modify] https://crrev.com/edeb1c96e88375f6e60b463097ffea5b116dfc76/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.h
[modify] https://crrev.com/edeb1c96e88375f6e60b463097ffea5b116dfc76/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm

Comment 8 by sczs@chromium.org, Mar 7 2018

Status: Fixed (was: Started)

Sign in to add a comment