Use named layout guides created in blocking bug.
Should we merge 789104 with this bug?
Issue 789104 has been merged into this issue.
The NextAction date has arrived: 2018-02-28
I have several CLs in progress for this bug. I should have them in a state where I can upload and get them reviewed by later today.
2 CLs in review. I've pinged the reviews; will land as soon as lgtm'd.
Note that the two CLs in review do not correctly handle the location for the keyboard accessory view VoiceSearchButton. This functionality will be added after Issue 821665 is fixed.
The NextAction date has arrived: 2018-03-14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c76f7f265fa94e2360986d1062b45c69cf8012d5 commit c76f7f265fa94e2360986d1062b45c69cf8012d5 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Mar 22 19:24:19 2018 [iOS] Add ability to specify frames for NamedGuide. This CL adds the ability to specify constraints for a NamedGuide using frames and autoresizing masks. This will be used to support laying out the NamedGuide corresponding with the voice search button when voice search is being triggered by the keyboard accessory view, as this view is in a separate window from the rest of the application's hierarchy. Bug: 805123 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icf6207f38629de2f5eac381b4f489f7213ecacd1 Reviewed-on: https://chromium-review.googlesource.com/952779 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#545192} [modify] https://crrev.com/c76f7f265fa94e2360986d1062b45c69cf8012d5/ios/chrome/browser/ui/util/named_guide.h [modify] https://crrev.com/c76f7f265fa94e2360986d1062b45c69cf8012d5/ios/chrome/browser/ui/util/named_guide.mm [modify] https://crrev.com/c76f7f265fa94e2360986d1062b45c69cf8012d5/ios/chrome/browser/ui/util/named_guide_unittest.mm
Kurt is this task now completed?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb29e6846082eb91d4a7b880765ff69cc83a2ae3 commit bb29e6846082eb91d4a7b880765ff69cc83a2ae3 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Wed Mar 28 00:14:30 2018 [iOS] NamedGuide improvements. - Adds |constrained| property, indicating whether the guide is constrained to a view or frame. - Adds KVO to listen for constraint deactivation, resetting constraints if all have been deactivated. This can happen if |constrainedView| is moved to a different hierarchy from |owningView|. - Disables user interaction on |constrainedFrameView|. Bug: 805123 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I458d1aa1a5e1e83a0c40ba8a740c1fa6aa8e174b Reviewed-on: https://chromium-review.googlesource.com/980749 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#546327} [modify] https://crrev.com/bb29e6846082eb91d4a7b880765ff69cc83a2ae3/ios/chrome/browser/ui/util/named_guide.h [modify] https://crrev.com/bb29e6846082eb91d4a7b880765ff69cc83a2ae3/ios/chrome/browser/ui/util/named_guide.mm [modify] https://crrev.com/bb29e6846082eb91d4a7b880765ff69cc83a2ae3/ios/chrome/browser/ui/util/named_guide_unittest.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/c5469caeed975a95ef0a399119dc86c38a09192c commit c5469caeed975a95ef0a399119dc86c38a09192c Author: Kurt Horimoto <kkhorimoto@google.com> Date: Wed Mar 28 05:36:37 2018
The NextAction date has arrived: 2018-03-28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e55f551973dc68c987484f56fdb014fffe5c513 commit 5e55f551973dc68c987484f56fdb014fffe5c513 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Tue Apr 03 18:16:09 2018 [iOS] Remove StartVoiceSearchCommand. The origin view location is now communicated via NamedGuides. This is patch 1 of a 3-way patch. Bug: 805123 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I44c595341907b27f81a58b02895746c6cf284250 Reviewed-on: https://chromium-review.googlesource.com/981777 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547766} [modify] https://crrev.com/5e55f551973dc68c987484f56fdb014fffe5c513/ios/chrome/app/main_controller.mm [modify] https://crrev.com/5e55f551973dc68c987484f56fdb014fffe5c513/ios/chrome/browser/ui/browser_view_controller.h [modify] https://crrev.com/5e55f551973dc68c987484f56fdb014fffe5c513/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/5e55f551973dc68c987484f56fdb014fffe5c513/ios/chrome/browser/ui/commands/application_commands.h [modify] https://crrev.com/5e55f551973dc68c987484f56fdb014fffe5c513/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/5e55f551973dc68c987484f56fdb014fffe5c513/ios/chrome/browser/ui/key_commands_provider.mm [modify] https://crrev.com/5e55f551973dc68c987484f56fdb014fffe5c513/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm [modify] https://crrev.com/5e55f551973dc68c987484f56fdb014fffe5c513/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_delegate.mm [modify] https://crrev.com/5e55f551973dc68c987484f56fdb014fffe5c513/ios/public/provider/chrome/browser/voice/voice_search_presenter.h
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0e5cd2cefa203308ec1086d7b6bfb4d86f48d6c9 commit 0e5cd2cefa203308ec1086d7b6bfb4d86f48d6c9 Author: Kurt Horimoto <kkhorimoto@google.com> Date: Thu Apr 05 06:03:00 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c0ee4b6149afcc57df751d9a20f69e57c5745c1 commit 3c0ee4b6149afcc57df751d9a20f69e57c5745c1 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Apr 05 06:55:38 2018 [iOS] Remove StartVoiceSearchCommand. This is patch 3 of a 3-way patch, and must be landed after crrev.com/c/981777 and crrev.com/i/595643. Bug: 805123 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I71dd8dfa19f57b964e7ac08154e94db6614bb895 Reviewed-on: https://chromium-review.googlesource.com/981779 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#548355} [modify] https://crrev.com/3c0ee4b6149afcc57df751d9a20f69e57c5745c1/ios/chrome/app/main_controller.mm [modify] https://crrev.com/3c0ee4b6149afcc57df751d9a20f69e57c5745c1/ios/chrome/browser/ui/browser_view_controller.h [modify] https://crrev.com/3c0ee4b6149afcc57df751d9a20f69e57c5745c1/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/3c0ee4b6149afcc57df751d9a20f69e57c5745c1/ios/chrome/browser/ui/commands/BUILD.gn [modify] https://crrev.com/3c0ee4b6149afcc57df751d9a20f69e57c5745c1/ios/chrome/browser/ui/commands/application_commands.h [delete] https://crrev.com/1c091b202047a6c391e6640c391d575d83398801/ios/chrome/browser/ui/commands/start_voice_search_command.h [delete] https://crrev.com/1c091b202047a6c391e6640c391d575d83398801/ios/chrome/browser/ui/commands/start_voice_search_command.mm [modify] https://crrev.com/3c0ee4b6149afcc57df751d9a20f69e57c5745c1/ios/public/provider/chrome/browser/voice/BUILD.gn [delete] https://crrev.com/1c091b202047a6c391e6640c391d575d83398801/ios/public/provider/chrome/browser/voice/voice_search_presenter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a654e96241e7b3e2154e8f6d62f39cb06df7836 commit 0a654e96241e7b3e2154e8f6d62f39cb06df7836 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Apr 05 08:34:39 2018 Revert "[iOS] Remove StartVoiceSearchCommand." This reverts commit 3c0ee4b6149afcc57df751d9a20f69e57c5745c1. Reason for revert: this is breaking the downstream autoroller as the file ios/public/provider/chrome/browser/voice/voice_search_presenter.h is still included. Original change's description: > [iOS] Remove StartVoiceSearchCommand. > > This is patch 3 of a 3-way patch, and must be landed after > crrev.com/c/981777 and crrev.com/i/595643. > > Bug: 805123 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I71dd8dfa19f57b964e7ac08154e94db6614bb895 > Reviewed-on: https://chromium-review.googlesource.com/981779 > Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548355} TBR=marq@chromium.org,justincohen@chromium.org,kkhorimoto@chromium.org Change-Id: I597a099df96888857173632ebfb92bde002d95d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805123 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/997373 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#548368} [modify] https://crrev.com/0a654e96241e7b3e2154e8f6d62f39cb06df7836/ios/chrome/app/main_controller.mm [modify] https://crrev.com/0a654e96241e7b3e2154e8f6d62f39cb06df7836/ios/chrome/browser/ui/browser_view_controller.h [modify] https://crrev.com/0a654e96241e7b3e2154e8f6d62f39cb06df7836/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/0a654e96241e7b3e2154e8f6d62f39cb06df7836/ios/chrome/browser/ui/commands/BUILD.gn [modify] https://crrev.com/0a654e96241e7b3e2154e8f6d62f39cb06df7836/ios/chrome/browser/ui/commands/application_commands.h [add] https://crrev.com/0a654e96241e7b3e2154e8f6d62f39cb06df7836/ios/chrome/browser/ui/commands/start_voice_search_command.h [add] https://crrev.com/0a654e96241e7b3e2154e8f6d62f39cb06df7836/ios/chrome/browser/ui/commands/start_voice_search_command.mm [modify] https://crrev.com/0a654e96241e7b3e2154e8f6d62f39cb06df7836/ios/public/provider/chrome/browser/voice/BUILD.gn [add] https://crrev.com/0a654e96241e7b3e2154e8f6d62f39cb06df7836/ios/public/provider/chrome/browser/voice/voice_search_presenter.h
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f08ce54d44d6302af53f0c09e27409f8aec8c14b commit f08ce54d44d6302af53f0c09e27409f8aec8c14b Author: Kurt Horimoto <kkhorimoto@google.com> Date: Thu Apr 12 01:51:16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27bbe710a644721cf920c1ae152717eb95d7c37b commit 27bbe710a644721cf920c1ae152717eb95d7c37b Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Apr 12 06:44:42 2018 Reland "[iOS] Remove StartVoiceSearchCommand." This is patch 3 of a 3-way patch, and must be landed after crrev.com/c/981777 and crrev.com/i/595643. Additional cleanup occured downstream in crrev.com/i/602658 Bug: 805123 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iae4ce1a4d9055fa6e8f7a328872be1ca51fcf49e Reviewed-on: https://chromium-review.googlesource.com/998444 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#550052} [modify] https://crrev.com/27bbe710a644721cf920c1ae152717eb95d7c37b/ios/chrome/app/main_controller.mm [modify] https://crrev.com/27bbe710a644721cf920c1ae152717eb95d7c37b/ios/chrome/browser/ui/browser_view_controller.h [modify] https://crrev.com/27bbe710a644721cf920c1ae152717eb95d7c37b/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/27bbe710a644721cf920c1ae152717eb95d7c37b/ios/chrome/browser/ui/commands/BUILD.gn [modify] https://crrev.com/27bbe710a644721cf920c1ae152717eb95d7c37b/ios/chrome/browser/ui/commands/application_commands.h [delete] https://crrev.com/ca41be87c3a9f362068e03090916f969460800f7/ios/chrome/browser/ui/commands/start_voice_search_command.h [delete] https://crrev.com/ca41be87c3a9f362068e03090916f969460800f7/ios/chrome/browser/ui/commands/start_voice_search_command.mm [modify] https://crrev.com/27bbe710a644721cf920c1ae152717eb95d7c37b/ios/public/provider/chrome/browser/voice/BUILD.gn [delete] https://crrev.com/ca41be87c3a9f362068e03090916f969460800f7/ios/public/provider/chrome/browser/voice/voice_search_presenter.h
Comment 1 by kkhorimoto@chromium.org
, Jan 23 2018