This will be used to coordinate the animation rather than passing a UIView around.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05ab282935db36ffeaa1fb29aa293d3ea27208c1 commit 05ab282935db36ffeaa1fb29aa293d3ea27208c1 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Mar 08 03:44:32 2018 [iOS] Update named layout guide API. This CL exposes the previous named layout guide API via a UILayoutGuide subclass called NamedGuide. In addition, this CL adds the ability to reset the view to which the named guide is being constrained, as this will be necessary for voice search, as it can be launched by a variety of buttons. Bug: 805120 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I054c3072cf59ce8ec84eb9002aa228c3a70b2167 Reviewed-on: https://chromium-review.googlesource.com/941407 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541715} [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/download/download_manager_view_controller.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/history_popup/tab_history_legacy_coordinator.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/infobars/infobar_view.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_presenter.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/omnibox_perftest.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view_controller.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/util/BUILD.gn [add] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/util/layout_guide_names.h [add] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/util/layout_guide_names.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/util/named_guide.h [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/util/named_guide.mm [modify] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/util/named_guide_unittest.mm [add] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/util/named_guide_util.h [add] https://crrev.com/05ab282935db36ffeaa1fb29aa293d3ea27208c1/ios/chrome/browser/ui/util/named_guide_util.mm
2 CLs in review. I've pinged the reviews; will land as soon as lgtm'd.
The NextAction date has arrived: 2018-03-14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bfa474b4644145f29fe3b8ca45b06119dcb5361 commit 3bfa474b4644145f29fe3b8ca45b06119dcb5361 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Fri Mar 23 22:02:13 2018 [iOS] Create named guide for last tapped voice search button. Bug: 805120 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I610f604d1f20695d028571166e443c12cd11cc20 Reviewed-on: https://chromium-review.googlesource.com/952766 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545585} [modify] https://crrev.com/3bfa474b4644145f29fe3b8ca45b06119dcb5361/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/3bfa474b4644145f29fe3b8ca45b06119dcb5361/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/3bfa474b4644145f29fe3b8ca45b06119dcb5361/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/3bfa474b4644145f29fe3b8ca45b06119dcb5361/ios/chrome/browser/ui/key_commands_provider.mm [modify] https://crrev.com/3bfa474b4644145f29fe3b8ca45b06119dcb5361/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm [modify] https://crrev.com/3bfa474b4644145f29fe3b8ca45b06119dcb5361/ios/chrome/browser/ui/toolbar/keyboard_assist/BUILD.gn [modify] https://crrev.com/3bfa474b4644145f29fe3b8ca45b06119dcb5361/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_delegate.h [modify] https://crrev.com/3bfa474b4644145f29fe3b8ca45b06119dcb5361/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_delegate.mm [modify] https://crrev.com/3bfa474b4644145f29fe3b8ca45b06119dcb5361/ios/chrome/browser/ui/util/layout_guide_names.h [modify] https://crrev.com/3bfa474b4644145f29fe3b8ca45b06119dcb5361/ios/chrome/browser/ui/util/layout_guide_names.mm
The NextAction date has arrived: 2018-03-28
Comment 1 by kkhorimoto@chromium.org
, Jan 23 2018