Telemetry: loading.desktop benchmark uses mobile versions of sites. |
|||
Issue descriptiontools/perf/run_benchmark loading.desktop --browser=system loads mobile versions of sites. https://cs.chromium.org/chromium/src/tools/perf/page_sets/loading_desktop.py?rcl=8d295a9e59666b54eefd2e382178aad07d6919fd&l=109 should be using SharedDesktopPageState instead of SharedMobilePageState.
,
Jan 24 2018
CL is up: https://chromium-review.googlesource.com/c/chromium/src/+/883004 Some pages failed to load in record_wpr so I disabled them temporarily: Sad page - Ynet - 2ch - MLB - FDA Never finish to load - Leboncoin - Rambler - goo.ne.jp
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea8b932d3e0df99e89dc606dc35335d10e414c94 commit ea8b932d3e0df99e89dc606dc35335d10e414c94 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Thu Jan 25 04:14:51 2018 Re-record loading.desktop story set - Use SharedDesktopPageState instead of SharedMobilePageState - Re-record the story set - Disable stories that WPR could not record the page correctly Note for perf sheriffs: This is expected to affect loading.desktop benchmark. Bug: 805115 Change-Id: I60d6b455c9553bc6b7202bf9082d2a12096a981e Reviewed-on: https://chromium-review.googlesource.com/883004 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#531811} [modify] https://crrev.com/ea8b932d3e0df99e89dc606dc35335d10e414c94/tools/perf/expectations.config [modify] https://crrev.com/ea8b932d3e0df99e89dc606dc35335d10e414c94/tools/perf/page_sets/data/loading_desktop.json [add] https://crrev.com/ea8b932d3e0df99e89dc606dc35335d10e414c94/tools/perf/page_sets/data/loading_desktop_006.wprgo.sha1 [modify] https://crrev.com/ea8b932d3e0df99e89dc606dc35335d10e414c94/tools/perf/page_sets/loading_desktop.py
,
Mar 15 2018
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0e4c38cd1a4a7a123485f5f0acf69bfd820a652 commit c0e4c38cd1a4a7a123485f5f0acf69bfd820a652 Author: Chong Zhang <chongz@chromium.org> Date: Wed Mar 21 22:52:09 2018 [Telemetry] Skip mojo loading stories that disabled in loading.desktop 'loading.desktop.network_service/Rambler' is causing flakiness to the Mojo Linux Perf bot. Disabling all related tests since there is no reference data in loading.desktop. Sample Log: ``` ERROR:edid_parser.cc(180)] invalid EDID: human unreadable char in name ``` https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf.fyi%2FMojo_Linux_Perf%2F4945%2F%2B%2Frecipes%2Fsteps%2Floading.desktop.network_service_on_NVIDIA_GPU_on_Linux%2F0%2Fstdout Bug: 805115 Change-Id: I6a285497302efe5a7562c99683a3f3da74bb2368 Reviewed-on: https://chromium-review.googlesource.com/974170 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#544889} [modify] https://crrev.com/c0e4c38cd1a4a7a123485f5f0acf69bfd820a652/tools/perf/expectations.config |
|||
►
Sign in to add a comment |
|||
Comment 1 by ksakamoto@chromium.org
, Jan 24 2018Status: Assigned (was: Untriaged)