New issue
Advanced search Search tips

Issue 805106 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-07-25
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Cursor is not focused on the omnibox when new tab page is launched from tabswitcher mode using Command + T

Project Member Reported by vbhatso...@chromium.org, Jan 23 2018

Issue description

App Version: 66.0.3329.0 Canary
iOS Version: 10.3.3, 11.2 beta 6
Device: iPad Pro 12’5

PreCondition- Use accessory keyboard

Steps to reproduce:
1. Launch chrome , Open a few web pages, go to tabswitcher mode.
2. Use the keyboard and do Command+T


Observed results:
Cursor is not focused on the omnibox when new tab page is launched from tabswicher mode using Command + T 


Expected results:
Doing a Command+T in the keyboard have the cursor in the omnibox when a new tab page opens.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): Yes on M63
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M64 & M65
Video: https://drive.google.com/file/d/1NglUBSPBxjF6qngaqFX4jKZJLuDanVYg/view?usp=sharing

 

Comment 1 by sczs@chromium.org, Jan 24 2018

Cc: marq@chromium.org
Components: UI>Browser>Mobile>TabSwitcher
Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)
Assigning to edchin@ since you'll be doing some TabSwitcher work. lpromero@ created a fix for this when opening a Tab from a webview, it should be similar.
Labels: -Pri-3 Pri-0
Will make sure this is fixed in the new tab grid. 
Labels: small Q2
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 10 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
Labels: -Pri-0 Pri-1
We want this for keyboard users, but P1 is our Must Have bucket.
Labels: Proj-UIRefresh
Labels: M-69
Owner: kkhorimoto@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0be56f3a61ac5bf2010458b6dd3a0ecce868b737

commit 0be56f3a61ac5bf2010458b6dd3a0ecce868b737
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Tue Jul 24 16:10:09 2018

[iOS] Focus omnibox when keyboard triggers new tab from tab switcher.

Since the OmniboxFocuser dispatcher is owned by the BVC and the tab
switcher coordinator doesn't know about BVC details, this logic needs
to be pushed up to MainController.

Bug:  805106 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4c1e78de8eebb104f597651d9e81f79e292eb079
Reviewed-on: https://chromium-review.googlesource.com/1142540
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577568}
[modify] https://crrev.com/0be56f3a61ac5bf2010458b6dd3a0ecce868b737/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/0be56f3a61ac5bf2010458b6dd3a0ecce868b737/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/0be56f3a61ac5bf2010458b6dd3a0ecce868b737/ios/chrome/browser/ui/tab_grid/tab_grid_adaptor.mm
[modify] https://crrev.com/0be56f3a61ac5bf2010458b6dd3a0ecce868b737/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
[modify] https://crrev.com/0be56f3a61ac5bf2010458b6dd3a0ecce868b737/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator_unittest.mm
[modify] https://crrev.com/0be56f3a61ac5bf2010458b6dd3a0ecce868b737/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.h
[modify] https://crrev.com/0be56f3a61ac5bf2010458b6dd3a0ecce868b737/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/0be56f3a61ac5bf2010458b6dd3a0ecce868b737/ios/chrome/browser/ui/tab_switcher/tab_switcher.h
[modify] https://crrev.com/0be56f3a61ac5bf2010458b6dd3a0ecce868b737/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm

Cc: kariahda@chromium.org
NextAction: 2018-07-25
Status: Fixed (was: Started)
Marking next action date for canary verification before requesting merge.
Labels: Merge-TBD
The NextAction date has arrived: 2018-07-25
Labels: Merge-Request-69
Checked it out on canary this morning; looks good!  Requesting merge for M69.
Labels: -Merge-TBD -Merge-Request-69 Merge-Approved-69
Approved!
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 25

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/550aae32a7ceb37eb58067dd2adab4b2a6dc1e71

commit 550aae32a7ceb37eb58067dd2adab4b2a6dc1e71
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Jul 25 21:04:05 2018

[iOS] Focus omnibox when keyboard triggers new tab from tab switcher.

Since the OmniboxFocuser dispatcher is owned by the BVC and the tab
switcher coordinator doesn't know about BVC details, this logic needs
to be pushed up to MainController.

Bug:  805106 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4c1e78de8eebb104f597651d9e81f79e292eb079
Reviewed-on: https://chromium-review.googlesource.com/1142540
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577568}(cherry picked from commit 0be56f3a61ac5bf2010458b6dd3a0ecce868b737)
Reviewed-on: https://chromium-review.googlesource.com/1150253
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#88}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/550aae32a7ceb37eb58067dd2adab4b2a6dc1e71/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/550aae32a7ceb37eb58067dd2adab4b2a6dc1e71/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/550aae32a7ceb37eb58067dd2adab4b2a6dc1e71/ios/chrome/browser/ui/tab_grid/tab_grid_adaptor.mm
[modify] https://crrev.com/550aae32a7ceb37eb58067dd2adab4b2a6dc1e71/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
[modify] https://crrev.com/550aae32a7ceb37eb58067dd2adab4b2a6dc1e71/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator_unittest.mm
[modify] https://crrev.com/550aae32a7ceb37eb58067dd2adab4b2a6dc1e71/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.h
[modify] https://crrev.com/550aae32a7ceb37eb58067dd2adab4b2a6dc1e71/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/550aae32a7ceb37eb58067dd2adab4b2a6dc1e71/ios/chrome/browser/ui/tab_switcher/tab_switcher.h
[modify] https://crrev.com/550aae32a7ceb37eb58067dd2adab4b2a6dc1e71/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm

Status: Verified (was: Fixed)
Verified in iPhone X(iOS 11.4.1), iPad Air Pro(iOS 11.4.1) and iPhone 6 plus(iOS 10.3.3)

cursor is now focused on the omnibox when loading new tab page from tabswitcher

Link to video:
https://drive.google.com/file/d/1PNX7zAniNuUE62kAi4wVuC0ylB50l5RF/view?usp=sharing
Verified in M69.0.3497.22 Beta in iPhoneX(iOS 11.4.1), iPad Air(iOS 11.4.1) and iPhone 6plus(iOS10.3.3)

cursor is now focused on the omnibox when loading new tab page from tabswitcher

Note:Comment #19 is tested in M70.0.3508.0 Canary

Sign in to add a comment