[iOS] Overscroll Actions: Truncate tooltip text based on system font size and label length |
|||||||||||
Issue descriptionOn compact widths in some localizations, we will need to truncate the tooltip label text. As a first-pass heuristic, this will include limiting the text to two lines and limiting the width to half the width of the UI. When text fits, it will be centered under its corresponding icon. If trunk is too long or needs to be truncated, it will be right or left aligned for New Tab and Close Tab actions.
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
These sound like reasonable heuristics. As far as scaling goes, feel free to read the Dynamic Type guidelines and make a recommendation.
,
Jan 26 2018
,
Jan 27 2018
,
Apr 5 2018
,
Apr 9 2018
Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable? If a fix is in active development, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
,
Apr 18 2018
,
Apr 18 2018
,
Apr 18 2018
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/895e2c4c02a01e7e218a6302d2756729262d8115 commit 895e2c4c02a01e7e218a6302d2756729262d8115 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Fri Apr 20 01:57:05 2018 [iOS] Truncate OverscrollActionView labels to be half the view's width. This can be useful for localized translations of these labels, which may need to span multiple lines. Bug: 805100 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4a4a8b98cb8b7f56f5b7b19dbe8478bf50f4fbf2 Reviewed-on: https://chromium-review.googlesource.com/1018168 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552229} [modify] https://crrev.com/895e2c4c02a01e7e218a6302d2756729262d8115/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm
,
Apr 20 2018
,
Apr 25 2018
The NextAction date has arrived: 2018-04-25
,
Apr 25 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by kkhorimoto@chromium.org
, Jan 23 2018