New issue
Advanced search Search tips

Issue 805100 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 0
Type: Task
Q2

Blocked on:
issue 805092

Blocking:
issue 805086



Sign in to add a comment

[iOS] Overscroll Actions: Truncate tooltip text based on system font size and label length

Project Member Reported by kkhorimoto@chromium.org, Jan 23 2018

Issue description

On compact widths in some localizations, we will need to truncate the tooltip label text.  As a first-pass heuristic, this will include limiting the text to two lines and limiting the width to half the width of the UI.  When text fits, it will be centered under its corresponding icon.  If trunk is too long or needs to be truncated, it will be right or left aligned for New Tab and Close Tab actions.
 
Cc: marq@chromium.org
Mark, do these heuristics seem like a good first pass?  Additionally, would this text be scaled based on the system font setting?  Not sure what the guidelines are on which labels should be scaled; I believe it's mostly for long-form readable content, but we can do it here as well if desired.
Labels: S-Overscroll-Tooltip-Text
Labels: Q1 medium

Comment 4 by marq@chromium.org, Jan 23 2018

These sound like reasonable heuristics.

As far as scaling goes, feel free to read the Dynamic Type guidelines and make a recommendation.

Comment 5 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 6 by cmasso@google.com, Jan 27 2018

Labels: -Q1

Comment 7 by cmasso@google.com, Apr 5 2018

Labels: -Pri-2 Pri-0
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
Status: Started (was: Assigned)
NextAction: 2018-04-25
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/895e2c4c02a01e7e218a6302d2756729262d8115

commit 895e2c4c02a01e7e218a6302d2756729262d8115
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Fri Apr 20 01:57:05 2018

[iOS] Truncate OverscrollActionView labels to be half the view's width.

This can be useful for localized translations of these labels, which
may need to span multiple lines.

Bug:  805100 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4a4a8b98cb8b7f56f5b7b19dbe8478bf50f4fbf2
Reviewed-on: https://chromium-review.googlesource.com/1018168
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552229}
[modify] https://crrev.com/895e2c4c02a01e7e218a6302d2756729262d8115/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm

Status: Fixed (was: Started)
The NextAction date has arrived: 2018-04-25
NextAction: ----

Sign in to add a comment