New issue
Advanced search Search tips

Issue 805092 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 0
Type: Task
Q2

Blocking:
issue 805086
issue 805100



Sign in to add a comment

[iOS] Overscroll Actions: Add tooltip labels to overscroll actions

Project Member Reported by kkhorimoto@chromium.org, Jan 23 2018

Issue description

The new UI includes tooltip text clarifying what each action means.  These need to be added below the button and animated in/out when the selection changes.
 
Blocking: 805100
Labels: S-Overscroll-Tooltip-Text
Labels: Q1 medium

Comment 4 by cma...@chromium.org, Jan 26 2018

Labels: Q2

Comment 5 by cmasso@google.com, Jan 27 2018

Labels: -Q1
Labels: -Q2 Q1

Comment 7 by cmasso@google.com, Mar 28 2018

Labels: -Q1 Q2
Pushing back to Q2 since today is the last day of Q1. Kind of

Comment 8 by cmasso@google.com, Apr 5 2018

Labels: -Pri-2 Pri-0
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Started (was: Assigned)

Comment 11 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
NextAction: 2018-04-25
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71025c330d0831931f84d1165791fbd15c9d49a7

commit 71025c330d0831931f84d1165791fbd15c9d49a7
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Thu Apr 19 22:28:27 2018

[iOS] Add labels to overscroll actions.

This CL adds "Add Tab", "Refresh", and "Close Tab" buttons to the
OverscrollActionView for the UI refresh.

Bug:  805092 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8e562bccf7f6cb062f96d4ae0c0e43872fdeb25b
Reviewed-on: https://chromium-review.googlesource.com/1018008
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552186}
[modify] https://crrev.com/71025c330d0831931f84d1165791fbd15c9d49a7/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/71025c330d0831931f84d1165791fbd15c9d49a7/ios/chrome/browser/ui/overscroll_actions/BUILD.gn
[modify] https://crrev.com/71025c330d0831931f84d1165791fbd15c9d49a7/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
ui-refresh-phase-1 in chrome://flags - Enabled
Verified on iPhone X iOS 11.2.6, iPad Pro 12'5 iOS 11.2.6 on build 68.0.3405.0
Overscroll Actions have "Refresh", "Close Tab", "Add Tab" as tooltip.
The NextAction date has arrived: 2018-04-25
NextAction: ----

Sign in to add a comment