New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 805082 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 800122
issue 821568



Sign in to add a comment

Make bottom sheet work in normal Chrome

Project Member Reported by mdjones@chromium.org, Jan 23 2018

Issue description

For Chrome Home with a split toolbar, the bottom sheet exists, but no longer contains the omnibox. We need to decouple the bottom sheet from the bottom-toolbar version of Chrome Home. This essentially means the bottom sheet needs to work in normal Chrome.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a8beb3935a947b66f658bfe8071b6d394ac636d

commit 4a8beb3935a947b66f658bfe8071b6d394ac636d
Author: Matthew Jones <mdjones@chromium.org>
Date: Wed Feb 14 19:56:02 2018

[Home] Make bottom sheet work in normal Chrome

This change introduces the bottom sheet to normal Chrome. Currently the
sheet shows zine content by default, but this can be changed easily.
Some of the code that depended on the bottom sheet existing has been
removed to behave like normal Chrome does, particularly the menu.
SuggestionsBottomSheetContent has had much of its Chrome Home logic
removed since it no longer exists as part of the NTP. Methods to be
cleaned up in BottomSheet now throw exceptions to easily catch misuse.

BUG= 805082 

Change-Id: I74390cc624836134331da60b9c66c2ab3248647b
Reviewed-on: https://chromium-review.googlesource.com/875184
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536786}
[add] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/java/res/layout/bottom_sheet.xml
[delete] https://crrev.com/534b8346fbe3e380d7534f22058b239d5dbfe2ce/chrome/android/java/res/layout/bottom_toolbar_phone.xml
[modify] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
[modify] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java
[modify] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java
[modify] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
[modify] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/ChromeHomeIphBubbleController.java
[modify] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/4a8beb3935a947b66f658bfe8071b6d394ac636d/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkPersonalizedSigninPromoTest.java

Status: Fixed (was: Assigned)
Blocking: 800122
Blocking: 821568

Sign in to add a comment