Since we will not be supporting multiple versions of Chrome Home, we should deprecate the current check in FeatureUtilities and have it always return false.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c1f5e2ae4263e8769140a8ca41c587b52accb0e commit 6c1f5e2ae4263e8769140a8ca41c587b52accb0e Author: Matthew Jones <mdjones@chromium.org> Date: Tue Feb 06 18:19:53 2018 Add duplex flag and deprecate Chrome Home check This patch adds a new flag for Chrome Duplex since there is too much overhead in reusing the original Chrome Home flag. isChromeHomeEnabled now always returns false. Tests that depend on the bottom sheet have been removed with the exception of those related to suggestions, observers, and swipe logic (which are temporarily disabled). BUG= 805070 Change-Id: I1ec39da11e1e7e0f14cbbe9e77a24f3cd16edd10 Reviewed-on: https://chromium-review.googlesource.com/876529 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534724} [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/java_sources.gni [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/javatests/src/org/chromium/chrome/browser/FeaturesAnnotationsTest.java [delete] https://crrev.com/0a656e429f0454c7ff10ce9eaa1d655aed94fd7c/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/ChromeHomeAppMenuTest.java [delete] https://crrev.com/0a656e429f0454c7ff10ce9eaa1d655aed94fd7c/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeHomeDownloadManagerTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [delete] https://crrev.com/0a656e429f0454c7ff10ce9eaa1d655aed94fd7c/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/BottomSheetLocationBarTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/ContextualSuggestionsTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/HomeSheetCardsUiCaptureTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/HomeSheetNoTilesUiCaptureTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/HomeSheetTilesUiCaptureTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/HomeSheetUiCaptureTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetUiCaptureTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsSheetVisibilityChangeObserverTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGridLayoutTest.java [delete] https://crrev.com/0a656e429f0454c7ff10ce9eaa1d655aed94fd7c/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetBackBehaviorTest.java [delete] https://crrev.com/0a656e429f0454c7ff10ce9eaa1d655aed94fd7c/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentControllerTest.java [delete] https://crrev.com/0a656e429f0454c7ff10ce9eaa1d655aed94fd7c/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigateTest.java [delete] https://crrev.com/0a656e429f0454c7ff10ce9eaa1d655aed94fd7c/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabControllerTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetObserverTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupUnitTest.java [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/browser/about_flags.cc [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/chrome/browser/flag_descriptions.h [modify] https://crrev.com/6c1f5e2ae4263e8769140a8ca41c587b52accb0e/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6082a16afb7e161a8c3304594b4440fdfea646b commit a6082a16afb7e161a8c3304594b4440fdfea646b Author: Bernhard Bauer <bauerb@chromium.org> Date: Tue Jun 05 20:52:48 2018 🏚 Remove FeatureUtilities.isChromeHomeEnabled This allows removing special cases for CH, particularly in the content suggestions code. Bug: 805070 , 847420 Change-Id: I69db669f85564e10e4452cec8bb7dcf75773f283 Reviewed-on: https://chromium-review.googlesource.com/1087048 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#564657} [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageViewMD.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoView.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSitesBridge.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRecyclerView.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabBrowserControlsOffsetHelper.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/java/src/org/chromium/chrome/browser/widget/PulseDrawable.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItemTest.java [modify] https://crrev.com/a6082a16afb7e161a8c3304594b4440fdfea646b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aed6c868be30a581131b2c108894b4cba15b8846 commit aed6c868be30a581131b2c108894b4cba15b8846 Author: Bernhard Bauer <bauerb@chromium.org> Date: Tue Jun 12 21:26:01 2018 Clean up SuggestionsRecyclerView and SnippetArticleViewHolder Remove peeking card and other unused code. Bug: 805070 Change-Id: Ibef79b89907b6a33959d778cdd342c79db46edc9 Reviewed-on: https://chromium-review.googlesource.com/1097414 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#566575} [modify] https://crrev.com/aed6c868be30a581131b2c108894b4cba15b8846/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java [modify] https://crrev.com/aed6c868be30a581131b2c108894b4cba15b8846/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java [modify] https://crrev.com/aed6c868be30a581131b2c108894b4cba15b8846/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRecyclerView.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d510510fd974115eb9a091054a017688306e3438 commit d510510fd974115eb9a091054a017688306e3438 Author: Bernhard Bauer <bauerb@chromium.org> Date: Wed Jun 13 10:33:48 2018 Remove LogoItem and SiteSection from NewTabPageAdapter Bug: 805070 Change-Id: I60095497d0dcf5029737ae511be13bb8d9af55d8 Reviewed-on: https://chromium-review.googlesource.com/1097412 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#566789} [modify] https://crrev.com/d510510fd974115eb9a091054a017688306e3438/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/d510510fd974115eb9a091054a017688306e3438/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/d510510fd974115eb9a091054a017688306e3438/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java [modify] https://crrev.com/d510510fd974115eb9a091054a017688306e3438/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ItemViewType.java [modify] https://crrev.com/d510510fd974115eb9a091054a017688306e3438/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/d510510fd974115eb9a091054a017688306e3438/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeVisitor.java [delete] https://crrev.com/14e334f137a2ed71af44602420c7e930caa4361a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/LogoItem.java [modify] https://crrev.com/d510510fd974115eb9a091054a017688306e3438/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SiteSection.java [modify] https://crrev.com/d510510fd974115eb9a091054a017688306e3438/chrome/android/java_sources.gni [modify] https://crrev.com/d510510fd974115eb9a091054a017688306e3438/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGridLayoutTest.java [modify] https://crrev.com/d510510fd974115eb9a091054a017688306e3438/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/d510510fd974115eb9a091054a017688306e3438/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e194d3763d60c12fcd20b28e1a8d634825cbf724 commit e194d3763d60c12fcd20b28e1a8d634825cbf724 Author: Bernhard Bauer <bauerb@chromium.org> Date: Wed Jun 20 13:05:04 2018 Simplify use of RecyclerViewModelChangeProcessor for list models. Move most of the logic out of the RecyclerViewAdapter into its newly introduced delegate (which RecyclerViewModelChangeProcessor now implements). Update RecyclerViewModelChangeProcessor to better handle its most common use case, which is to represent a plain list of items. Other, more complicated use cases can be implemented with a custom RecyclerViewAdapter.Delegate implementation (which could go away in the future as we extend the capabilities). Remove getItemCount() from ListObservable in favor of moving it to a new SimpleList<> interface, to better separate accessing items in a list from observing changes to it. Make the ViewBinder interface functional again, by moving ViewHolder creation to its own functional interface, and update clients to use method references. Bug: 805070 Change-Id: I565b2e9888e9cbaf8eb0f3dfc73df4baf197f30a Reviewed-on: https://chromium-review.googlesource.com/1100831 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#568810} [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessoryPagerAdapter.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetMediator.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetModel.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewBinder.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java [delete] https://crrev.com/02a9ea694fadb12a770389b50ebbb0b164e29501/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewAdapter.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewBinder.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContentCoordinator.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsAdapter.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsCoordinator.java [delete] https://crrev.com/02a9ea694fadb12a770389b50ebbb0b164e29501/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsViewBinder.java [add] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsViewHolder.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListCoordinator.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListMutator.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListView.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListViewAdapter.java [delete] https://crrev.com/02a9ea694fadb12a770389b50ebbb0b164e29501/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListViewBinder.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DecoratedListItemModel.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/ListItemModel.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/ListItemViewHolder.java [add] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/modelutil/ForwardingListObservable.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/modelutil/ListModelChangeProcessor.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/modelutil/ListObservable.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/modelutil/RecyclerViewAdapter.java [delete] https://crrev.com/02a9ea694fadb12a770389b50ebbb0b164e29501/chrome/android/java/src/org/chromium/chrome/browser/modelutil/RecyclerViewModelChangeProcessor.java [add] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/modelutil/SimpleList.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/modelutil/SimpleListObservable.java [add] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java/src/org/chromium/chrome/browser/modelutil/SimpleRecyclerViewMcp.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/java_sources.gni [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewTest.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetControllerTest.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetControllerTest.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/junit/src/org/chromium/chrome/browser/download/home/list/DateOrderedListMutatorTest.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/junit/src/org/chromium/chrome/browser/modelutil/SimpleListObservableTest.java [modify] https://crrev.com/e194d3763d60c12fcd20b28e1a8d634825cbf724/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f811c2e5dd8a6763136882ec980211ceb7673f6 commit 6f811c2e5dd8a6763136882ec980211ceb7673f6 Author: Bernhard Bauer <bauerb@chromium.org> Date: Thu Jun 21 23:24:28 2018 Remove NodeVisitor in favor of simple string descriptions of items NodeVisitor has only been used in tests, and this removes domain-specific logic from the TreeNode interface so it aligns better with the Clank UI architecture. Bug: 805070 Change-Id: I1c9e9e200cc7a87b7da4160a0c85605304bafe4a Reviewed-on: https://chromium-review.googlesource.com/1108204 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#569446} [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsCluster.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AboveTheFoldItem.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java [delete] https://crrev.com/7a570faeb1341485dde67659cbe34c3f323dc7f4/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeVisitor.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/OptionalLeaf.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeader.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SiteSection.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/java_sources.gni [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java [modify] https://crrev.com/6f811c2e5dd8a6763136882ec980211ceb7673f6/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a0d2521e42ce861437617a25f422a739fdda281 commit 2a0d2521e42ce861437617a25f422a739fdda281 Author: Bernhard Bauer <bauerb@chromium.org> Date: Wed Aug 01 22:45:42 2018 Merge TreeNode into RecyclerViewAdapter.Delegate * Provide default implementations for newly added methods for dismissing and describing items. * Split out base classes for SimpleListObservable and SimpleRecyclerViewMcp that support partial updates. SimpleListObservable and SimpleRecyclerViewMcp now internally use Void for the payload type to indicate that partial updates are not supported. * Decouple ChildNode and InnerNode from the content suggestions code by parameterizing them. In a future CL they should be moved out of the ntp.cards package and renamed. Bug: 805070 Change-Id: I1b996d8af4c85e07bdf45e435eb045a626669ba2 Reviewed-on: https://chromium-review.googlesource.com/1109973 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#579973} [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ClusterList.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContentCoordinator.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsCluster.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/modelutil/RecyclerViewAdapter.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/modelutil/SimpleListObservable.java [add] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/modelutil/SimpleListObservableBase.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/modelutil/SimpleRecyclerViewMcp.java [add] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/modelutil/SimpleRecyclerViewMcpBase.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/OptionalLeaf.java [add] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/PartiallyBindable.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [delete] https://crrev.com/bbdec9a7b1c7c3670313c1bae2e0f282c22e27fb/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/java_sources.gni [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsUnitTestUtils.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/2a0d2521e42ce861437617a25f422a739fdda281/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java
Comment 1 by bugdroid1@chromium.org
, Feb 6 2018