DCHECK failure in external/wpt/custom-elements/upgrading/Node-cloneNode.html |
|||||
Issue descriptionUpstream PR https://github.com/w3c/web-platform-tests/pull/9147 introduced a new test in external/wpt/custom-elements/upgrading/Node-cloneNode.html that is currently being imported. The test trips a DCHECK on all platforms, with or without site isolation. Example crash log: https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/630540/layout-test-results/external/wpt/custom-elements/upgrading/Node-cloneNode-crash-log.txt
,
Jan 23 2018
Notably this does not fail unless you turn on the experimental web-platform-features. I assume this is part of our half-done customized built-in elements implementation.
,
Jan 26 2018
,
Jan 29 2018
STDERR: [1:1:0123/130205.389194:FATAL:V0CustomElementRegistrationContext.cpp(161)] Check failed: !V0CustomElement::IsValidName(element->localName()). STDERR: #0 0x00000314d1ec base::debug::StackTrace::StackTrace() STDERR: #1 0x00000316c2c3 logging::LogMessage::~LogMessage() STDERR: #2 0x00000559ba76 blink::V0CustomElementRegistrationContext::SetTypeExtension() STDERR: #3 0x0000051171eb blink::Element::CloneAttributesFromElement() STDERR: #4 0x000005100923 blink::Element::CloneElementWithoutChildren() STDERR: #5 0x000004a8613a blink::V8Node::cloneNodeMethodCallback()
,
Feb 2 2018
,
Feb 2 2018
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6c0aa15fad31c353bde8f2b75944cc277d8530c commit a6c0aa15fad31c353bde8f2b75944cc277d8530c Author: Kent Tamura <tkent@chromium.org> Date: Fri Feb 02 06:10:16 2018 custom-elements: Fix a DCHECK failure with external/wpt/custom-elements/upgrading/Node-cloneNode.html. V0CustomElementRegistrationContext::SetTypeExtension() is not expected to be called for autonomous custom elements. Element:: AttributeChangedFromParserOrByCloning() should check it. Bug: 805061 Change-Id: Ie91256bb6b6b8671d4a6a65374db31394a08d2ea Reviewed-on: https://chromium-review.googlesource.com/897169 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533972} [modify] https://crrev.com/a6c0aa15fad31c353bde8f2b75944cc277d8530c/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/a6c0aa15fad31c353bde8f2b75944cc277d8530c/third_party/WebKit/Source/core/dom/Element.cpp
,
Feb 2 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jan 23 2018