New issue
Advanced search Search tips

Issue 805057 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug

Blocked on:
issue 798851
issue 799309



Sign in to add a comment

Delete old runner scripts & GN rules

Project Member Reported by kmarshall@chromium.org, Jan 23 2018

Issue description

Cleanup tracking bug for deleting the deprecated, non-packaged runner scripts and associated GN rules.
 
Blockedon: 799309

Comment 2 by w...@chromium.org, Apr 27 2018

Blockedon: 798851
Labels: -Pri-3 M-68 Pri-2
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ae01362bd9d149b0c5f9d857676710249d6cca4

commit 3ae01362bd9d149b0c5f9d857676710249d6cca4
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Fri Apr 27 19:29:18 2018

Fuchsia: Remove bootfs-based runner v1 from build.

* Delete runner V1 scripts.
* Relocate runner V2 scripts to runner V1 location, and remove
  "runner_v2" directory.
* Delete unused GN attributes and transitional GN groups().
* Remove override flags from Fuchsia FYI buildbots.


Bug:  805057 
Change-Id: I62e8fbfa200ebf31bd0a766bc276477ddca0b673
Reviewed-on: https://chromium-review.googlesource.com/1031564
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554448}
[modify] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/config/fuchsia/rules.gni
[rename] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/__init__.py
[delete] https://crrev.com/64f1d03f83a2c98a244ded79468b7e056b121690/build/fuchsia/archive_builder.py
[rename] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/boot_data.py
[rename] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/common.py
[rename] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/common_args.py
[modify] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/create_runner_script.py
[rename] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/device_target.py
[modify] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/exe_runner.py
[rename] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/net_test_server.py
[rename] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/qemu_target.py
[rename] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/qemu_target_test.py
[rename] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/remote_cmd.py
[rename] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/run_package.py
[delete] https://crrev.com/64f1d03f83a2c98a244ded79468b7e056b121690/build/fuchsia/runner_common.py
[delete] https://crrev.com/64f1d03f83a2c98a244ded79468b7e056b121690/build/fuchsia/runner_v2/create_runner_script.py
[delete] https://crrev.com/64f1d03f83a2c98a244ded79468b7e056b121690/build/fuchsia/runner_v2/exe_runner.py
[delete] https://crrev.com/64f1d03f83a2c98a244ded79468b7e056b121690/build/fuchsia/runner_v2/test_runner.py
[rename] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/symbolizer.py
[rename] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/target.py
[modify] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/build/fuchsia/test_runner.py
[modify] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/3ae01362bd9d149b0c5f9d857676710249d6cca4/testing/test.gni

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a5a547743c1b2d7a784b73cc2c446f30db81c05

commit 1a5a547743c1b2d7a784b73cc2c446f30db81c05
Author: John Budorick <jbudorick@chromium.org>
Date: Sat Apr 28 00:48:51 2018

Disable two flaky layout tests.

Also fix fuchsia layout test imports.

TBR=dpranke@chromium.org,kmarshall@chromium.org,sahel@chromium.org

Bug:  805057 ,837786
Change-Id: I9b90c985e95df053c2badce8038d57bef3f7cd8d
Reviewed-on: https://chromium-review.googlesource.com/1034097
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554584}
[modify] https://crrev.com/1a5a547743c1b2d7a784b73cc2c446f30db81c05/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/1a5a547743c1b2d7a784b73cc2c446f30db81c05/third_party/blink/tools/blinkpy/web_tests/port/fuchsia.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be22fa304d55d16f261cfd146716f2d9cd87b0df

commit be22fa304d55d16f261cfd146716f2d9cd87b0df
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Mon Apr 30 09:04:44 2018

Fuchsia: Delete package-probing conditionals from codebase.

All executables are run within packages now, so there is no more need
to support both packaged and non-packaged execution modes.
The transitional codepaths to handle both cases are no longer needed.

This CL removes the bootfs mode from the local SDK builder script.


Bug:  805057 
Change-Id: I01bf0223a70f440de675d4ec2434248f973f3eb6
Reviewed-on: https://chromium-review.googlesource.com/1033475
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554711}
[modify] https://crrev.com/be22fa304d55d16f261cfd146716f2d9cd87b0df/base/base_paths_fuchsia.cc
[modify] https://crrev.com/be22fa304d55d16f261cfd146716f2d9cd87b0df/base/native_library_fuchsia.cc
[modify] https://crrev.com/be22fa304d55d16f261cfd146716f2d9cd87b0df/base/process/process_util_unittest.cc
[modify] https://crrev.com/be22fa304d55d16f261cfd146716f2d9cd87b0df/content/common/sandbox_policy_fuchsia.cc
[modify] https://crrev.com/be22fa304d55d16f261cfd146716f2d9cd87b0df/net/test/spawned_test_server/remote_test_server_config.cc
[modify] https://crrev.com/be22fa304d55d16f261cfd146716f2d9cd87b0df/testing/buildbot/filters/fuchsia.base_unittests.filter
[modify] https://crrev.com/be22fa304d55d16f261cfd146716f2d9cd87b0df/tools/fuchsia/local-sdk.py

Status: Verified (was: Started)

Sign in to add a comment