Pointerlock doesn't release the pointer capture |
||||||||
Issue descriptionWhen a pointer is captured and pointer lock is requested pointer capture should be released and lock goes in place. This behavior seems to be failing Testing with: http://w3c-test.org/pointerevents/pointerlock/pointerevent_pointerlock_after_pointercapture-manual.html
,
Jan 23 2018
IIRC, we do release pointer capture when lock the pointer. And we has an automation for this test. Which platform is this test failing on? It seems pass on my macOs
,
Jan 24 2018
You are right. I should have been more specific. I also just tested on Mac and it passed for me. It failed on Windows 10.
,
Jan 24 2018
,
Jan 24 2018
,
Jan 24 2018
I put the wrong test link in the description at first. The first test was already passing.
,
Feb 1 2018
The pointer is not locked because of the lock is rejected by security check. (got a pointerlockerror event instead). See: https://cs.chromium.org/chromium/src/chrome/browser/ui/exclusive_access/mouse_lock_controller.cc?gsn=RequestToLockMouse&l=57 This test is passed when enable UserActivationV2.
,
Feb 1 2018
,
Feb 1 2018
The lock request is not made from within mousedown, so I don't see why the test was passing before. The code around the user activation check at RenderWidgetMouseLockDispatcher::SendLockMouseRequest() hasn't changed except for UserActivationV2.
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/932c27f9542f1f15b9c4b75493fd513796ba478e commit 932c27f9542f1f15b9c4b75493fd513796ba478e Author: Ella Ge <eirage@chromium.org> Date: Tue Feb 06 15:23:36 2018 Update a pointerlock test This CL update the wpt test pointerevent_pointerlock_after_pointercapture. Previously this test request pointer lock on pointermove, it got a pointerlockerror event because it doesn't request the lock in a user gesture. This CL change the test to send lock request by a right click. Bug: 805052 Change-Id: I27b60475ccda94ca59e018ab76550379bc3852e4 Reviewed-on: https://chromium-review.googlesource.com/902450 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#534689} [modify] https://crrev.com/932c27f9542f1f15b9c4b75493fd513796ba478e/third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerlock/pointerevent_pointerlock_after_pointercapture-manual.html [modify] https://crrev.com/932c27f9542f1f15b9c4b75493fd513796ba478e/third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerlock/pointerevent_pointerlock_after_pointercapture-manual-automation.js
,
Feb 6 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by nzolghadr@chromium.org
, Jan 23 2018