The maximum verb count in Skia's edge-AA tessellating path renderer is currently set to 10. Many benchmarks and test cases improve if this value is increased to 100.
The following revision refers to this bug: https://skia.googlesource.com/skia/+/a7701e032bcc55a73360aa8d1b53ceef566de991 commit a7701e032bcc55a73360aa8d1b53ceef566de991 Author: Stephen White <senorblanco@chromium.org> Date: Tue Jan 23 21:05:50 2018 GrTessellator: add a #define for max aa verb count. We'd like to increase the maximum verb count for the edge-AA tessellating path renderer. In order to protect clients from this change, we allow them to set their own value. Bug:805031 Change-Id: I5d41059a217f059998d418d51fcc8c88464ef4da Reviewed-on: https://skia-review.googlesource.com/98886 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org> [modify] https://crrev.com/a7701e032bcc55a73360aa8d1b53ceef566de991/src/gpu/ops/GrTessellatingPathRenderer.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac87d1e277e2bb4718b266d3fdabb181c6283e16 commit ac87d1e277e2bb4718b266d3fdabb181c6283e16 Author: Stephen White <senorblanco@chromium.org> Date: Tue Jan 23 22:39:30 2018 Protect against an upcoming Skia change via #define. No user-visible change. BUG= 805031 Change-Id: Ia29f46bd96661661f726798723f395ff8ddab77d Reviewed-on: https://chromium-review.googlesource.com/881866 Reviewed-by: Brian Salomon <bsalomon@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#531372} [modify] https://crrev.com/ac87d1e277e2bb4718b266d3fdabb181c6283e16/skia/config/SkUserConfig.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df18b96b443774d232e39ead6cbd81c848b8563c commit df18b96b443774d232e39ead6cbd81c848b8563c Author: Stephen White <senorblanco@chromium.org> Date: Mon Jun 18 20:54:43 2018 Adjust the edge-AA tessellator maximum verb count. Increasing the verb count from 10 to 100 in Skia's edge-AA tessellating path renderer improves performance on many tests, including Animometer's Canvas Stroke Paths and the bugs listed below. Bug: 805031 , 223694 , 715116 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I57d775ddce3200e5f54bae448de9fd2dffe30e72 Reviewed-on: https://chromium-review.googlesource.com/1099564 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#568155} [modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/content/test/gpu/gpu_tests/pixel_expectations.py [modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/content/test/gpu/gpu_tests/pixel_test_pages.py [modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/skia/config/SkUserConfig.h [modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/imagemap-overflowing-polygon-focus-ring-expected.png [modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/imagemap-polygon-focus-ring-expected.png [modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [add] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-connecting-line-expected.png [modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png [modify] https://crrev.com/df18b96b443774d232e39ead6cbd81c848b8563c/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/downsample-quality-expected.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/428a0e6fe2da1368d0c4e9689b37d3bb2cc5c106 commit 428a0e6fe2da1368d0c4e9689b37d3bb2cc5c106 Author: Miguel Casas <mcasas@chromium.org> Date: Tue Oct 30 01:07:01 2018 pixel tests: Uprev Pixel_OffscreenCanvasAccelerated2D* This CL prevs OffscreenCanvasAccelerated2D* before reenabling them in crrev.com/c/1303097. The tests are already marked as failing unconditionally. Bug: 805031 Change-Id: Iae9af1f4a21db545578c67e38eb66e57d83d2e19 Reviewed-on: https://chromium-review.googlesource.com/c/1305400 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#603714} [modify] https://crrev.com/428a0e6fe2da1368d0c4e9689b37d3bb2cc5c106/content/test/gpu/gpu_tests/pixel_test_pages.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cb3899c4e35bdc35fa5e6270ee900656f0d2219 commit 0cb3899c4e35bdc35fa5e6270ee900656f0d2219 Author: Miguel Casas <mcasas@chromium.org> Date: Tue Oct 30 18:01:00 2018 pixel tests: Reenable Pixel_OffscreenCanvasAccelerated2D* crrev.com/c/1099564 disabled the Pixel_OffscreenCanvasAccelerated2D* tests, correctly increasing the version in pixel_test_pages.py. These tests seem to be passing according to [1], so let's try and reenable them. [1] http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?868948046954e7d06d97eb10544ea3b27b320953_android_marshmallow_arm64_rel_telemetry CQ-DEPEND=CL:1303097 Bug: 805031 Change-Id: Ie6b48fde0a03fefbbff185de1818e3105192f5f3 Reviewed-on: https://chromium-review.googlesource.com/c/1303097 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#603959} [modify] https://crrev.com/0cb3899c4e35bdc35fa5e6270ee900656f0d2219/content/test/gpu/gpu_tests/pixel_expectations.py
Comment 1 by bugdroid1@chromium.org
, Jan 23 2018