Async DNS on Android doesn't handle VPNs on pre-Marshmallow |
||||||
Issue descriptionThis is the cause (or at least one cause) of the ad blocker problems mentioned in https://www.xda-developers.com/fix-dns-ad-blocker-chrome/.
,
Jan 23 2018
please change back to default
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cf139722087a9f4975d7f155af1fd937f97bb25 commit 8cf139722087a9f4975d7f155af1fd937f97bb25 Author: Miriam Gershenson <mgersh@chromium.org> Date: Tue Jan 23 22:48:29 2018 Revert "Enable "AsyncDns" feature by default on Android" This reverts commit 0532f223eac50c7aee9677bf499ba6c5c182a41f. Reason for revert: Full launch needs to be rolled back and retried in a future milestone due to a bug. The experiment cleanup here was premature. Original change's description: > Enable "AsyncDns" feature by default on Android > > Also clean up Android-specific experiment code, but leave the > base::Feature. > > Bug: 768874 > Change-Id: Ic7b81a878e3e81bc1a5c2c2fae242df23c5387ca > Reviewed-on: https://chromium-review.googlesource.com/868077 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Miriam Gershenson <mgersh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#529866} TBR=isherman@chromium.org,mgersh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768874, 805020 Change-Id: Ib67c727aef748b4e80714e6128c3bfbdc24d3544 Reviewed-on: https://chromium-review.googlesource.com/881206 Reviewed-by: Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531381} [modify] https://crrev.com/8cf139722087a9f4975d7f155af1fd937f97bb25/chrome/browser/about_flags.cc [modify] https://crrev.com/8cf139722087a9f4975d7f155af1fd937f97bb25/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/8cf139722087a9f4975d7f155af1fd937f97bb25/chrome/browser/flag_descriptions.h [modify] https://crrev.com/8cf139722087a9f4975d7f155af1fd937f97bb25/chrome/common/chrome_features.cc [modify] https://crrev.com/8cf139722087a9f4975d7f155af1fd937f97bb25/testing/variations/fieldtrial_testing_config.json
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64262b5a93ee7362e32368ee1622fe6c8994da7e commit 64262b5a93ee7362e32368ee1622fe6c8994da7e Author: Miriam Gershenson <mgersh@chromium.org> Date: Fri Jan 26 19:34:46 2018 Allow enabling async DNS only for newer Android The async resolver has some Android-version-specific problems. This will allow enabling it via Finch for newer Android before the problems with older Android are worked out. Bug: 768874, 805020 Change-Id: Iec9aeaa255dbb110103ae7ca7ffe8b19dbded235 Reviewed-on: https://chromium-review.googlesource.com/887601 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#532039} [modify] https://crrev.com/64262b5a93ee7362e32368ee1622fe6c8994da7e/chrome/browser/io_thread.cc
,
Jan 29 2018
,
Jan 29 2018
Note on merge request: I made a request for the CL in c#3 in the other bug last week, and it hasn't been reviewed yet. I'm now asking to merge both that and the CL in c#4.
,
Jan 29 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 29 2018
Has this been verified in canary?
,
Jan 29 2018
Yes, it landed last week and has been verified.
,
Jan 29 2018
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d99c47819cb187753879aec683d9efbbf1bd850 commit 5d99c47819cb187753879aec683d9efbbf1bd850 Author: Miriam Gershenson <mgersh@chromium.org> Date: Mon Jan 29 22:36:35 2018 Revert "Enable "AsyncDns" feature by default on Android" This reverts commit 0532f223eac50c7aee9677bf499ba6c5c182a41f. Reason for revert: Full launch needs to be rolled back and retried in a future milestone due to a bug. The experiment cleanup here was premature. Original change's description: > Enable "AsyncDns" feature by default on Android > > Also clean up Android-specific experiment code, but leave the > base::Feature. > > Bug: 768874 > Change-Id: Ic7b81a878e3e81bc1a5c2c2fae242df23c5387ca > Reviewed-on: https://chromium-review.googlesource.com/868077 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Miriam Gershenson <mgersh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#529866} TBR=isherman@chromium.org,mgersh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768874, 805020 Change-Id: Ib67c727aef748b4e80714e6128c3bfbdc24d3544 Reviewed-on: https://chromium-review.googlesource.com/881206 Reviewed-by: Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531381}(cherry picked from commit 8cf139722087a9f4975d7f155af1fd937f97bb25) Reviewed-on: https://chromium-review.googlesource.com/891999 Cr-Commit-Position: refs/branch-heads/3325@{#156} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/5d99c47819cb187753879aec683d9efbbf1bd850/chrome/browser/about_flags.cc [modify] https://crrev.com/5d99c47819cb187753879aec683d9efbbf1bd850/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/5d99c47819cb187753879aec683d9efbbf1bd850/chrome/browser/flag_descriptions.h [modify] https://crrev.com/5d99c47819cb187753879aec683d9efbbf1bd850/chrome/common/chrome_features.cc [modify] https://crrev.com/5d99c47819cb187753879aec683d9efbbf1bd850/testing/variations/fieldtrial_testing_config.json
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be98e5982f8b03a1e8139a5b0aeab910a781cc40 commit be98e5982f8b03a1e8139a5b0aeab910a781cc40 Author: Miriam Gershenson <mgersh@chromium.org> Date: Mon Jan 29 22:37:56 2018 Allow enabling async DNS only for newer Android The async resolver has some Android-version-specific problems. This will allow enabling it via Finch for newer Android before the problems with older Android are worked out. Bug: 768874, 805020 Change-Id: Iec9aeaa255dbb110103ae7ca7ffe8b19dbded235 Reviewed-on: https://chromium-review.googlesource.com/887601 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#532039}(cherry picked from commit 64262b5a93ee7362e32368ee1622fe6c8994da7e) Reviewed-on: https://chromium-review.googlesource.com/892000 Reviewed-by: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#157} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/be98e5982f8b03a1e8139a5b0aeab910a781cc40/chrome/browser/io_thread.cc
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a97831b21752cff5e7c542874163ecf5f5ebfb7f commit a97831b21752cff5e7c542874163ecf5f5ebfb7f Author: Miriam Gershenson <mgersh@chromium.org> Date: Wed Jan 31 16:06:14 2018 Disable async DNS if VPN is present on L and earlier The DnsConfigService can't get a correct DNS config for a VPN until Android M. On earlier versions, check for a VPN and treat it as a config read failure. Bug: 805020 Change-Id: I696c52a2e012460ddd70381e5278c3abca9ca665 Reviewed-on: https://chromium-review.googlesource.com/894149 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#533287} [modify] https://crrev.com/a97831b21752cff5e7c542874163ecf5f5ebfb7f/net/base/address_tracker_linux.cc [modify] https://crrev.com/a97831b21752cff5e7c542874163ecf5f5ebfb7f/net/base/address_tracker_linux.h [modify] https://crrev.com/a97831b21752cff5e7c542874163ecf5f5ebfb7f/net/base/address_tracker_linux_unittest.cc [modify] https://crrev.com/a97831b21752cff5e7c542874163ecf5f5ebfb7f/net/dns/dns_config_service_posix.cc
,
Jan 31 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by justin.m...@danvillecsd.org
, Jan 23 2018