New issue
Advanced search Search tips

Issue 805015 link

Starred by 1 user
Status: Fixed
Owner:
mustaq@chromium.org
Closed: Jul 5
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 802294



Sign in to add a comment

UserActivationV2 hides parent frame's activation from child frame

Project Member Reported by mustaq@chromium.org, Jan 23 2018 
Our current UserGestureIndicator-based code has activation state shared across the renderer.  With UserActivationV2, the state becomes frame based, and a child frame is not "activated" through user interaction in its parent frame.

This expected behavior change is causing the following tests to fail:

[Layout tests]
external/wpt/fullscreen/model/move-to-fullscreen-iframe-manual.html
fast/events/open-window-from-another-frame.html
fast/dom/Window/window-postmessage-user-gesture.html
fullscreen/api/element-request-fullscreen-two-iframes.html

[browser_tests]
ClipboardApiTest.HostedAppNoPermission
ContentCapabilitiesTest.ClipboardWrite

---
The list above is not exhaustive, we have to few more failing browser tests to dig into.

Comment 1 by mustaq@chromium.org, Jan 23 2018

Blocking: 802294
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f99cf39263e7ec4e88eb2ec33e9760638b6907e1

commit f99cf39263e7ec4e88eb2ec33e9760638b6907e1
Author: Mustaq Ahmed <mustaq@google.com>
Date: Wed Jan 24 17:42:48 2018

Fix clipboard tests with subframes for UserActivationV2

With UserActivationV2, a subframe doesn't see the activation in
parent frame.  This is different from current UserGestureIndicator
based model where the activation state is per renderer.

For the two tests fixed in this CL, the test expectations changes
with the activation model in use.

Bug:  805015 
Change-Id: I47b500e77be291b5a7744d23ccd1e56f315619af
Reviewed-on: https://chromium-review.googlesource.com/881559
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531592}
[modify] https://crrev.com/f99cf39263e7ec4e88eb2ec33e9760638b6907e1/chrome/browser/extensions/content_capabilities_browsertest.cc
[modify] https://crrev.com/f99cf39263e7ec4e88eb2ec33e9760638b6907e1/chrome/browser/extensions/extension_dom_clipboard_apitest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82d707b16ce0511088988948d4c6e1b1a466df11

commit 82d707b16ce0511088988948d4c6e1b1a466df11
Author: Mustaq Ahmed <mustaq@google.com>
Date: Tue Jun 19 14:13:57 2018

[UAv2] Add a virtual suite for fullscreen/

Bug:  805015 
Change-Id: Ic066f3f7d939b5175ed19b6d710f343475fba7a8
Reviewed-on: https://chromium-review.googlesource.com/1100944
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568439}
[modify] https://crrev.com/82d707b16ce0511088988948d4c6e1b1a466df11/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/82d707b16ce0511088988948d4c6e1b1a466df11/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/82d707b16ce0511088988948d4c6e1b1a466df11/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.txt
[modify] https://crrev.com/82d707b16ce0511088988948d4c6e1b1a466df11/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-zIndex.html
[add] https://crrev.com/82d707b16ce0511088988948d4c6e1b1a466df11/third_party/WebKit/LayoutTests/virtual/user-activation-v2/fullscreen/README.txt
[add] https://crrev.com/82d707b16ce0511088988948d4c6e1b1a466df11/third_party/WebKit/LayoutTests/virtual/user-activation-v2/fullscreen/full-screen-iframe-zIndex-expected.html
[add] https://crrev.com/82d707b16ce0511088988948d4c6e1b1a466df11/third_party/WebKit/LayoutTests/virtual/user-activation-v2/fullscreen/full-screen-iframe-zIndex-expected.txt
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11d4958ce6ed7da6eb5cb07cf95583cf87bf4707

commit 11d4958ce6ed7da6eb5cb07cf95583cf87bf4707
Author: Mustaq Ahmed <mustaq@google.com>
Date: Tue Jun 19 15:18:51 2018

UAv2: Add a virtual suite for fast/dom/Window

Also fix window-postMessage-user-gesture.html expectation for UAv2.

Bug:  805015 
Change-Id: I669a5b01c3c0862a511978a9ec8d56a813ccfa77
Reviewed-on: https://chromium-review.googlesource.com/1104702
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568455}
[modify] https://crrev.com/11d4958ce6ed7da6eb5cb07cf95583cf87bf4707/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/11d4958ce6ed7da6eb5cb07cf95583cf87bf4707/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/11d4958ce6ed7da6eb5cb07cf95583cf87bf4707/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-user-gesture-expected.txt
[modify] https://crrev.com/11d4958ce6ed7da6eb5cb07cf95583cf87bf4707/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-user-gesture.html
[add] https://crrev.com/11d4958ce6ed7da6eb5cb07cf95583cf87bf4707/third_party/WebKit/LayoutTests/virtual/user-activation-v2/fast/dom/Window/README.txt
[add] https://crrev.com/11d4958ce6ed7da6eb5cb07cf95583cf87bf4707/third_party/WebKit/LayoutTests/virtual/user-activation-v2/fast/dom/Window/window-postmessage-user-gesture-expected.txt
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ffcedf7f55d18a36019f07567c16442f5109499

commit 6ffcedf7f55d18a36019f07567c16442f5109499
Author: Mustaq Ahmed <mustaq@google.com>
Date: Thu Jun 21 14:39:25 2018

[UAv2] Change activated frame in WebClipboardImplTest.ImageCopy

Bug:  805015 
Change-Id: I9b9c8ee0071707220ec9ad1f7966816b055cf655
Reviewed-on: https://chromium-review.googlesource.com/1108438
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569257}
[modify] https://crrev.com/6ffcedf7f55d18a36019f07567c16442f5109499/content/renderer/webclipboard_impl_browsertest.cc

Comment 7 by mustaq@chromium.org, Jul 5

Status: Fixed (was: Assigned)
All tests caused by subframe-not-seeing-top-frame-activation has been fixed.
►

Sign in to add a comment