A new base container for the TableView is needed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/858fc7309e165e71715845903b196ea3108c5a62 commit 858fc7309e165e71715845903b196ea3108c5a62 Author: sczs <sczs@chromium.org> Date: Thu Feb 15 01:04:52 2018 [ios] Prepares for new RecentTabsVC creation. - Creates a RecentTabsTableViewController constants file. - Creates a file for RecentTabsTableViewControllerDelegate protocol. - Creates Protocol RecentTabsTableViewControllerInterface, this includes all the public RecentTabsTableViewController methods. - Renames RecentTabsTableViewController to LegacyRecentTabsTableViewController. - Small cleanup of unused imports. Bug: 805013 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie682653c2154e22776b0e991db56d52f6d5aab20 Reviewed-on: https://chromium-review.googlesource.com/896923 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536913} [modify] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn [modify] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/closed_tabs_observer_bridge.mm [rename] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_coordinator.h [rename] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_coordinator.mm [add] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller.h [rename] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller.mm [add] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/legacy_recent_tabs_table_view_controller_delegate.h [add] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_constants.h [add] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_constants.mm [modify] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.mm [modify] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.mm [modify] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator_unittest.mm [modify] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_egtest.mm [delete] https://crrev.com/73354fbe5e76202f898b02c5bcdfc4c5782a55be/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.h [add] https://crrev.com/858fc7309e165e71715845903b196ea3108c5a62/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller_interface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db9e6a960a8f807ab7e201f9fb2ee4092adf47bd commit db9e6a960a8f807ab7e201f9fb2ee4092adf47bd Author: sczs <sczs@chromium.org> Date: Thu Feb 15 01:31:19 2018 [ios] Creates Recent Tabs UI Reboot Feature flag. Bug: 805013 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0b9ed58466af7b0c7ea092d8210683ba510502d4 Reviewed-on: https://chromium-review.googlesource.com/916808 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536917} [modify] https://crrev.com/db9e6a960a8f807ab7e201f9fb2ee4092adf47bd/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/db9e6a960a8f807ab7e201f9fb2ee4092adf47bd/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/db9e6a960a8f807ab7e201f9fb2ee4092adf47bd/ios/chrome/browser/experimental_flags.h [modify] https://crrev.com/db9e6a960a8f807ab7e201f9fb2ee4092adf47bd/ios/chrome/browser/experimental_flags.mm [modify] https://crrev.com/db9e6a960a8f807ab7e201f9fb2ee4092adf47bd/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/db9e6a960a8f807ab7e201f9fb2ee4092adf47bd/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/db9e6a960a8f807ab7e201f9fb2ee4092adf47bd/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn [add] https://crrev.com/db9e6a960a8f807ab7e201f9fb2ee4092adf47bd/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_feature.h [add] https://crrev.com/db9e6a960a8f807ab7e201f9fb2ee4092adf47bd/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_feature.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3eb89f2982e8c73691b02a0765a82f2aff2d0631 commit 3eb89f2982e8c73691b02a0765a82f2aff2d0631 Author: sczs <sczs@chromium.org> Date: Tue Feb 20 17:12:20 2018 [ios] Creates TableContainerViewController. Creates a TableContainerViewController that contains a ChromeTableViewController. Adds it to showcase. Screenshot: https://drive.google.com/open?id=1kCC5xDoreepzp2Y-uQmVUxMUP_Vae_Y_ Bug: 805013 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5f5d58eab32a8c13cbcc8ed32f4a6d5cbc7b7598 Reviewed-on: https://chromium-review.googlesource.com/923408 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#537805} [modify] https://crrev.com/3eb89f2982e8c73691b02a0765a82f2aff2d0631/ios/chrome/browser/ui/table_view/BUILD.gn [add] https://crrev.com/3eb89f2982e8c73691b02a0765a82f2aff2d0631/ios/chrome/browser/ui/table_view/table_container_view_controller.h [add] https://crrev.com/3eb89f2982e8c73691b02a0765a82f2aff2d0631/ios/chrome/browser/ui/table_view/table_container_view_controller.mm [modify] https://crrev.com/3eb89f2982e8c73691b02a0765a82f2aff2d0631/ios/showcase/BUILD.gn [modify] https://crrev.com/3eb89f2982e8c73691b02a0765a82f2aff2d0631/ios/showcase/core/showcase_model.mm [add] https://crrev.com/3eb89f2982e8c73691b02a0765a82f2aff2d0631/ios/showcase/table_view/BUILD.gn [add] https://crrev.com/3eb89f2982e8c73691b02a0765a82f2aff2d0631/ios/showcase/table_view/sc_table_container_coordinator.h [add] https://crrev.com/3eb89f2982e8c73691b02a0765a82f2aff2d0631/ios/showcase/table_view/sc_table_container_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5a10ca99bba7af656c060522ad01137d4b97d13 commit c5a10ca99bba7af656c060522ad01137d4b97d13 Author: sczs <sczs@chromium.org> Date: Thu Feb 22 17:45:59 2018 [ios] Creates RecentTabs UIReboot Coordinator - Creates a new RecentTabsTableCoordinator class, which manages a ChromeTableVC inside a navigation controller. - Starts an instance of RecentTabsTableCoordinator behind the RecentTabsUIReboot flag. - Adds a "Done" button to TableContainerViewController. - TableContainerViewController only adds the BottomToolbar to the hierarchy if it has been previously set. Screenshoot with flag enabled after tapping on ToolsMenu Recent Tabs: https://drive.google.com/open?id=1HIGKOg8SEZNDdyo7jwPWXoXGqyfTFtHD Bug: 805013 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia9caa765aebed841aa689d31e263cb5ebaa3a743 Reviewed-on: https://chromium-review.googlesource.com/927692 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#538476} [modify] https://crrev.com/c5a10ca99bba7af656c060522ad01137d4b97d13/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/c5a10ca99bba7af656c060522ad01137d4b97d13/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn [add] https://crrev.com/c5a10ca99bba7af656c060522ad01137d4b97d13/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.h [add] https://crrev.com/c5a10ca99bba7af656c060522ad01137d4b97d13/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.mm [modify] https://crrev.com/c5a10ca99bba7af656c060522ad01137d4b97d13/ios/chrome/browser/ui/table_view/BUILD.gn [modify] https://crrev.com/c5a10ca99bba7af656c060522ad01137d4b97d13/ios/chrome/browser/ui/table_view/table_container_view_controller.h [modify] https://crrev.com/c5a10ca99bba7af656c060522ad01137d4b97d13/ios/chrome/browser/ui/table_view/table_container_view_controller.mm [modify] https://crrev.com/c5a10ca99bba7af656c060522ad01137d4b97d13/ios/showcase/table_view/sc_table_container_coordinator.mm
The NextAction date has arrived: 2018-02-28
The base base Class will need some Toolbar support later on. But its now complete for Recent Tabs
The NextAction date has arrived: 2018-03-14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/977cd5be66e4e9a50d0d4e69480c6984ddd855f7 commit 977cd5be66e4e9a50d0d4e69480c6984ddd855f7 Author: Rohit Rao <rohitrao@chromium.org> Date: Wed Apr 18 16:22:01 2018 [ios] Converts TableContainerViewController into a UINavigationController. The custom bottom toolbar is removed in favor of the toolbar already built into UINavigationController. Showcase support is removed because this container is no longer materially different from a stock UINavigationController. BUG= 805013 , 805201 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib8e78793ea73c411ad8c72cabe18568c4cb71840 Reviewed-on: https://chromium-review.googlesource.com/1015541 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551709} [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/history/history_coordinator.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/history/history_table_container_view_controller.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/history/history_table_view_controller.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/table_view/BUILD.gn [delete] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/ios/chrome/browser/ui/table_view/table_container_bottom_toolbar.h [delete] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/ios/chrome/browser/ui/table_view/table_container_bottom_toolbar.mm [delete] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/ios/chrome/browser/ui/table_view/table_container_bottom_toolbar_unittest.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/table_view/table_container_view_controller.h [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/chrome/browser/ui/table_view/table_container_view_controller.mm [modify] https://crrev.com/977cd5be66e4e9a50d0d4e69480c6984ddd855f7/ios/showcase/BUILD.gn [delete] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/ios/showcase/table_view/BUILD.gn [delete] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/ios/showcase/table_view/sc_table_container_coordinator.h [delete] https://crrev.com/e674ba807e4349f7369195c37d125cebbf5677c6/ios/showcase/table_view/sc_table_container_coordinator.mm
Comment 1 by sczs@chromium.org
, Jan 23 2018