New issue
Advanced search Search tips

Issue 805008 link

Starred by 1 user
Status: Fixed
Owner:
robertma@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

`webkit-patch optimize-baselines` fails assertion in _find_in_search_path

Project Member Reported by robertma@chromium.org, Jan 23 2018 
https://crrev.com/c/747322 left a rare edge case:

Suppose Linux -> Windows -> Generic
Before optimization, both Linux and Windows have all-PASS testharness.js baselines.

Linux is optimized first. During the traversal of its fallback path, two all-PASS baselines are found and removed. WAI.

Yet when processing Windows next, the optimizer cannot find the index of Windows' baseline on the fallback path (because Windows' baseline has been removed), hence raising assertion error.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50fdca86171b6308e20a79ab39770e0035d5aef9

commit 50fdca86171b6308e20a79ab39770e0035d5aef9
Author: Robert Ma <robertma@chromium.org>
Date: Wed Jan 24 17:55:34 2018

[webkitpy] Fix a rare edge case in baseline optimizer

In _find_in_search_path, when an all-PASS baseline is not found on the
search path, we assume it is an implicit baseline at the root.

This CL also simplifies the code by getting rid of the optional
implicit_all_pass argument, as _find_in_search_path can now handle the
implicit result properly.

Bug:  805008 
Change-Id: I6e06af03cad8f55c9d8ebc73137309c3dc57472e
Reviewed-on: https://chromium-review.googlesource.com/881766
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531600}
[modify] https://crrev.com/50fdca86171b6308e20a79ab39770e0035d5aef9/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer.py
[modify] https://crrev.com/50fdca86171b6308e20a79ab39770e0035d5aef9/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py

Comment 2 by robertma@chromium.org, Jan 24 2018

Status: Fixed (was: Started)
►

Sign in to add a comment