New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 805001 link

Starred by 1 user
Status: Duplicate
Merged: issue 628971
Owner:
dpranke@chromium.org
Closed: Jan 2018
Cc:
█ groby@chromium.org
dpa...@chromium.org
thakis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Can't run Java in MSVC commit bot

Project Member Reported by jrw@google.com, Jan 23 2018 
I'm trying to submit a CL (https://chromium-review.googlesource.com/c/chromium/src/+/783555), but it fails on the MSVC bot because it can't find 'java' in %PATH%.

It's not entirely clear whether running a Java program during a Windows build is supposed to work.  On one hand, it works on all the other Windows bots, and it's necessary for the change I'm trying to land.  OTOH, the instructions for building on Windows (https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md) don't say anything about Java, so I'm concerned my change might make Java a dependency for Windows builds when it wasn't before.

Comment 1 by jrw@google.com, Jan 23 2018 

I was just told by jan@kivu.tech that I should be executing %JAVA_HOME%\bin\java.  If that's correct, then perhaps the best way to handle this issue would be to update the documentation for building on Windows.  WDYT?

Comment 2 by dpranke@chromium.org, Jan 23 2018

Cc: groby@chromium.org thakis@chromium.org dpa...@chromium.org
Components: -Infra Build UI>Browser>WebUI
Labels: -Restrict-View-Google -Infra-Troopers
Owner: dpranke@chromium.org
As I just replied on chromium-dev@, this isn't supposed to work, and I wouldn't actually expect it to work on *any* windows bot. 

I think the primary question here is: what's our expectation around using Closure for WebUI these days? Can we make this work with the node-based version of Closure? Or should we be avoiding Closure? Or should we just give up and make java be available everywhere?

Comment 3 by thakis@chromium.org, Jan 23 2018 

Java isn't supposed to work on Mac and Linux either. I feel strongly that we shouldn't add deps on yet more languages.

Comment 4 by thakis@chromium.org, Jan 23 2018

Status: WontFix (was: Untriaged)

Comment 5 by dpranke@chromium.org, Jan 23 2018

Status: Available (was: WontFix)
You don't get to WontFix this just yet, given that there's likely a real product need and given that we already have patterns of using closure in other cases.

Either we need to decide to *not* do it everywhere, or to allow it everywhere. Currently the situation is confusing.

Comment 6 by dpranke@chromium.org, Jan 23 2018 

whoops, forgot the :).

Comment 7 by dpranke@chromium.org, Jan 23 2018

Mergedinto: 628971
Status: Duplicate (was: Available)
De-duping into  bug 628971 .
►

Sign in to add a comment