Investigate pdf open numbers |
|||
Issue descriptionFor the PDF opens, do we count print display in that number or is it purely PDF files viewed?
,
Jan 24 2018
If yes, then there is PDFMetricsImpl for the regular PDF viewer and PDFMetricsDummy for print preview.
,
Jan 24 2018
Lei or Henrique, do you know if the metrics we collect in OutOfProcessInstance::DocumentLoadComplete include the print PDFs? Specific metrics: PDF.PageCount PDF.HasAttachment PDF.IsLinearized PDF.IsTagged PDF.FormType
,
Jan 24 2018
,
Jan 24 2018
Yes, they should. See OutOfProcessInstance::DocumentLoadComplete(). It has a branch to do special things in print preview, but metrics logging is outside.
,
Jan 24 2018
Marking this fixed, since it sounds like all of the metrics that we were concerned about are already being properly filtered for being non-print PDFs.
,
Jan 24 2018
Sorry, I was not clear. I mean they are logged for both print preview and the pdf viewer. Do we want to change that?
,
Jan 24 2018
Actually the print previews are not included in logs. Even though that code does run, the helper methods called for logging (HistogramCustomCounts, HistogramEnumeration) do not do anything if it's print preview. Therefore, our numbers are right, they are just for the actual PDF viewer. Also verified this empirically looking at chrome://histograms. |
|||
►
Sign in to add a comment |
|||
Comment 1 by thestig@chromium.org
, Jan 24 2018