New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804996 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 800984



Sign in to add a comment

dev-util/ragel fails to build with llvm-next

Project Member Reported by rahulchaudhry@chromium.org, Jan 23 2018

Issue description

This happens when testing the next version of llvm: https://bugs.chromium.org/p/chromium/issues/detail?id=800984

In the host sdk, dev-util/ragel build fails with new errors from [-Wc++11-narrowing]:

common.cpp:37:70: error: constant expression evaluates to 18446744073709551615 which cannot be narrowed to type 'long long' [-Wc++11-narrowing]
        { "unsigned", "long",  "ulong",   false,  true,  false,  0,         ULONG_MAX,  sizeof(unsigned long) }
                                                                            ^~~~~~~~~
/usr/lib64/clang/6.0.0/include/limits.h:73:19: note: expanded from macro 'ULONG_MAX'
#define ULONG_MAX (__LONG_MAX__ *2UL+1UL)
                  ^~~~~~~~~~~~~~~~~~~~~~~
common.cpp:37:70: note: insert an explicit cast to silence this issue
        { "unsigned", "long",  "ulong",   false,  true,  false,  0,         ULONG_MAX,  sizeof(unsigned long) }
                                                                            ^~~~~~~~~
                                                                            static_cast<long long>( )
/usr/lib64/clang/6.0.0/include/limits.h:73:19: note: expanded from macro 'ULONG_MAX'
#define ULONG_MAX (__LONG_MAX__ *2UL+1UL)
                  ^~~~~~~~~~~~~~~~~~~~~~~
common.cpp:117:64: error: constant expression evaluates to 18446744073709551615 which cannot be narrowed to type 'long long' [-Wc++11-narrowing]
        { "ulong",   0,  "ulong",   false,  true,  false,  0,         ULONG_MAX,   8 }
                                                                      ^~~~~~~~~
/usr/lib64/clang/6.0.0/include/limits.h:73:19: note: expanded from macro 'ULONG_MAX'
#define ULONG_MAX (__LONG_MAX__ *2UL+1UL)
                  ^~~~~~~~~~~~~~~~~~~~~~~
common.cpp:117:64: note: insert an explicit cast to silence this issue
        { "ulong",   0,  "ulong",   false,  true,  false,  0,         ULONG_MAX,   8 }
                                                                      ^~~~~~~~~
                                                                      static_cast<long long>( )
/usr/lib64/clang/6.0.0/include/limits.h:73:19: note: expanded from macro 'ULONG_MAX'
#define ULONG_MAX (__LONG_MAX__ *2UL+1UL)
                  ^~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8467a779afc3425766762830ec851554e6e9e9cc

commit 8467a779afc3425766762830ec851554e6e9e9cc
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Thu Jan 25 08:15:50 2018

dev-util/ragel: fix build issue with llvm-next.

BUG= chromium:804996 
TEST='sudo emerge dev-util/ragel' works with llvm-next.

Change-Id: I5fee9dcfff914a10c1c39383b84431ccf3b10ee2
Reviewed-on: https://chromium-review.googlesource.com/882141
Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/8467a779afc3425766762830ec851554e6e9e9cc/dev-util/ragel/ragel-6.7-r4.ebuild
[add] https://crrev.com/8467a779afc3425766762830ec851554e6e9e9cc/dev-util/ragel/files/ragel-6.7-narrowing.patch
[delete] https://crrev.com/b9cad0a7c85c6740cac185609b3619d681a12a9f/dev-util/ragel/ragel-6.7-r3.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/77a4e26efca2693d68481768d6c95ce74cc2e84a

commit 77a4e26efca2693d68481768d6c95ce74cc2e84a
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Jan 26 03:23:38 2018

dev-util/ragel: add ragel-6.10 ebuild from gentoo.

The ebuild is from:
  https://gitweb.gentoo.org/repo/gentoo.git/plain/dev-util/ragel/ragel-6.10.ebuild
with one change:
  KEYWORDS="*"

BUG= chromium:804996 
BUG= chromium:805004 
TEST='sudo emerge dev-util/ragel' works.

Change-Id: I19defb380df1650e0b385eacd0febb3b92b9370b
Reviewed-on: https://chromium-review.googlesource.com/884501
Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/77a4e26efca2693d68481768d6c95ce74cc2e84a/dev-util/ragel/Manifest
[add] https://crrev.com/77a4e26efca2693d68481768d6c95ce74cc2e84a/dev-util/ragel/ragel-6.10.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 26 2018

Status: Fixed (was: Assigned)

Sign in to add a comment