VR omnibox: URL bar icons are too big |
|||||||||||||
Issue descriptionAs of ToT, the icons on the VR URL bar appear too large. This seems due to a discrepancy in spec: The UX spec is based on material design, whereas Chrome uses its own vector icons. We should adjust the UX spec to refer to the icons we use. Short term, I will adjust the sizes manually to lessen the visibility of the discrepancy.
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e08ec484fe160a1002fa9c8beae340413f0eaba commit 8e08ec484fe160a1002fa9c8beae340413f0eaba Author: Christopher Grant <cjgrant@chromium.org> Date: Wed Jan 24 16:23:53 2018 VR: Adjust URL bar icon size and position to look more like the spec Note that the spec is based on different icons, so if we incorporate the spec verbatim, the icons look too large. This change attempts to visually match the spec, and we can circle back if the spec is updated. BUG= 804988 R=ymalik Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaec15827fa2178f66c39e409baedd3560a1eb4de Reviewed-on: https://chromium-review.googlesource.com/881557 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#531546} [modify] https://crrev.com/8e08ec484fe160a1002fa9c8beae340413f0eaba/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/8e08ec484fe160a1002fa9c8beae340413f0eaba/chrome/browser/vr/ui_scene_creator.cc
,
Jan 24 2018
,
Jan 25 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2018
Please note that this CL conflicts with another CL that is not slated for M-65, and as such, I don't think we should merge it.
,
Jan 25 2018
,
Jan 31 2018
Now deemed necessary for M-65. Re-requesting merge (that was previously auto-approved).
,
Feb 1 2018
CC'ing amineer@ in relation to the merge request.
,
Feb 1 2018
cmasso@ is owner for Android M65 per go/chromeschedule, routing to her.
,
Feb 1 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f616c555d222f710c22e125698130d215a4d2dc commit 4f616c555d222f710c22e125698130d215a4d2dc Author: Christopher Grant <cjgrant@chromium.org> Date: Fri Feb 02 14:58:37 2018 VR: Adjust URL bar icon size and position to look more like the spec Note that the spec is based on different icons, so if we incorporate the spec verbatim, the icons look too large. This change attempts to visually match the spec, and we can circle back if the spec is updated. BUG= 804988 R=ymalik TBR=cjgrant@chromium.org (cherry picked from commit 8e08ec484fe160a1002fa9c8beae340413f0eaba) Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaec15827fa2178f66c39e409baedd3560a1eb4de Reviewed-on: https://chromium-review.googlesource.com/881557 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531546} Reviewed-on: https://chromium-review.googlesource.com/899045 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#258} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/4f616c555d222f710c22e125698130d215a4d2dc/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/4f616c555d222f710c22e125698130d215a4d2dc/chrome/browser/vr/ui_scene_creator.cc
,
Feb 7 2018
,
Feb 7 2018
,
Feb 14 2018
This is covered in the Manual tests, we are viewing and verifying the entire UI during each test. Will encourage QA to identify these types of issues in the future. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by cjgrant@chromium.org
, Jan 24 2018