Update strings for fine-grained timezone |
|||||||
Issue descriptionThe strings in the screenshot should be replaced with the ones in doc https://docs.google.com/document/d/1T-5TupfCSvU2AWTnThMotDKkP_FJexpajCt7I3NvLs4/edit Namely, 1) Set automatically using your general location (default) => Use your IP address to determine location (default) 2) Set automatically using your accurate location => Use Wi-Fi or mobile networks to determine location +Tom, I noticed in the code base that there's another string: Set automatically using your WiFi network Should this be replace by something else as well?
,
Jan 26 2018
,
Jan 26 2018
,
Jan 27 2018
For "Set automatically using your WiFi network", please use "Use only Wi-Fi to determine location" instead.
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec7b1be56aaf98872140bdeb74c1e18f0027c33e commit ec7b1be56aaf98872140bdeb74c1e18f0027c33e Author: Wenzhao Zang <wzang@chromium.org> Date: Sat Jan 27 07:37:13 2018 cros: Update strings for fine-grained timezone TBR=rockot@chromium.org Bug: 804986 Change-Id: I4b16892cfe7705d4a5d6dd82ccba8de176283ca2 Reviewed-on: https://chromium-review.googlesource.com/889647 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#532189} [modify] https://crrev.com/ec7b1be56aaf98872140bdeb74c1e18f0027c33e/chrome/app/settings_strings.grdp
,
Jan 27 2018
,
Jan 27 2018
,
Jan 28 2018
This bug requires manual review: There is .grd file changes and we are only 36 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 29 2018
We are only taking string changes in critical scenarios, I am not sure that this is critical at this point so perhaps this string change can wait until 66? |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by wzang@chromium.org
, Jan 25 2018