Chrome should respect PackageManager.FEATURE_APP_WIDGETS |
|||
Issue descriptionSee b/71994176. Standalone VR devices (ie https://vr.google.com/daydream/standalonevr/) don't always support app widgets, and so the app widget service may not be running on these types of devices. Chrome currently assumes AppWidgetManager.getInstance() will never return null, and so it crashes when the service isn't running. Since JB MR2, PackageManager().hasSystemFeature(PackageManager.FEATURE_APP_WIDGETS) has been available to check whether or not the system supports app widgets, so we should respect that feature flag and not try to use the AppWidgetManager when app widgets are disabled.
,
Feb 7 2018
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c30d6be5a6e44af26db8b15be6eaf0c30198dd76 commit c30d6be5a6e44af26db8b15be6eaf0c30198dd76 Author: Ted Choc <tedchoc@google.com> Date: Wed Feb 07 18:00:55 2018 [Android] Check for FEATURE_APP_WIDGETS before triggering widget code. BUG= 804983 Change-Id: I2551108ac4d2b368c1c60713aee42bac16de59b5 Reviewed-on: https://chromium-review.googlesource.com/905802 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#535056} [modify] https://crrev.com/c30d6be5a6e44af26db8b15be6eaf0c30198dd76/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProvider.java [modify] https://crrev.com/c30d6be5a6e44af26db8b15be6eaf0c30198dd76/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
,
Feb 7 2018
I believe fixed...no way to verify, but probably better than it was before. Will need the internal bug filers to check.
,
Feb 7 2018
Thanks Ted, I'll let them know it's fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by mthiesse@chromium.org
, Jan 23 2018