Overview no window indicator on multi display. |
|||
Issue descriptionFor the new "no recent items" display for overview mode in https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZUWrnnKPdEix/files/MCHhKeApidC1DpQFVMbZJTQPwMSJbxAVNpw, what should the behaviour be like on multi display?
,
Jan 24 2018
Yes, on multi-display, each display has a window grid. The windows associated with each display are shown on that grid, and only that grid. The text box is always on the primary display, even if the primary display has no windows for overview, but highlights windows across all grids. If we enter overview mode currently without some windows, there is no background (no blurred background and shield). In tablet mode, multi display is not supported (extra displays become mirrors), so this is not a problem. I'll add the "no recent items" on the primary display for now, and add the blurred background and shield for displays with no windows. We'll see if any other cases pop up.
,
Jan 24 2018
Awesome, thanks Sammie! And thanks for the explanation.
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2 commit 05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2 Author: Sammie Quon <sammiequon@google.com> Date: Thu Mar 22 01:03:08 2018 overview: Modify how multi display overview works for new ui. "No recent items" only shows up on the primary window grid now. If all the windows on a grid are closed, the grid is still kept alive until all windows on all grids are closed, so that the wallpaper blur and opacity change are still seen. Previously, the grid would destroy as soon as all its items were closed, removing the blur and fade from that display, but the system was still in overview mode because another grid was active. If old UI is enabled, the behaviour is unchanged. Test: WindowSelectorTest.OverviewNoWindowsIndicatorMultiDisplay Bug: 804979 Change-Id: I2ed9d4d13301a14ddf7a2ed39a299a5b8183eb2f Reviewed-on: https://chromium-review.googlesource.com/967367 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#544931} [modify] https://crrev.com/05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2/ash/wm/overview/window_grid.cc [modify] https://crrev.com/05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2/ash/wm/overview/window_grid.h [modify] https://crrev.com/05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2/ash/wm/overview/window_selector.cc [modify] https://crrev.com/05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/05e32b12a408b22f5fd5ecd036fbc541b8ffb8b2/testing/buildbot/filters/mash.ash_unittests.filter
,
Mar 23 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mccanny@chromium.org
, Jan 23 2018