New issue
Advanced search Search tips

Issue 804966 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner: ----
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Automatically modify extension icons when "invisible"

Project Member Reported by pkasting@chromium.org, Jan 23 2018

Issue description

Malicious extensions sometimes try to make their icons blend against the toolbar/menu so users don't see them and don't realize they can right-click and remove them.

We should try to detect this case and modify the icon programmatically to increase visibility.  I don't know precisely how to do this; look for "sufficient area of sufficient contrast" and if it doesn't exist, either luma-invert the icon (if that will help enough) or badge/replace it?

We have helper functions to compute the contrast of two colors or the luma inversion of a color, but working with whole images/regions is a different story.  Maybe some of the accessibility folks know of relevant recommendations for if imagery is "easy enough to spot".
 
Instead of playing the game of "how to measure transparency/contrast", why not draw some pixels (Chrome UI) around or near the icon that can't be controlled by the extension author? So it doesn't matter what the icon is, even if it's completely transparent? Could be as simple as a black border? Or some kind of tasteful drop-shadow or button effect?

That would avoid the challenge of detecting visibility, but it has some downsides:

* Just drawing a border says "there's something here", but not what it is; things can still look broken/unintuitive.  Luma inversion or using a default extension icon make it much clearer that "this is an extension".
* Something like luma inversion could help non-malicious cases, too: if the user has installed a custom theme and the extension's icon is not visible over that theme's toolbar color, this can "fix" the problem automatically.
* None of the rest of Chrome's toolbar uses such effects, and in general icon buttons in Chrome don't have borders, so either we'd have to live with extensions looking like a Win 95 effect dropped into a Win 10 world, or we'd need to redesign our UI language; neither course is very appealing.

Comment 3 by jawag@chromium.org, Feb 7 2018

Components: -UI>Browser>ExtensionsManagement Platform>Extensions
Mergedinto: 805600
Status: Duplicate (was: Untriaged)
Sorry Peter, didn't see this before I filed issue 805600.  Merging into that one to continue the discussion, but I'm very interested in your thoughts there.

Sign in to add a comment