New issue
Advanced search Search tips

Issue 804957 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 268640



Sign in to add a comment

XSDB should also apply to filesystem URIs

Project Member Reported by lukasza@chromium.org, Jan 23 2018

Issue description

Currently we in CrossSiteDocumentResourceHandler::ShouldBlockBasedOnHeaders:

  // Only block documents from HTTP(S) schemes.
  if (!CrossSiteDocumentClassifier::IsBlockableScheme(url))
    return false;

We should change that to something like:

  // Only block documents from HTTP(S) origins.
  if (!CrossSiteDocumentClassifier::IsBlockableScheme(response_origin))
    return false;

This will ensure that XSDB can also protect filesystem URIs.
 
Status: Started (was: Assigned)
WIP CL: https://chromium-review.googlesource.com/#/c/chromium/src/+/882450
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4b5dc98979065d5cd03a8bdbfa9a509223b7da0

commit e4b5dc98979065d5cd03a8bdbfa9a509223b7da0
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Thu Jan 25 17:54:40 2018

XSDB should also protect filesystem:... and blob:... URIs.

Bug:  804957 
Change-Id: I2d2cccf2e77ad44305af1601e52c6ae80e062d7d
Reviewed-on: https://chromium-review.googlesource.com/882450
Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531936}
[modify] https://crrev.com/e4b5dc98979065d5cd03a8bdbfa9a509223b7da0/content/browser/loader/cross_site_document_resource_handler.cc
[modify] https://crrev.com/e4b5dc98979065d5cd03a8bdbfa9a509223b7da0/content/browser/loader/cross_site_document_resource_handler_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment