New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804954 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 268640



Sign in to add a comment

XSDB shouldn't "block" empty responses

Project Member Reported by lukasza@chromium.org, Jan 23 2018

Issue description

To minimize reporting noise (in javascript console, in UMA and UKM data) XSDB shouldn't "block" *empty* responses (not just empty 204s, but also empty 200s and other http responses).
 
Cc: nick@chromium.org
An alternative would be to log Content-Length (or just a boolean, WasContentLengthZero) in UKM.
See also  issue 808205  which seems to say that empty responses need to be "blocked".
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80693a3b5a96e9e390bafb401cd46a0feb0a61fd

commit 80693a3b5a96e9e390bafb401cd46a0feb0a61fd
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Mon Feb 12 22:38:27 2018

XSDB: Log SiteIsolation.XSD.Browser.Blocked.ContentLength.* UMA metrics.

Bug:  804954 
Change-Id: I7991532d963f92aed50d92cc6492077a251a8b44
Reviewed-on: https://chromium-review.googlesource.com/907732
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536219}
[modify] https://crrev.com/80693a3b5a96e9e390bafb401cd46a0feb0a61fd/content/browser/loader/cross_site_document_blocking_browsertest.cc
[modify] https://crrev.com/80693a3b5a96e9e390bafb401cd46a0feb0a61fd/content/browser/loader/cross_site_document_resource_handler.cc
[modify] https://crrev.com/80693a3b5a96e9e390bafb401cd46a0feb0a61fd/content/browser/loader/cross_site_document_resource_handler.h
[modify] https://crrev.com/80693a3b5a96e9e390bafb401cd46a0feb0a61fd/content/browser/loader/cross_site_document_resource_handler_unittest.cc
[modify] https://crrev.com/80693a3b5a96e9e390bafb401cd46a0feb0a61fd/content/test/data/site_isolation/nosniff.json-prefixed.js.mock-http-headers
[modify] https://crrev.com/80693a3b5a96e9e390bafb401cd46a0feb0a61fd/content/test/data/site_isolation/nosniff.json.js.mock-http-headers
[modify] https://crrev.com/80693a3b5a96e9e390bafb401cd46a0feb0a61fd/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef97565083ddfd89acd1c63ea1c4557d752fdd66

commit ef97565083ddfd89acd1c63ea1c4557d752fdd66
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Thu Feb 22 16:54:50 2018

XSDB: Add ContentLengthWasZero to UKM data

Bug:  804954 
Change-Id: I4a6234c9ca9776e4b4885073bbfb3f0802e64e93
Reviewed-on: https://chromium-review.googlesource.com/920421
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538456}
[modify] https://crrev.com/ef97565083ddfd89acd1c63ea1c4557d752fdd66/content/browser/loader/cross_site_document_resource_handler.cc
[modify] https://crrev.com/ef97565083ddfd89acd1c63ea1c4557d752fdd66/tools/metrics/ukm/ukm.xml

Status: Fixed (was: Assigned)
I think gathering the data on Content-Length should be sufficient to mark this bug as fixed.  Also note that even responses with an empty body need to be "blocked" by stripping down their non-safelisted-headers.

Sign in to add a comment