New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804929 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Pinpoint identifying multiple issues for regressions when some don't contribute

Project Member Reported by donnd@google.com, Jan 23 2018

Issue description

It looks like Pinpoint is identifying multiple issues for performance regressions when some are minimally involved or not involved.

For example,  issue 804316  identifies a memory regression and implicates multiple CLs including my CL https://chromium-review.googlesource.com/871497, but I'm pretty sure this CL is not affecting memory.  

Maybe there's a bug in Pinpoint with multiple CLs?  At the very least, the handling of performance issues with multiple causes seems like it could be improved.  It looks like the performance issue ends up being assigned to the owner of the last cause-CL, but it would be better to assign it to the owner of the cause-CL with highest impact.  Also wouldn't it be better to issue multiple performance bugs, one for each cause?  Until till then, maybe add instructions indicating that all cause-CLs need to be addressed (assuming they do all cause a negative impact)?

 Issue 804319  is another example of how this issue can cause confusion and difficulty addressing the underlying cause(s).
 

Comment 1 by benhenry@google.com, Jan 23 2018

Cc: simonhatch@chromium.org
Labels: -Type-Bug -Pri-3 Pri-2 Type-Feature
Owner: dtu@chromium.org
Status: Assigned (was: Untriaged)
There is a bug and a feature request in this. Assigning to Dave to figure out how to prioritize.

Comment 3 by dtu@chromium.org, Jan 23 2018

Status: WontFix (was: Assigned)
Thanks for the bug report! I'm putting up a fix today for the "too many culprits" bug.

I'm going to close this bug since we are tracking Pinpoint bugs in Github.

Sign in to add a comment