SUBRESOURCE_FILTER threat type metadata should support smaller kv pairs |
||
Issue descriptionTo improve memory performance for Google Play Services, it might be worthwhile to change our metadata scheme towards short, 1byte long metadata entries. This has the benefit of reducing bandwidth and memory consumption. Current metadata: keys: "sf_absv", "sf_bas" values: "", "warn" I would propose that we just move "sf_absv" -> "a" "sf_bas" -> "b" A separate change will stop syncing "warn" values on Android at all. Varun, William: What do you think?
,
Jan 23 2018
Is the memory impact of the full list + metadata only realized when there is a hit? I'm not 100% sure of how the lookup works on Android.
,
Jan 24 2018
As nparker pointed out in a separate thread, indeed the metadata is not persistent in RAM until the full hash response is sent. It does help with bandwidth though. So this bug is probably lower priority.
,
Jan 24 2018
I commented on the bug about why I am not convinced about this change. > As nparker pointed out in a separate thread What thread is that? Can you please post a link here? Thanks.
,
Jan 24 2018
Just cc'd you on the thread, sorry about that. Let's WontFix this for now, given your concerns on the CL: https://chromium-review.googlesource.com/c/chromium/src/+/881224 |
||
►
Sign in to add a comment |
||
Comment 1 by williamluh@google.com
, Jan 23 2018