Support compiling with EMSCRIPTEN |
||||
Issue descriptionOne of our clients needs to compile pdfium with EMSCRIPTEN. Specifically, they need changes in base/numerics/safe_math_impl.h, besides defining a new OS_ASMJS macro in build/build_config.h.
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afff0508d704346222ee1c72e598d53e0ff146bc commit afff0508d704346222ee1c72e598d53e0ff146bc Author: Henrique Nakashima <hnakashima@chromium.org> Date: Wed Jan 24 17:14:12 2018 Add asm.js to build_config.h. Bug: 804907 Change-Id: I194c59129cad52b0775181d8582c9529590af74f Reviewed-on: https://chromium-review.googlesource.com/870813 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#531574} [modify] https://crrev.com/afff0508d704346222ee1c72e598d53e0ff146bc/PRESUBMIT.py [modify] https://crrev.com/afff0508d704346222ee1c72e598d53e0ff146bc/build/build_config.h
,
Jan 24 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/f9f1a5dd73b918d50bcd3a4b461b87544260b9f8 commit f9f1a5dd73b918d50bcd3a4b461b87544260b9f8 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Wed Jan 24 22:05:20 2018 Support compiling pdfium with emscripten. Bug: chromium:804907 Change-Id: I3562653fbc26d669d1e0a99894a69da032a0349e Reviewed-on: https://pdfium-review.googlesource.com/23810 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> [modify] https://crrev.com/f9f1a5dd73b918d50bcd3a4b461b87544260b9f8/third_party/base/numerics/safe_math_impl.h
,
Jan 24 2018
Do we need to set up PDFium build bots to continuously test this config?
,
Jan 25 2018
I don't think it's worth it yet, as this is super experimental. When it sees some actual use, we should.
,
Jan 31 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/bb04c59ec30b00cae6c902fa8bc128220bcff4df commit bb04c59ec30b00cae6c902fa8bc128220bcff4df Author: Henrique Nakashima <hnakashima@chromium.org> Date: Wed Jan 31 21:38:34 2018 Roll android_ndk, build, buildtools. Roll DEPS for android_ndk to e951c37287c7d8cd915bf8d4149fd4a06d808b55. https://chromium.googlesource.com/android_ndk/+log/d5752321..e951c372 Roll DEPS for build to b1bf4b84cb5db309fda657ebd19a6c3d2ebdcb66. https://chromium.googlesource.com/chromium/src/build/+log/097c79ba..b1bf4b84 Roll DEPS for buildtools to f115f4786771afdfacb18a2299541b23e21f4792. https://chromium.googlesource.com/chromium/buildtools/+log/b36c7b60..f115f478 The android_ndk version needs to be updated to r16. android_ndk and build cannot be rolled separately. build depends on the buildtools changes. This enables pdfium to be built with emscripten. Bug: chromium:804907 Change-Id: If442e92f2f608ae20b476b9b077111e2596187cf Reviewed-on: https://pdfium-review.googlesource.com/24890 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> [modify] https://crrev.com/bb04c59ec30b00cae6c902fa8bc128220bcff4df/build_overrides/build.gni [modify] https://crrev.com/bb04c59ec30b00cae6c902fa8bc128220bcff4df/DEPS
,
Jan 31 2018
,
Feb 2 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/48b47f48ae6c5e3206bc306f2215a82273d5a313 commit 48b47f48ae6c5e3206bc306f2215a82273d5a313 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Fri Feb 02 16:37:08 2018 Add asm.js to third_party/build/build_config.h. This reflects changes in the build_config.h from chromium/build/src. Bug: chromium:804907 Change-Id: I892bcf3bbf5d260c904f40536fa1f3c9e49a5ac6 Reviewed-on: https://pdfium-review.googlesource.com/25130 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> [modify] https://crrev.com/48b47f48ae6c5e3206bc306f2215a82273d5a313/third_party/build/build_config.h
,
Feb 2 2018
Reopen, need to change core/fxcrt/cfx_datetime.cpp as well.
,
Feb 5 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/1ea9f3f92f2586de844ccbf8f8f2ef3f00aa20fa commit 1ea9f3f92f2586de844ccbf8f8f2ef3f00aa20fa Author: Henrique Nakashima <hnakashima@chromium.org> Date: Mon Feb 05 16:12:00 2018 Include time.h on wasm. Bug: chromium:804907 Change-Id: Id9b496f14134631d3308c073b8780bf18c2305c8 Reviewed-on: https://pdfium-review.googlesource.com/25270 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> [modify] https://crrev.com/1ea9f3f92f2586de844ccbf8f8f2ef3f00aa20fa/core/fxcrt/cfx_datetime.cpp
,
Feb 5 2018
,
Jul 21
Should we revisit the build bots part at some point? |
||||
►
Sign in to add a comment |
||||
Comment 1 by hnakashima@chromium.org
, Jan 23 2018