Extension permissions.request test relies on UGI's expiry |
||
Issue descriptionWith UserActivationV2, we are extending the expiry time, which causes regression with PermissionsApiTest.OptionalPermissionsRetainGesture. In particular, testPermissionsRetainGestureExpire() in https://cs.chromium.org/chromium/src/chrome/test/data/extensions/api_test/permissions/optional_retain_gesture/background.js seems to check UGI's current expiry (1sec) but keeps sending requests after 3 more seconds. Not sure why, perhaps the 1sec expiry expectation is not strong (I recall seeing 10sec expiry too). Anyway, for UserActivationV2, the expiry test looks meaningless.
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7e0e466072ffff46f2f693dd344f43aa3a01ccf commit a7e0e466072ffff46f2f693dd344f43aa3a01ccf Author: Mustaq Ahmed <mustaq@google.com> Date: Mon Jan 29 17:49:23 2018 Get rid of UGI expiry test in extension permission. Reasons for removal: - UserGestureIndicatorTest.Timeouts asserts the same check. - The removed test seems to have a sloppy time expectation. - This is blocking UserActivationV2 (with extended expiry). Bug: 804903 Change-Id: I8960e670772cb4a0bb306206e86a873e1c226f77 Reviewed-on: https://chromium-review.googlesource.com/881523 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#532480} [modify] https://crrev.com/a7e0e466072ffff46f2f693dd344f43aa3a01ccf/chrome/test/data/extensions/api_test/permissions/optional_retain_gesture/background.js
,
Jan 29 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mustaq@chromium.org
, Jan 23 2018