Considering revert crrev.com/c/729220 for M65 and then put it back in ToT.

We'll leave crrev.com/c/729220 in canary and dev channel to gather some feedback. but don't let it in Beta and Stable channel because it breaks embed map.

So, requesting merge a revert of crrev.com/c/729220 into M65.

Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bbdd4eab901375bd535edf9407b83383cdb8def

commit 7bbdd4eab901375bd535edf9407b83383cdb8def
Author: Ella Ge <eirage@chromium.org>
Date: Thu Jan 25 21:01:43 2018

Revert "Disable legacy touch event APIs on desktop"

This CL reverts commit a6a203c9a33449b29f3d98f925a9b61fdf35c2ee.
(crrev.com/c/729220)

We'll leave these feature detection API disabled in canary and
dev channel to gather some feedback. But don't let it in Beta
and Stable channel because it breaks embed map.

Merge this revert into M65

Bug:  804890 
Change-Id: Ib017006081baf12b69fe137ba9aeae915b5274a3
Reviewed-on: https://chromium-review.googlesource.com/886826
Reviewed-by: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#99}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/7bbdd4eab901375bd535edf9407b83383cdb8def/chrome/browser/about_flags.cc
[modify] https://crrev.com/7bbdd4eab901375bd535edf9407b83383cdb8def/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/7bbdd4eab901375bd535edf9407b83383cdb8def/chrome/browser/prefs/chrome_pref_service_unittest.cc
[modify] https://crrev.com/7bbdd4eab901375bd535edf9407b83383cdb8def/content/browser/renderer_host/render_view_host_impl.cc

Can this bug mark as fixed now if nothing is pending?

The issue is still in master branch(and M66). Embed map said their update will be on September. I think we should not mark this bug as fix now. 

I change the tag to M66 now (and updated the issue summary) so it won't affect M65 release. Thanks!

eirage@,
Friendly ping to get an update on this issue as it is marked as release block beta.

Thanks..!

jmukthavaram@, This is marked as M66, it's not blocking M65 release. Thanks

Gentle ping to get an update on this issue as it is marked as beta blocker.

Thanks..!

The NextAction date has arrived: 2018-03-06

M66 Beta promotion is coming VERY soon. Your bug is labelled as Beta  ReleaseBlock, pls make sure to land the fix and request a merge into the release branch latest by 1:00 PM PT Friday, 03/12.  Thank you.

Request merge a revert of crrev.com/c/729220 into M66

Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65a89a06dc98fa2cdeb4b46d1ad5d15145c16f70

commit 65a89a06dc98fa2cdeb4b46d1ad5d15145c16f70
Author: Ella Ge <eirage@chromium.org>
Date: Mon Mar 12 14:40:36 2018

Revert "Disable legacy touch event APIs on desktop"

This CL reverts commit a6a203c9a33449b29f3d98f925a9b61fdf35c2ee.
(crrev.com/c/729220)

We'll leave these feature detection API disabled in canary and
dev channel to gather some feedback. But don't let it in Beta
and Stable channel because it breaks embed map.

Merge this revert into M66

Bug:  804890 
Change-Id: Ib017006081baf12b69fe137ba9aeae915b5274a3
Reviewed-on: https://chromium-review.googlesource.com/958009
Reviewed-by: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#162}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/65a89a06dc98fa2cdeb4b46d1ad5d15145c16f70/chrome/browser/about_flags.cc
[modify] https://crrev.com/65a89a06dc98fa2cdeb4b46d1ad5d15145c16f70/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/65a89a06dc98fa2cdeb4b46d1ad5d15145c16f70/chrome/browser/prefs/chrome_pref_service_unittest.cc
[modify] https://crrev.com/65a89a06dc98fa2cdeb4b46d1ad5d15145c16f70/content/browser/renderer_host/render_view_host_impl.cc

The NextAction date has arrived: 2018-04-19

Request merge a revert of crrev.com/c/729220 into M67

How safe is the crrev.com/c/729220  revert to merge to M67?

crrev.com/c/729220 is just changing a chrome flag default and add a unit test. I'll resolve any conflict manually. It should be very safe.

Approving merge to M67 branch 3396 based on comment #25. Please merge ASAP. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1601b27dea9a6e812d633beed5be89dbb7d38531

commit 1601b27dea9a6e812d633beed5be89dbb7d38531
Author: Ella Ge <eirage@chromium.org>
Date: Thu Apr 19 17:46:21 2018

Revert "Disable legacy touch event APIs on desktop"

This CL reverts commit a6a203c9a33449b29f3d98f925a9b61fdf35c2ee.
(crrev.com/c/729220)

We'll leave these feature detection API disabled in canary and
dev channel to gather some feedback. But don't let it in Beta
and Stable channel because it breaks embed map.

This revert will merge into into M67, but not landed in master branch

Bug:  804890 
Change-Id: Ib017006081baf12b69fe137ba9aeae915b5274a3
Reviewed-on: https://chromium-review.googlesource.com/1019361
Reviewed-by: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#133}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/1601b27dea9a6e812d633beed5be89dbb7d38531/chrome/browser/about_flags.cc
[modify] https://crrev.com/1601b27dea9a6e812d633beed5be89dbb7d38531/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/1601b27dea9a6e812d633beed5be89dbb7d38531/chrome/browser/prefs/chrome_pref_service_unittest.cc
[modify] https://crrev.com/1601b27dea9a6e812d633beed5be89dbb7d38531/content/browser/renderer_host/render_view_host_impl.cc

Applying "ReleaseBlock-Beta" for M-68 as you're planning to merge this change before M68 beta promotion.

Thanks :)

Friendly ping to get an update on this issue as it is marked as beta blocker.
Thanks..!

Gentle ping to get an update on this issue as it is marked as beta blocker.
Thanks..!

dtapuska@/eirage@,

Please let us know the update on this issue.
Thanks..!

Your bug is tagged as Release block Beta and we are branching in 2 days.Please have a fix ASAP.

#33, #34: Our plan is keeping this in Dev channel(and canary) to experimenting potential issue until M70. I will request merging the revert to M68 (and M69 in the future) on around a week before beta promot. The merge will be just reverting a flag change and the unittest, won't be risky.
And I marked the NextActionDay. Don't worry about the branching. Thanks guys.

The NextAction date has arrived: 2018-05-31

Request merge a revert of crrev.com/c/729220 into M68
crrev.com/c/729220 is changing a flag and related unit test, should be safe.

Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4e3ca92b66457758a2bb2ba4cded883dc230c73

commit c4e3ca92b66457758a2bb2ba4cded883dc230c73
Author: Ella Ge <eirage@chromium.org>
Date: Fri Jun 01 14:26:47 2018

Revert "Disable legacy touch event APIs on desktop"

This CL reverts commit a6a203c9a33449b29f3d98f925a9b61fdf35c2ee.
(crrev.com/c/729220)

We'll leave these feature detection API disabled in canary and
dev channel to gather some feedback. But don't let it in Beta
and Stable channel because it breaks embed map.

This revert will merge into into M68, but not landed in master branch

Bug:  804890 
Change-Id: Ib017006081baf12b69fe137ba9aeae915b5274a3
Reviewed-on: https://chromium-review.googlesource.com/1081874
Reviewed-by: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#85}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/c4e3ca92b66457758a2bb2ba4cded883dc230c73/chrome/browser/about_flags.cc
[modify] https://crrev.com/c4e3ca92b66457758a2bb2ba4cded883dc230c73/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c4e3ca92b66457758a2bb2ba4cded883dc230c73/chrome/browser/prefs/chrome_pref_service_unittest.cc
[modify] https://crrev.com/c4e3ca92b66457758a2bb2ba4cded883dc230c73/content/browser/renderer_host/render_view_host_impl.cc

M69 branch is coming soon on July 19th, Your bug is marked as ReleaseBlock-Beta for M69. Please try to land the fix ASAP to trunk in order to prevent many merges going after M69 branch. This will also help us to branch M69 from high quality trunk. Thank you.

eirage@ could you please verify the fix.

Friendly ping to get an update on this issue as per C#44 as it is marked as RBB.
Thanks..!

M69 branch is coming VERY soon on July 19th, Your bug is marked as ReleaseBlock-Beta for M69. Please try to land the fix ASAP to trunk in order to prevent many merges going after M69 branch. This will also help us to branch M69 from high quality trunk. Thank you.

Gentle ping to get an update on this issue as per C#44 & C#46 as it is marked as RBB.
Thanks..!

M69 branch is coming VERY soon on this Thursday, July 19th, Your bug is marked as ReleaseBlock-Beta for M69. Please try to land the fix ASAP to trunk in order to prevent many merges going after M69 branch. This will also help us to branch M69 from high quality trunk. Thank you.

Thanks for reminder. 
As mentioned in #35, the plan for this is keeping this in Dev channel(and canary) to experimenting potential issue until M70. I will request merging the revert to  M69 after branch and on around a week before beta prompt. The merge will be just reverting a flag change and the unittest, won't be risky.

M69 Beta promotion is coming VERY soon. Your bug is labelled as Beta  ReleaseBlock, pls make sure to land the fix and request a merge into the release branch latest by 1:00 PM PT this Friday, 07/27. Thank you.

The NextAction date has arrived: 2018-07-25

Request merge a revert of crrev.com/c/729220 into M68
The revert is just changing a flag and related unit test, should be very safe.

Is this a merge request for M68 or M69? 

It's M69. Sorry for the typo.

Approving merge a revert of crrev.com/c/729220 to M69 branch 3497 based on comment #49 and #52. Please merge ASAP and mark bug as fixed after the merge if nothing else is pending. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e146987b611e192066750e8f4964d85947b99ab3

commit e146987b611e192066750e8f4964d85947b99ab3
Author: Ella Ge <eirage@chromium.org>
Date: Thu Jul 26 14:23:48 2018

Revert "Disable legacy touch event APIs on desktop"

This CL reverts commit a6a203c9a33449b29f3d98f925a9b61fdf35c2ee.
(crrev.com/c/729220)

We'll leave these feature detection API disabled in canary and
dev channel to gather some feedback. But don't let it in Beta
and Stable channel because it breaks embed map.

This revert will merge into into M69, but not landed in master branch

Bug:  804890 
Change-Id: Ib017006081baf12b69fe137ba9aeae915b5274a3
Reviewed-on: https://chromium-review.googlesource.com/1150702
Reviewed-by: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#109}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/e146987b611e192066750e8f4964d85947b99ab3/chrome/browser/about_flags.cc
[modify] https://crrev.com/e146987b611e192066750e8f4964d85947b99ab3/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/e146987b611e192066750e8f4964d85947b99ab3/chrome/browser/prefs/chrome_pref_service_unittest.cc
[modify] https://crrev.com/e146987b611e192066750e8f4964d85947b99ab3/content/browser/renderer_host/render_view_host_impl.cc

Thanks!