New issue
Advanced search Search tips

Issue 804880 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Expose layout tables as tables

Project Member Reported by aleventhal@chromium.org, Jan 23 2018

Issue description

Currently, when a table appears to be a layout table, Chrome does not expose it as a table at all.

On Windows, we should switch to Firefox behavior, where it is still exposed as a table, with the additional object attribute layout-guess:true.

On Android and ChromeOS, we should also expose as a table.

See the attached file for an example table that is treated as a layout table.
On Mac, we should continue to not expose it as a table for now, in order to match Safari and what is expected by VoiceOver users. If we learn in the future that users would prefer these layout tables to be exposed as tables, it can be changed.
 
t.html
241 bytes View Download
Description: Show this description
Labels: tables win-a11y OS-Windows
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7686e185bd779c1fdd8ea7e76bb84f88b941ce24

commit 7686e185bd779c1fdd8ea7e76bb84f88b941ce24
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Wed Jan 31 01:08:25 2018

Layout tables should still be exposed as tables.

When tables exist, we apply a heuristic to determine whether they are
used for layout or for data. Previously, we only exposed tables using
table roles if it appeared to be used for data.

However, some screen readers on some platforms wish to make this
determination.

For some platforms, expose the layout table as a table with a hint
that it is used for layout. We can more easily change this for each
platform going forward by simply changing the mapping of
Role::kLayoutTable and kLayoutTable[Cell|Column|Row]

For now:
- Windows and ChromeOS -- treat layout tables as tables
- Mac and Android -- treat layout tables as ordinary text containers.
For Mac, we are following this convention until we determine that it
would be desirable to be different from Safari and how we worked before.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9a8f59e2a2d62b6d2e65b8beae59bd923fea25d9

Bug:  804880 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9a8f59e2a2d62b6d2e65b8beae59bd923fea25d9
Reviewed-on: https://chromium-review.googlesource.com/879283
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533136}
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/aria/aria-sort-html-table-expected-blink.txt
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/aria/aria-sort-html-table-expected-mac.txt
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/aria/aria-sort-html-table-expected-win.txt
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/aria/aria-sort-html-table.html
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/html/landmark-expected-android.txt
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/html/landmark-expected-blink.txt
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/html/landmark-expected-mac.txt
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/html/landmark-expected-win.txt
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/html/landmark.html
[add] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/html/table-layout-expected-android.txt
[add] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/html/table-layout-expected-blink.txt
[add] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/html/table-layout-expected-mac.txt
[add] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/html/table-layout-expected-win.txt
[add] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/html/table-layout.html
[add] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/content/test/data/accessibility/html/table-simple-2.html
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/LayoutTests/accessibility/name-calc-visibility.html
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/LayoutTests/accessibility/non-data-table-cell-title-ui-element.html
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/LayoutTests/accessibility/table-detection-expected.txt
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/LayoutTests/accessibility/table-one-cell-expected.txt
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/LayoutTests/accessibility/table-with-rules-expected.txt
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/LayoutTests/accessibility/table-with-rules.html
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-visiblity.js
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/Source/modules/accessibility/AXEnums.cpp
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/Source/modules/accessibility/AXEnums.h
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/Source/modules/accessibility/AXTable.h
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/Source/modules/accessibility/AXTableColumn.h
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/WebKit/public/web/WebAXEnums.h
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/ui/accessibility/ax_enum_util.cc
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/ui/accessibility/ax_role_properties.cc
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/7686e185bd779c1fdd8ea7e76bb84f88b941ce24/ui/accessibility/platform/ax_platform_node_win.cc

Status: Fixed (was: Started)

Sign in to add a comment