New issue
Advanced search Search tips

Issue 804878 link

Starred by 1 user
Status: Fixed
Owner:
falken@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 715640



Sign in to add a comment

S13nServiceWorker: pass the WPT test fetch-event.https.html

Project Member Reported by falken@chromium.org, Jan 23 2018 
non-S13nSW is also failing some test cases, but S13nSW has two additional failures:

-PASS Service Worker responds to fetch event with string
+FAIL Service Worker responds to fetch event with string assert_unreached: unexpected rejection: assert_equals: The character set of the response created with
 a string should be UTF-8 expected "UTF-8" but got "windows-1252" Reached unreachable code

-PASS Service Worker responds to fetch event with the correct keepalive value
+FAIL Service Worker responds to fetch event with the correct keepalive value assert_equals: expected "true" but got "false"

The keepalive one looks easy to fix, patch coming.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e99228c44d2cceda751d1ad7df650ce5b9742b41

commit e99228c44d2cceda751d1ad7df650ce5b9742b41
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Jan 24 02:00:39 2018

S13nServiceWorker: Plumb Request#keepalive to FetchEvent.

This makes one of the failing test cases in fetch-event.https.html pass
when run with NetworkService (but there is no expectation change as
FlagExpectations still must expect Failure due to another test case
failure).

Bug:  804878 ,  695939 
Change-Id: I44c152f14282c2cefa056ece13e8f0bf9703676b
Reviewed-on: https://chromium-review.googlesource.com/881382
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531401}
[modify] https://crrev.com/e99228c44d2cceda751d1ad7df650ce5b9742b41/content/renderer/service_worker/service_worker_context_client.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09225a0c142c3c29297779616d406a6793ae2b2b

commit 09225a0c142c3c29297779616d406a6793ae2b2b
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Jan 24 09:25:28 2018

S13nServiceWorker: Plumb the response charset from the service worker to the page.

Unlike MIME type I'm not setting a hard-coded default value since I'm not
sure why it's needed.

It's not clear why MIME type is setting a default value but I suspect
it has to do with the MIME sniffing bug. I added a TODO.

R=kinuko, shimazu

Bug:  804878 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I82df41f166b879edcca5aa270c5eccf9a0cd3dbd
Reviewed-on: https://chromium-review.googlesource.com/882904
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531487}
[modify] https://crrev.com/09225a0c142c3c29297779616d406a6793ae2b2b/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/09225a0c142c3c29297779616d406a6793ae2b2b/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService

Comment 3 by falken@chromium.org, Jan 25 2018

Status: Fixed (was: Started)
►

Sign in to add a comment