On systems with frequent audio path glitches AEC3 leaks more echoes than necessary |
|||||||
Issue descriptionWhen the audio path changes frequently in small steps, the approach taken in AEC3 that responds to these changes by resetting the filter is too drastic and causes unnecessary echo leakage.
,
Feb 6 2018
,
Feb 7 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 7 2018
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 Beta release. Thank you.
,
Feb 7 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/52a27e759e097838d34137ca1fd1779a990e51bd commit 52a27e759e097838d34137ca1fd1779a990e51bd Author: Per Åhgren <peah@webrtc.org> Date: Wed Feb 07 19:50:58 2018 Merge to M65: Improved robustness and recovery speed in AEC3 during... This CL adds robustness in terms of echo removal and faster recovery in order to regain echo canceller transparency after echo path changes. The CL does: -Improve the adaptation rate of the linear filter. -Increase the look-window used before the linear filter has adapted. -Decrease the effects of missed detection of residual echo. -Increase the safety margin before allowing the suppressor gain to increase. TBR=henrik.lundin@webrtc.org,gustaf@webrtc.org (cherry picked from commit 29f14322d13e126c1c9cab0d3bf874bd2a652fdb) Bug: chromium:804873 , webrtc:8788 Change-Id: I28eedc4c8d0a4f0bc7b79c02d6d59bf00fddd566 Reviewed-on: https://webrtc-review.googlesource.com/48721 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Original-Commit-Position: refs/heads/master@{#21917} Reviewed-on: https://webrtc-review.googlesource.com/49500 Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/branch-heads/65@{#13} Cr-Branched-From: 3ac67a736bb200ecf7c116a88b2f8d5c542973c8-refs/heads/master@{#21637} [modify] https://crrev.com/52a27e759e097838d34137ca1fd1779a990e51bd/modules/audio_processing/aec3/aec_state.cc [modify] https://crrev.com/52a27e759e097838d34137ca1fd1779a990e51bd/modules/audio_processing/aec3/main_filter_update_gain_unittest.cc [modify] https://crrev.com/52a27e759e097838d34137ca1fd1779a990e51bd/modules/audio_processing/aec3/residual_echo_estimator.cc [modify] https://crrev.com/52a27e759e097838d34137ca1fd1779a990e51bd/modules/audio_processing/include/audio_processing.h
,
Feb 7 2018
Already merged to M65 at #5.
,
Feb 7 2018
,
Feb 7 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Feb 6 2018