webrtc_overrides missing definitions |
||||||||
Issue descriptionChrome Version: master OS: OSX What steps will reproduce the problem? (1) Reference rtc::LS_NONE from WebRTC, e.g. RTCLogging.mm (2) mac_chromium_webrtc overrides definitions in rtc_base/logging.h What is the expected result? mac_chromium_webrtc builds without issues. What happens instead? mac_chromium_webrtc build fails. //src/third_party/webrtc_overrides/rtc_base/diagnostic_logging.h overrides definitions in rtc_base/logging.h but lacks some symbols that are in rtc_base/logging.h, for example rtc::LS_NONE in the LoggingSeverity enum. The overrides should remap this value as well.
,
Mar 12 2018
Any update on triaging this one please?
,
Apr 26 2018
Ping.
,
May 11 2018
Henrik, would you mind having a quick look at this?
,
May 14 2018
Any reason you need to use LS_NONE? It doesn't seem to be used except for in tests, which are not run in Chromium. If needed, LS_NONE must be added to the overrides version.
,
May 15 2018
,
May 16 2018
,
Jun 12 2018
We'd like to use it from WebRTC: https://bugs.chromium.org/p/webrtc/issues/detail?id=8735 and eventually for b/71817132.
,
Jun 15 2018
Peter, can you add it yourself? It should be trivial. I can also do it but have more prioritized things right now.
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e94384b743c7814182ba0e40262127be0fd99c39 commit e94384b743c7814182ba0e40262127be0fd99c39 Author: Peter Hanspers <peterhanspers@chromium.org> Date: Mon Oct 15 12:13:26 2018 Adding LS_NONE to LoggingSeverity Bug: 804870 Change-Id: I7ba8e6a61eccfb1ea9f4096cb2839d7a9f71c7af Reviewed-on: https://chromium-review.googlesource.com/c/1151108 Commit-Queue: Peter Hanspers <peterhanspers@chromium.org> Reviewed-by: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#599615} [modify] https://crrev.com/e94384b743c7814182ba0e40262127be0fd99c39/third_party/webrtc_overrides/rtc_base/diagnostic_logging.h
,
Jan 7
I'm assuming this can be closed after fix in comment #10. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by erikc...@chromium.org
, Jan 30 2018