New issue
Advanced search Search tips

Issue 804863 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove old auto_bisect related scripts

Project Member Reported by perezju@chromium.org, Jan 23 2018

Issue description

simonhatch said (copy pasting from email thread):

The original bisect script has mostly been deleted, it looks like a few bits and pieces like this script were just missed.

From quickly looking at that directory (tools/), I think you can remove these:

bisect-manual-test.py
prepare-bisect-perf-regression.py
run-bisect-manual-test.py
run-bisect-perf-regression.py
run-perf-test.cfg

Might be others, I didn't look closely.

 
Owner: perezju@chromium.org
Status: Started (was: Untriaged)
I've got a few more questions:

- From  issue 747687  I see that we once attempted to remove these files, but the removal got reverted because the try_job script still makes a reference to tools/run-perf-test.cfg:
https://github.com/catapult-project/catapult/blob/b1764295677303c32cf6ca296bb4e50c49f1dba6/dashboard/dashboard/start_try_job.py#L37

- I've also found that both prepare-bisect-perf-regression.py and run-bisect-perf-regression.py are still being referenced by recipes, e.g. from:
https://cs.chromium.org/chromium/build/scripts/master/factory/chromium_commands.py?rcl=b9f2627e9dcc95d09b9dfdac424ccf40ff70fff9&l=628

Both scripts appear to be broken though (they import things from the non-existent autobisect).

Are these still safe to delete? Sounds like we should also do some cleanup on recipes?
Summary: Remove old auto_bisect related scripts (was: Remove old autbisect scripts)
Blocking: 801578
I *think* it's ok to delete now. The perf try recipe does read this file, but there are no more bots (all are on Pinpoint), and the internal ones don't support perf try jobs.

Those references in the chromium_commands.py file look like the initial buildbot support I added back in 2013 (pre-recipes), I doubt they're used by anything at this point.
Cc: perezju@chromium.org
Components: Speed>Bisection
Labels: Hotlist-CodeHealth
Owner: ----
Status: Available (was: Started)
Old bisect scripts gone. Hopefully for good this time.

Leaving this open for cleaning up the old (pre-recipes) references to the scripts. It sounds to me that much of that is now completely unused, but not sure about the actual extent.
Blocking: -801578

Comment 8 by term...@gmail.com, Jan 31 2018

On the Chromium bisect page it says:

"Want to bisect your local checkout rather than prebuilt binaries? Use run-bisect-manual-test.py." But that no longer works:

https://www.chromium.org/developers/bisect-builds-py
https://www.chromium.org/system/errors/NodeNotFound?suri=wuid:gx:3bb6ccd81a24fea2

When I searched this issue came up. If it's not related and I should open a new issue please let me know. Thanks


Sorry, that reference to run-bisect-manual-test.py was outdated, the script is no longer supported.

I've edited that piece of documentation to remove references to that script.

Sign in to add a comment