Remove old auto_bisect related scripts |
|||||
Issue descriptionsimonhatch said (copy pasting from email thread): The original bisect script has mostly been deleted, it looks like a few bits and pieces like this script were just missed. From quickly looking at that directory (tools/), I think you can remove these: bisect-manual-test.py prepare-bisect-perf-regression.py run-bisect-manual-test.py run-bisect-perf-regression.py run-perf-test.cfg Might be others, I didn't look closely.
,
Jan 23 2018
,
Jan 23 2018
,
Jan 23 2018
I *think* it's ok to delete now. The perf try recipe does read this file, but there are no more bots (all are on Pinpoint), and the internal ones don't support perf try jobs. Those references in the chromium_commands.py file look like the initial buildbot support I added back in 2013 (pre-recipes), I doubt they're used by anything at this point.
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70d7b68f1669306da4c713c7e4d4b0be97a13ab8 commit 70d7b68f1669306da4c713c7e4d4b0be97a13ab8 Author: Juan Antonio Navarro Perez <perezju@google.com> Date: Thu Jan 25 10:07:40 2018 Remove old bisect-related scripts These do no longer work. Bug: 804863 Change-Id: Id0bfff21aa9d7fc4338a37bdfcdf9d820ce32ea5 Reviewed-on: https://chromium-review.googlesource.com/881321 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Simon Hatch <simonhatch@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#531862} [modify] https://crrev.com/70d7b68f1669306da4c713c7e4d4b0be97a13ab8/WATCHLISTS [modify] https://crrev.com/70d7b68f1669306da4c713c7e4d4b0be97a13ab8/tools/OWNERS [delete] https://crrev.com/302e6c7c0ff0e97bb3f5ba7e6bd311197319584e/tools/bisect-manual-test.py [delete] https://crrev.com/302e6c7c0ff0e97bb3f5ba7e6bd311197319584e/tools/prepare-bisect-perf-regression.py [delete] https://crrev.com/302e6c7c0ff0e97bb3f5ba7e6bd311197319584e/tools/run-bisect-manual-test.py [delete] https://crrev.com/302e6c7c0ff0e97bb3f5ba7e6bd311197319584e/tools/run-bisect-perf-regression.py [delete] https://crrev.com/302e6c7c0ff0e97bb3f5ba7e6bd311197319584e/tools/run-perf-test.cfg
,
Jan 25 2018
Old bisect scripts gone. Hopefully for good this time. Leaving this open for cleaning up the old (pre-recipes) references to the scripts. It sounds to me that much of that is now completely unused, but not sure about the actual extent.
,
Jan 29 2018
,
Jan 31 2018
On the Chromium bisect page it says: "Want to bisect your local checkout rather than prebuilt binaries? Use run-bisect-manual-test.py." But that no longer works: https://www.chromium.org/developers/bisect-builds-py https://www.chromium.org/system/errors/NodeNotFound?suri=wuid:gx:3bb6ccd81a24fea2 When I searched this issue came up. If it's not related and I should open a new issue please let me know. Thanks
,
Feb 1 2018
Sorry, that reference to run-bisect-manual-test.py was outdated, the script is no longer supported. I've edited that piece of documentation to remove references to that script. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by perezju@chromium.org
, Jan 23 2018Status: Started (was: Untriaged)